shapelets / khiva-csharp Goto Github PK

Describe the bug
I have cloned the repo. Am able to compile the solution fine. All the tests in the tests project fail except the LIbraryTests. All the other tests result in the test host crashing. Stepping through the test, the error / crash happens when the KhivaArray Reference property is accessed. Not sure why this would be the case. See screen shot below.

To Reproduce
Using Visual Studio 2019 in the khiva install.bat script (in tools folder). Changed line:
cmake .. -DCMAKE_TOOLCHAIN_FILE="%path_to_vpkg%/scripts/buildsystems/vcpkg.cmake" -DKHIVA_USE_CONAN=OFF -DKHIVA_BUILD_JNI_BINDINGS=OFF -DKHIVA_BUILD_DOCUMENTATION=OFF -G "Visual Studio 16 2019"

Expected behavior
All tests should pass.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment information:

• OS: Windows 10 x64
• Version 1909
  
• Visual Studio 2019
• Khiva dependencies versions : I ran the install.bat in the khiva tools director. Seems latest was downloaded. ArrayFire 3.6.2. Not sure how to tell the Boost version.

Additional context
When I run the test binaries in the khiva build\bin folder, the tests all pass. So the c/c++ khiva library seems fine as far as I can tell.
PS C:\Users\hooman\source\repos\khiva\build\bin> .\polynomial.exe
Running main() from C:\Users\hooman\source\repos\vcpkg\buildtrees\gtest\src\ase-1.10.0-7231afa423.clean\googletest\src\gtest_main.cc
[==========] Running 3 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 3 tests from PolynomialTests
[ RUN ] PolynomialTests.Polyfit1
�[32m[----------]�[0m CPU backend, device: Intel CPU
[ OK ] PolynomialTests.Polyfit1 (866 ms)
[ RUN ] PolynomialTests.Polyfit3
�[32m[----------]�[0m CPU backend, device: Intel CPU
[ OK ] PolynomialTests.Polyfit3 (1 ms)
[ RUN ] PolynomialTests.Roots
�[32m[----------]�[0m CPU backend, device: Intel CPU
[ OK ] PolynomialTests.Roots (6 ms)
[----------] 3 tests from PolynomialTests (876 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (878 ms total)
[ PASSED ] 3 tests.

Describe the bug
The published nuget package is a copy of the entire git source code vs just the .net assembly.

To Reproduce
Add the nuget to your Visual Studio project. Go to the package folder and view the contents.

Expected behavior
The nuget contents should just be the khiva csharp assembly file.

Screenshots

Environment information:

• OS: Windows 10 x64
• Version 1909
• Khiva dependencies versions [e.g. ArrayFire 3.6.2, Boost 1.66.0] N/A

Additional context
N/A