shawntangy / pe Goto Github PK

Link is broken both in the pdf file and in the website.

Where are the arrows on the right pointing to? Some of them even go outside of the alt reference frame. The reader may find this diagram confusing.

showLine() is actually called twice instead of once, but the sequence diagram reflects it differently. Could consider abstracting this into a constant and directly printing the constant since the showLine() method only has 1 print.

A user may want to add in a number with an attached country code. The error the occurs mentions that the number is too big instead of saying that the '+' is not allowed, this may cause the user to think that their number has issues instead of the formatting.

When the user is changing the event name, the user may accidentally type in a pipe at the end like this.

For example the user wants to host the 2nd career fair of nus - NUS Career Fair 2 but types NUS Career Fair |2
The user then sets the venue at Engineering Auditorium with choose venue 1.
The user then exits the program.

Upon resuming the program, not only is the event name changed, the venue is also changed.

This can cause a mismatch in the intended venue and name, potentially causing major problems for all companies involved, especially since the venue and name of the event is only shown once during the entrance screen.

In the event that the number is 6 or above, the venue selected will be removed.

The user can only view list confirmed to see which companies are yet to be confirmed. However, it would be a helpful feature if the user can also view the current confirmed list to see if there are enough companies for the career fair before deciding to cancel it in the event that there is very little confirmed companies.

In the event that the user wants to edit the venue, they are unable to do so. (e.g. if a part of the venue is currently undergoing renovation, the capacity may be reduced yet the user is unable to update the program.)

In the NFR, it only mentions that an operating system is required and that java is not required. This is wrong and may mislead people to think that this program can run without the java application.

Since this program is catered towards fast typing instead of GUI, mistakes make occur like when a user accidentally adds in a '|' in the industry field.

Here the pipe does not affect functionality, but upon restarting, the program will change 'HE|ALTHCARE' TO 'HE'

In the event that the user is unaware of this, the functionality of the find industry command is reduced.

Users that want to run 'find industry healthcare' will not see the supposed company.

In the event that there are new venues (new buildings available for career fairs) the user is unable to add in new venues.

The variable companyList is only assigned to and is never used anywhere else. Could consider removing it from the code.

User guide mentions that email should be a valid email, but does not check if there's a .net/.com

User may key in the wrong email address which may lead to emails not being sent out for future features.

testing 123

The Hyperlink in the quick start portion provided points to the older release version, which may include previous bugs.

Under the manual testing, the developer guide only mentions how to load in the sample data, but does not provide any test case to know if it works or not. This is unlike address book level 3. The manual tester does not know the expected outcome due to the missing information.

When the user wants to view the current status - where is the venue after confirmation and the event name, the only way they can do so is when the program is restarted