sheadawson / silverstripe-rateable Goto Github PK

even on security/login

should we check if the page has an positive ID set before rendering the $RateableUI?

Hi, is any update to SS4 planed?

First of all, great module!

Heres the things:
I've attached Rateable to "StoryPage", and the UI shows up fine when looping these pages out. However, if I loop the same Storypages, multiple places on the same pages, it breaks. This is because of the ID used in the injected JavaScript.

My hacky fix was to modify getRatingHTMLID() function to add a random number to the ID:

    public function getRatingHTMLID(){
        return $this->owner->ClassName . '-' . $this->owner->ID . '-' . 'rating-' . rand();
    }

Might need to figure out a better way to fix this

I need to have at least 10 or so star ratings on one page, is that possible to work for on the rateable module?? if there's a code for it, let me know. Thanks. :)

Hi again, and thanks for fixing the last issue so fast!

It seems the userHasRated() function in the RateableService class is broken. I can rate an item, refresh the page, and rate again.

Any ideas why this happens?

Currently the 5 start rating UI displays strangely when installed on the simple theme.

Screen Shot 2013-12-31 at 2.09.31 pm.png | uploaded via ZenHub

Hi,
why is there no minified versions of js components?
I'll try to minify and test them to see if they work, and get back to you with results.

Best,
Petar

there are untranslated strings:

php: updateCMSFields
javascript: the "thanks" and "already rated" message.

I'm happy to create a PR for this

Could you please use git tags for releases? including dev-master in my config.json feels a bit bad. And releases will be cached locally so installing / updating is way faster.

Perhaps the default should be set to off and explicitly turned on?