shentufoundation / oracle-operator Goto Github PK

DESCRIPTION
Calling Close() method may return an error, and ignoring the same might result in a data loss. This is similar to many more Close methods.

For example, on POSIX systems, os.Close uses the close system call underneath, which may return an EIO:

A previously-uncommitted write(2) encountered an input/output error.

This means that the data written by os.Write hasn't been written to the disk, which results in a data loss. It is recommended to handle the error returned by the os.Close call or call os.Sync if available to force the OS to write the data to the disk.

Deferring unsafe method "Close" on type "io.ReadCloser"
oracle-operator/blob/main/oracle/http.go#L95-L95 and oracle-operator/blob/main/oracle/http.go#L98-L98

CWE: https://cwe.mitre.org/data/definitions/703.html

Introduce default strategy section such as follows in configuration file so that oracle operators can provide response to protocols without specific configuration.

[strategy.default]
  # combination strategy
  type = "linear"
  [[strategy.default.primitive]]
  primitive_type = "static-analysis-primitive-v3"
  weight = 3
  [[strategy.default.primitive]]
  primitive_type = "onchain-monitoring-primitive-v3"
  weight = 5
  [[strategy.default.primitive]]
  primitive_type = "social-sentiment-primitive-v3"
  weight = 5
  [[strategy.default.primitive]]
  primitive_type = "governance-autonomy-primitive-v3"
  weight = 10
  [[strategy.default.primitive]]
  primitive_type = "market-volatility-primitive-v3"
  weight = 10
  [[strategy.default.primitive]]
  primitive_type = "safety-assessment-primitive-v3"
 weight = 10

probably should be github CI

E[2022-12-21|10:14:11.947] error unmarshalling result: unknown field "sender" in types.ResponseCheckTx module=oracle-operator protocol=certik submodule=pusher type=MsgTaskResponse

it seems like it can't properly decode types.ResponseCheckTx either during gas estimation or the tx submission result