shervangharari / fhimp Goto Github PK

'Station ID': ['02AC002','02CF007','02CF012','02EC011','02ED003','02ED102','02GE005','02GH002','02GH003','02HB004','02HB012','02HC009','02HC013','02HC018','02HC023','02HC025','02HC031','02HC032','02HD008','02HJ001','02HL003','02HM005','02LA007','02MC001','02ED007','02CF005','02CF010','02DB005','02DD010','02FA001','02GA003','02GA015','02GA031','02GA039','02GA040','02GB010','02GD001','02GD003','02GD008','02GD016','02HB001','02HB011','02HC027','02HL001','02HM002','02KB001','02KC009','02KF001','02KF012'],
'seg ID': [72030584,72041562,72041948,72051928,72051740,72051968,72056760,72058531,72058424,72056014,72057219,72052069,72052687,72052485,72052773,72051951,72055156,72053057,72052697,72052577,72051901,72051901,72047191,72047350,72052534,72043488,72041139,72040672,72046858,72051711,72055097,72055277,72057550,72052222,72055295,72056898,72055542,72055558,72056019,72055670,72052509,72055826,72057713,72051564,72054207,72046898,72046911,72046509,72047556],
'Station name': ['02AC002','02CF007','02CF012','02EC011','02ED003','02ED102','02GE005','02GH002','02GH003','02HB004','02HB012','02HC009','02HC013','02HC018','02HC023','02HC025','02HC031','02HC032','02HD008','02HJ001','02HL003','02HM005','02LA007','02MC001','02ED007','02CF005','02CF010','02DB005','02DD010','02FA001','02GA003','02GA015','02GA031','02GA039','02GA040','02GB010','02GD001','02GD003','02GD008','02GD016','02HB001','02HB011','02HC027','02HL001','02HM002','02KB001','02KC009','02KF001','02KF012'],
'up': [0,0,0,1,1,1,0,0,0,0,0,0,1,1,0,0,1,0,1,0,0,1,1,0,0,0,1,0,0,1,1,1,0,0,1,0,0,1,0,1,0,1,0,0,0,0,0,1,0]

'Station ID': ['02PC002', '02PD010','02PD002', '02PJ007', '02PJ005', '02RH015', '02PF001', '03QB001', '02OE024', '02OE027', '02OD010', '02OD003', '02OG026', '02OG019',
'02OG002', '02OA054', '02OB008', '02LC008', '01BO001', '01AL002', '01AP004', '01DG003', '01DP004', '02ZB001', '02YJ001', '02YO006', '02YQ001', '02ZG004', '02ZM008'],
'seg ID': [72040104, 72041673, 72040989, 72041157, 72039864, 72035172, 72035169, 72030083, 72047258, 72047440, 72047248, 72047032, 72047492, 72047029,
72047133, 72046542, 72046631, 72047259, 72040296, 72046658, 72047146, 72054611, 72049050, 72036257, 72034863, 72031513, 72030124, 72045751, 72036943],
'Station name': [
'Jacques Cartier', 'Saint-Charles', 'Montmorency', 'Beaurivage', 'Chaudière', 'Chicoutimi', 'Malbaie', 'Matane', 'Saint-François', 'Eaton', 'Bulstrode', 'Nicolet',
'David', 'Noire', 'Yamaska', 'Chateauguay', 'Assomption', 'du Nord', 'Miramichi sud ouest', 'Nashwaak', 'Kennebecasis', 'Beaverbank', 'Middle river of pictou',
'Isle aux morts', 'Harrys river', 'Peters river', 'Gander river', 'Rattle brook', 'Waterford river']

I suggest separating the modeling files and forcing manipulation into two separate folders or steps. For example, the subfolders of folder 03-model-specific can be like this:

• 03-model-specific:
  • MESH:
    - Forcing
    - File
  • HYPE:
    - Forcing
    - File
  • MESH:
    - Forcing
    - File

The user then can set up a model without any specific forcing in hand. We can also centralize the Forcing manipulation in a more centralized way that can be easier called (actually then it would be kind of model agnostic).
The model agnostic part can also follow the same logic. I understand currently it is possible, but it would be cleaner to separate the data tool and remap call and the gistool separately.

I would suggest bringing the 0-prerequisits fully outside the model setup scripts as a folder directly in the main repository folder with names such as env_config.
Let me know if I should do any of the action myself.

I would suggest adding the easymore installation after the hydrant in 0-prerequisits:
pip install git+https://github.com/ShervanGharari/EASYMORE.git@develop_2.0.0
I have tested this and it works fine.
Later, when version 2 is released, we can add that to the requirements.txt file (perhaps similar to the hydrant and meshflow).