shivammistry / rsloader Goto Github PK

Upon launching the client for Old-School Runescape:

0.819672131147541
javaError: bh.<init>() bf.ah() | SampleModel:126 SinglePixelPackedSampleModel:144 SinglePixelPackedSampleModel:110 PackedColorModel:310 bh:28 bf:301 bf:341 Thread:748 | java.lang.IllegalArgumentException: Width (0) and height (0) must be > 0
error_game_crash
http://oldschool5.runescape.com/error_game_crash.ws
_self

Hi I have been using your code for a year now on a test project and never took the time to understand what's actually going on but it has always worked and I hacked it to load only old school.

Always receiving the following error:
Error: ba.() bp.u() | java.awt.image.SampleModel. java.awt.image.SinglePixelPackedSampleModel. java.awt.image.SinglePixelPackedSampleModel. java.awt.image.PackedColorModel.createCompatibleSampleModel ba:28 bp:298 bp:338 java.lang.Thread.run | java.lang.IllegalArgumentException: Width (0) and height (0) must be > 0

But it seems to collect all properties except for browser crap. It then spews out unrelated errors due to other code failing because of that code. I went on github and used couple different sources of loading rs into applet and they all getting same error message.

Launcher should check to see if the 'jav_config.ws' file has been changed and cache the files it needs to download for if it hasn't changed.

For example, if I play oldschool once, the launcher will download http://oldschool.runescape.com/jav_config.ws. it will then download the necessary gamepack_xxxxxx.jar file from it, based on the value of initial_jar. An entry might read initial_jar=gamepack_3065604.jar (and it does right now).

It also appears to download initial_class - which it doesn't look like the name changes for: client.class.

My suggestion is that if the checksum of jav_config.ws is the same as from the last run, that the launcher just recycle the old files instead of grabbing them again.

Alternately, it looks like the jav_config.ws file also contains a few more helpful entries for more intelligent checking:

viewerversion=124
win_sub_version=1
mac_sub_version=2
other_sub_version=2

And you could probably checksum client.class as well, it's a much smaller file than the gamepack jar file.

Just some ideas - I'm not sure what is used to determine if the official launcher needs to update. But it would greatly accelerate load time.

Also, I want to thank you for this - I got it on my phone with a debian chroot and openJDK and it's been fun to play with. It's simple enough that someone with little recent Java experience (I program in C) could easily figure a lot of it out.