GithubHelp home page GithubHelp logo

trecipe's People

Contributors

dependabot[bot] avatar knox153 avatar shizuko-akamoto avatar shumal1 avatar tianyan-zhu avatar

Stargazers

 avatar

Watchers

 avatar  avatar

trecipe's Issues

Flash of unstyled content on My Trecipe page

There is flash of unstyled content on the Trecipe logo. To be addressed in the future

Steps to reproduce:

  1. Go to My Trecipe page
  2. Give all your attention to the Trecipe logo/font on the top left
  3. Refresh the page

Result: The logo has a different font-family for a brief moment.
Expected: The font family of the logo should remain the same

The gif is slowed down to make it more obvious:

fous

Map page issues and to do list

Listing down some items that I didn't have time to address ¯\(ツ)

To do list

  1. (Bug) Refreshing the page on the Map or the Trecipe page will wipe all the destinations. To restore them, users will have to go back to My Trecipe page and reenter. Fixed in #94

  2. (Bug) After adding a destination on the Trecipe page, the result drop down will close. No longer an issue

  3. (Bug) On the map page, search for any place and click on them to add them to the destination cards list (there will be a tick to indicate that it has been added). Now click 'delete' on the destination card's menu. The result drop down on the search bar will still show the tick even though the destination is removed from the list Fixed by Shizuko

  4. Long name and location do not bode well for the destination cards on the map page (rating bar shifted, checkmark is gone). Fixed, long name will not be truncated, rating bar will remain at the same location and checkmark is always displayed.
    image

  5. Update the static map's marker icon to match the markers on the map page Not possible :( Static map can contain up to 5 unique icons and we have 10 icons (5 categories and 2 colors), so we can either display completion status or categories. Currently displaying completion status

  6. Update the search bar on header to use autocomplete service (check out the search bar on the map page) Addressed in search PR

  7. check if google is initialized before using them. example: if(google) let map = new google.maps.map()

  8. It is possible to add duplicate destination for now, might have to change this Fixed by Shizuko

  9. Adding location bias on map search might be a good idea

  10. scrollIntoView() is not smooth on google chrome

  11. Add a legend for marker colors #87 Done

  12. scrollIntoView() on destination add is not working because it is using place id while destination card is using uuid

Optionals

  1. Check if there is any unnecessary re-render on map, and see if using pure component improve performance. If pure component is used, ensure markers on the map is updated when a destination is added/updated

  2. Responsive design. Currently, when the user resizes the window, the map will shrink until destination cards are left. On mobile, only destinations cards are visible. Maybe we could create a mobile UI where the map is always located on the top and the bottom half are the destination cards.

  3. Use async and await to improve readability.

  4. Improve the way we load google map script. <LoadScript> is used to do lazy loading when we need any google map service. At the moment, we load the script once before loading any pages in between the header and footer. One improvement might be wrapping any elements that require google map service in <LoadScript>, but this requires multiple api keys. Since our header has search bar (it always requires google autocomplete service), another good idea might be loading the script in index.html, though this might slow down the page on the first load. Components that require map service:

    • Map & Search bar on the map page
    • Search bar popup on the Trecipe page
    • Search bar on the header

[Map] Create MAP

  • create an interactive map

  • zoom in/out functionalities

  • hover over each destination to see destination digest.

  • click to bring up the destination page

Trecipe cover photo popup styling bug

The styling on enlarged cover photo popup needs to be fixed. And ideally it should use the Model component and showModel dispatch for consistency instead of keeping track of open/closed state internally.

[Search] Search results page

  • Reuse Trecipe Cards and Destination Cards
  • Create User cards

Search results page will show all three sets of result categories (Trecipe, Destinations, User)

[Google API] for Search

Implement #57

  • set up the backend for receiving queries [keywords from clients]
  • make api calls from backed
  • conversion from search result to destination model
  • send result back to display

[TC][BE] Set-up tables/schemas

Story Points: 2

  • Name
  • Date of create (timestamp)
  • Last modified
  • Picture
  • Owner
  • (Collaborators)
  • privacy setting
  • Card ID [CardID + Destination (separate table)]

Scale the fontsize at root html element

The font size css property at the root element will be scaled using a percentage (1rem = 10px). The advantage of this approach is that it will still respect the user's browser default font setting and we no longer need to use a calculator to convert px into rem.

  • Change the css property at root element
  • Update the current css files

[User] Basic User model

Story Points: 1 week :D

  • create user
  • show trecipe according to the user
  • authenticate user (library)

Redirect after Trecipe actions in Map page

User is able to perform Delete and Duplicate Trecipe from the Map page. When the request for those action has been successfully completed, the user should be redirected to corresponding pages.
For delete => back to MyTrecipes page
For duplicate => to Map page of the newly created duplicate

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.