shkm / enummer

🏳️‍🌈 Multi enums (aka flags) for Rails

“The programmer, like the poet, works only slightly removed from pure thought-stuff. He builds his castles in the air, from air, creating by exertion of the imagination.” ― Frederick P. Brooks Jr

enummer's Issues

Consider adapters

Right now we use the same implementation for any database, but it would be preferable to support optimizations in each. Postgres, for example, provides a bitstring field which was actually the original enummer implementation; whilst it's a little more complex to code around, I believe it can use indexes and should therefore be preferred under that DB.

Bug: Creating a new record without any values specified throws an error

[2] pry(main)> Supplier.new.services
NoMethodError: undefined method `&' for "0":String
from /usr/local/bundle/gems/enummer-1.0.1/lib/enummer/enummer_type.rb:34:in `block in deserialize'

Allow strings instead of symbols in the setter

Hey there!

Thanks a lot for this gem! I just discovered it today and it's fantastic! I just have one issue when trying to use forms (rails 7) and enummer.

This is my setup:

# models/member.rb
class Member < ApplicationRecord
  ...
  enummer dietary_restriction: %i[vegetarian vegan celiac lactose_intolerant nut_alergy]
  ...
end

Then, the form.

# _form.erb
<%= form.label :dietary_restriction %>
  <% Member.dietary_restriction.each do |dr| %>
    <%= form.check_box :dietary_restriction, {multiple: true, checked: form.object.send("#{dr}?")}, dr.to_s, '' %>
    <%= form.label :dietary_restriction, value: dr.to_s %>
  <% end %>
<% end %>

At the end, the members_controller try to do an update to the model, but the dietary_restriction is an array of strings, so it doesn't save anything. I had to add this method to the model:

# models/member.rb
class Member < ApplicationRecord
  ...
  enummer dietary_restriction: %i[vegetarian vegan celiac lactose_intolerant nut_alergy]
  before_save :fix_enummer

  def fix_enummer
    self.dietary_restriction.map!{ |dr| dr.to_sym }
  end
  ...
end

Add scope for all inclusive bits

E.g. if I do where(permissions: %i[read execute]) it will return all items where permissions contain read OR execute. We'd like a scope that returns only items that include BOTH read AND execute.

This would be something like (bits & column = bits)

Auto push gem on deploy

Todo. Couple this with 0.1.1 (sets min ruby version)

Does not recognize falsy values

  test "recognizes boolean params" do
    @user1.update!(ActionController::Parameters.new({"consumes_cigarettes"=>"false"}).permit(:consumes_cigarettes))
    refute @user1.consumes_cigarettes?
  end

Failure:
EnummerTest#test_update_with_prefix2 [test/enummer_test.rb:108]:
Expected true to not be truthy.

Bugged update with prefix

  test "update with prefix" do
    assert @user1.consumes_cigarettes?
    refute @user1.consumes_greens?
    @user1.update!(consumes_cigarettes: true)
    refute @user1.consumes_greens?
  end

Failure:
EnummerTest#test_update_with_prefix [test/enummer_test.rb:103]:
Expected true to not be truthy.

Generators

Test against various Ruby versions

Not saving

Good gem, but unfortunately not saving attribute value:

  test "setting a setter to true adds the value" do
    @user3.read = true

    assert_equal %i[execute read], @user3.permissions

    @user3.save

    assert_equal %i[execute read], @user3.permissions
  end

Failure:
EnummerTest#test_setting_a_setter_to_true_adds_the_value [test/enummer_test.rb:63]:
Expected: [:execute, :read]
  Actual: [:execute]