sho-87 / rok-talents

Talent builder for Rise of Kingdoms

Hi there, I'm Simon!

🌞 By day, I'm an ML Engineer, working on modelling and deployment infrastructure.
🌚 By night, I make random things for fun.

Some things I enjoy working on/with:

• Sourcing and analysing data
• Data exploration and visualization
• Statistics
• Machine learning

🔗 Links

• 📫 Email: [email protected]
• 📝 Blog: https://www.simonho.ca/blog
• 📄 Resume: https://www.simonho.ca/resume
• 🔷 LinkedIn: https://linkedin.com/in/simon-ho
• 🔶 Stack Overflow: https://stackoverflow.com/users/2605604

✍️ Recent Blog Posts

• Webcam Eye Tracker: Eye Tracking Video Games
• Webcam Eye Tracker: Deep Learning with PyTorch
• Webcam Eye Tracker: Data Collection of Screen Coordinates
• Webcam Eye Tracker: Webcam Features and Face Detection
• Webcam Eye Tracker: An End-to-end Deep Learning Project

🛠 Technologies

Languages

ML / DL

Infrastructure

Databases

rok-talents's Issues

Past announcements

Describe the new feature
Add list of past announcement modals to the Info screen so they can be viewed even if theyre not the latest release

Zoomable tree panel

Add a pan/zoom feature to the tree panel to improve UX on mobile. This will also allow for the inclusion of a parallax background

This is quite difficult due to the finicky way nodes and lines are currently laid out...

Incorrect talent tree for Bertrand

Bertrand should have a conquering talent tree instead of versatility.

jsplumb line repaint speed

Describe the bug
Due to the number of lines drawn, repainting all lines on window resize can be quite slow. Is there a more efficient solution that allows for faster repaint? This is particularly a problem on low powered mobile devices

Expected behavior
Page refreshes, pan/zoom, should not be causing any noticeable lag on any devices

Additional Information:

• App Version: 1.2.2

Cheok Jun Gyeong Talent Build

Cheok Jun Gyeong is an Infantry, Versatility, Attack commander but it shows Infantry, Versatility, Skill instead

Bug with the talents "Defense (All Troops)" and "Attack (All Troops)" in the Gathering tree

In the Gathering tree shared by Cleopatra and Seondeok, the 2 talents "Defense (All Troops)" and "Attack (All Troops)" both need the 2 different talents, both called "Health (All troops)". Only one is considered as necessary by rok-talents, which leads to tree that is impossible ingame

Onboarding

Add an onboarding feature when loading the app for the first time, or first time after a new major/minor release

react-joyride seems like a good option for this: https://github.com/gilbarbara/react-joyride

1. Store semver in browser local storage
2. Compare current and stored semver on launch
3. If new major or minor version, show tour of all/new features

Joan of Arc Prime and Jan Zizka

Joan of Arc Prime and Jan Zizka were just added to Rise of Kingdoms a bit ago for SoC kingdoms. It would be greatly appreciated if you added the two commanders.

Viewer mode

Add a viewer mode that users can embed into websites.

Viewer mode should disable all navigation and interactions, and just allow an embed of the tree panel while retaining zoom/pan functionality

Request: New game and new simulation

I liked rok talents simulation, and another game with "Call of Dragons" please add simulation, this game are style of "Rise of Kingdoms" game.

Video demo about a new talent:
https://www.youtube.com/watch?v=Ocoo7o8zJBw

Thanks!

New commenders

Just add lu bu and diaochan as fast as you can please ..thank you <3

Screenshot settings

Describe the new feature
Add settings for screenshot:

• Include Info panel
• Add custom text/title

Torgny and Wafura

Thank you for your hard work! I would really appreciate Torgny and Wafura being added!

Talent point assignment settings

Describe the new feature
Should introduce a few settings that makes talent point assignment easier/faster:

• Instant max on a single click
• Auto fill prerequisite talents
• Delete all dependent talents when removing points from an early node

This would require a re-implementation of the stats calculation mechanism to be based entirely on state (i.e. recalculate on every point change). Could probably make this more efficient with memoization of unchanged trees/stats

Loading bar

Describe the new feature
Add a loading bar for initial page load and for commander change

make upgrades possible.

Hello,
Could you make it possible to upload the files to make updates, please.
Thank You.

Banner text is blurry

Describe the bug
The embed banner text is blurry on smaller screens due to how svg is rendered. Should probably use html to create the banner text instead of inserting the full svg (just insert the icon svg instead)

Maybe do the same thing for the screenshot banner

To Reproduce
Steps to reproduce the behavior:

1. View an embedded build on a small screen. For example: https://roktalents.com/?embed;1;5;imrsnmbklv;faaaaaaaa;issqpiksa

Add Queen Tamar of Georgia

I was looking through the list of commanders and realized that Queen Tamar of Georgia was missing in the list of epic commanders. This is her talent build:

Where did you get the images from?

Hey Simon,

Great tool! Was wondering where did you get the images from?

Cannot select Amanitore

Hello,

I can't find an option to create a talent tree for commander Amanitore. Will it be added in the near future?

Regards

New features modal

Add a modal listing newly added features

This should compare the old (stored) and current app version to determine whether the modal is displayed

Screenshot functionality

Describe the new feature
Add the ability to take a screenshot of the tree panel

Additional information
https://github.com/niklasvh/html2canvas/ is an option, however, it doesn't support css filters, which is a problem for the display of active/inactive nodes as they use drop-shadow and grayscale

https://github.com/Prindl/html2canvas could work for filter support

Enable pan/zoom for mobile

Describe the new feature
Desktop currently has the ability to pan/zoom the talent tree. This functionality should be enabled for mobile as well, but would first require the optimizations from #26

Add Cheok, Pakal & Ragnar trees.

Describe the new feature
Title says it all

Webpack hot module replacement warning

Describe the bug
Console warning has shown up permanently since react-scripts 3.3.0. Wait for upstream fix in next release of react-scripts to see if issue is fixed

Expected behavior
No warning should appear

To Reproduce
Steps to reproduce the behavior:

1. Open developer console after loading the page

Error Messages

[HMR] Waiting for update signal from WDS...

Additional Information:

• App Version: 1.2.2 (react-scripts 3.3/3.4)

Add more tests

More tests = good

Tree panel not centered

Describe the bug
The tree panel is not vertically centered. Additionally, the padding-bottom value of tree-panel component is causing issues with embedded mode

Expected behavior
The tree panel should be vertically centered on all devices

To Reproduce
Steps to reproduce the behavior:

1. View the talent builder on mobile devices and in embedded mode

Commander images

Need screenshot (zoomed in) of the talent page for Leonidas and Wu Zetian so I can extract the commander icon.

They're currently missing from the commander dropdown as I dont have them summoned

New infantry commanders Tariq and Sargon

Please add their icons if you can, thanks!

Info tabs in about modal

Add tabs to the about modal to show different categories of information

Ideas:

• Version numbers
• Release notes pulled directly from GitHub releases (paginated)
• Usage instructions (w/ button to show onboarding tour #9 )
• Support
• Contact

Create jsplumb line component

Describe the new feature
jsplumb directly modifies the dom when drawing lines. Possible to create a react component for each line/component render instead?

Or find an efficient way to abandon jsplumb altogether. This would make styling through state/props much easier as we are currently directly manipulating the dom...

Additional information
Examples:
https://stackoverflow.com/questions/42380161/using-jsplumb-with-react
https://stackoverflow.com/questions/38836553/how-to-use-jquery-ui-with-react-js

When my Kingdom is less than 310 days old.

commanders of 310 days in ossiris Is it available? When my Kingdom is less than 310 days old.