Total test count and pass count is wrong about colortape

[shuhei]

@adam-lynch colortape just adds colors to the input. Does it happen without colortape?

[adam-lynch]

No :/

[adam-lynch]

Oh wait, this is happening on my Mac too even when the tests pass.

[shuhei]

@adam-lynch Do you mean it works with tape but not with colortape? Do you mind providing a minimum verifiable code example?

[kylegmaxwell]

@shuhei I have the same problem. Tape works, but colortape does not. Here is a minimal example. The first test passes but is reported incorrectly by colortape. The second test fails and is incorrectly reported as a success by colortape.

Create a folder with two files.

1. package.json

{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "test.js",
  "scripts": {
    "test": "tape test.js",
    "color": "colortape test.js"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "colortape": "^0.1.1",
    "tape": "^4.6.3"
  }
}

2. test.js

'use strict';

var test = require('tape');

test('Simple test', function (t) {
    t.ok(true, 'This is true');
    t.end();
});

test('Advanced test', function (t) {
    Promise.resolve(true).then(function () {
        apple.orange;
        t.ok(true, 'This is true');
        t.end();
    }).catch(function (err) {
        t.ok(false, err);
        t.end();
    });
});

Then run 'npm test' to see tape's output and 'npm run color' to see the colortape output.

[kylegmaxwell]

Sample output:

npm test

[email protected] test ~
tape test.js
TAP version 13
Simple test
ok 1 This is true
Advanced test
not ok 2 ReferenceError: apple is not defined
operator: ok
expected: true
actual: false
at: process._tickCallback (internal/process/next_tick.js:103:7)
1..2
tests 2
pass 1
fail 1
npm ERR! Test failed. See above for more details.

npm run color

[email protected] color ~
colortape test.js

TAP version 13
Simple test
ok 1 This is true
Advanced test
not ok 2 ReferenceError: apple is not defined
operator: ok
expected: true
actual: false
at: process._tickCallback (internal/process/next_tick.js:103:7)
TAP version 13

1..0
tests 0
pass 0
ok

[shuhei]

@kylegmaxwell Thanks for your report! Let me format outputs in your comments.

[kylegmaxwell]

yeah, sorry, i noticed it came in as markdown, fixed now. thanks for the prompt notice

[shuhei]

@kylegmaxwell Thanks! I will look at the tests when I arrive home.

[shuhei]

I confirmed that it actually happens with obally installed colortape bin. But somehow it doesn't happen with the repo's bin. I will investigate why.

[shuhei]

Should be fixed in 0.1.2.

[kylegmaxwell]

I don't think I have it installed globally, but it works now, so thanks!

[shuhei]

Ah, yes, it could also happen when you have a different version of tape from colortape's.