`errors.NotFoundError instanceof Error` returns false about node-common-errors

[vjpr]

Related to #16.

Use new errors.NotFoundError instanceof Error or errors.NotFoundError() instanceof Error

[vjpr]

However in http://bluebirdjs.com/docs/api/catch.html#filtered-catch:

somePromise.then(function() {
    return a.b.c.d();
}).catch(TypeError, function(e) {
    //If it is a TypeError, will end up here because
    //it is a type error to reference property of undefined
}).catch(ReferenceError, function(e) {
    //Will end up here if a was never declared at all
}).catch(function(e) {
    //Generic catch-the rest, error wasn't TypeError nor
    //ReferenceError
});

But I can't get this to work with common-errors...

For a parameter to be considered a type of error that you want to filter, you need the constructor to have its .prototype property be instanceof Error.

Would be great if it worked with Bluebird catch out-of-the-box.

[dfenster]

I'm a bit surprised, because the author of bluebird himself helped me with a feature that should allow this to work. https://github.com/shutterstock/node-common-errors/blob/master/lib/internal/globalize.js

I'll for sure look into this.

[dfenster]

I added some tests to reproduce your issue and I could not.

var errors = require('common-errors');
var Promise = require('bluebird');
var caught_error_in_promise = false;
var promise = new Promise(function(res, rej) { res(true); }).then(function(){
  throw new errors.TypeError("test error");
}).catch(TypeError, function(e){
  caught_error_in_promise = true;
}).finally(function(){
  console.log("CAUGHT ERROR?", caught_error_in_promise);
});

If you run this, what do you see?

[vjpr]

For that example I see CAUGHT ERROR? true.

I am using babel with async/await. I'll see if I can write a script to reproduce it.

[jamesdixon]

@dfenster @vjpr were you ever able to get this working? I also cannot seem to do a filtered catch when using bluebird and common errors

[dfenster]

Ca you give me some sample code since I cannot reproduce the issue based on the explanation? I'll gladly look deeper then.

[erduende]

It happens with NodeJS 8.x but not with NodeJS 6.x

[dfenster]

Can you provide more info? This is what I get:

➜ node-common-errors git:(master) ✗ npm test

[email protected] test /mnt/c/Users/DFenestrator/code/node-common-errors
mocha --recursive tests

AlreadyInUseError
✓ should work

ArgumentNullError
✓ should work
✓ should work without new

ArgumentError
✓ should work
✓ should work without new

AuthenticationRequiredError
✓ should work
✓ should work without new

ConnectionError
✓ should work
✓ should work without new

DataError
✓ should work
✓ should work without new

MemcachedError
✓ should work
✓ should work without new

MongoDBError
✓ should work
✓ should work without new

RedisError
✓ should work
✓ should work without new

RollbackError
✓ should work
✓ should work without new

SQLError
✓ should work
✓ should work without new

TransactionError
✓ should work
✓ should work without new

Error
✓ should work
✓ should work without new

classGenerator
✓ should work
✓ should be safe to use a name - strings only
✓ should be safe to use a name - word characters only
✓ should be safe to use custom arguments - array only
✓ should be safe to use custom arguments - array of strings only
✓ should be safe to use custom arguments - array of strings only
✓ should globalize errors

prependCurrentStack
✓ should work

global namespace
✓ should maintain a global namespace for instanceof

HttpStatusError
✓ should work with status code and message
✓ should work with status code
✓ should work with status code and message without new
✓ should work with status code without new

InvalidOperationError
✓ should work
✓ should work without new

DirectoryNotFoundError
✓ should work
✓ should work without new

DriveNotFoundError
✓ should work
✓ should work without new

EndOfStreamError
✓ should work
✓ should work without new

FileLoadError
✓ should work
✓ should work without new

FileNotFoundError
✓ should work
✓ should work without new

IOError
✓ should work
✓ should work without new

SocketError
✓ should work
✓ should work without new

errors.log
✓ should log a message
✓ log string error
✓ log error, no message
✓ log generic error

errorHandler
✓ should handle NotPermittedError
✓ should handle AuthenticationRequired
✓ should handle Validation
✓ should handle AlreadyInUse
✓ should handle ArgumentNull
✓ should handle ArgumentNull route param
✓ should handle ArgumentNull route param in express3
✓ should handle ArgumentNull POST
✓ should handle NotFoundError
✓ should handle Error
✓ should handle Error status
✓ should handle Error status
✓ should handle Error status
✓ should handle HttpStatusError (deprecated)
✓ should handle HttpStatusError
✓ should handle HttpStatusError 400
✓ should work with express 3

NotFoundError
✓ should work
✓ should work without new

NotImplementedError
✓ should work
✓ should work without new

NotPermittedError
✓ should work
✓ should work without new

NotSupportedError
✓ should work
✓ should work without new

OutOfMemoryError
✓ should work
✓ should work without new

RangeError
✓ should work
✓ should work without new

ReferenceError
✓ should work
✓ should work without new

StackOverflowError
✓ should work
✓ should work without new

SyntaxError
✓ should work
✓ should work without new

TimeoutError
✓ should work for durations
✓ should work

TypeError
✓ should work
✓ should work without new

URIError
✓ should work
✓ should work without new

ValidationError
✓ should work
nested errors
✓ should addError
✓ should addErrors
✓ should require an Array for addErrors

103 passing (309ms)

➜ node-common-errors git:(master) ✗ node -v
v8.12.0