sideprotocol / ibcswap Goto Github PK

Similar to ICA, write a interchain tx demo, Sending an ibc packet from chain A, which wraps a transaction（sending token） to be executed on chain B

a tx structure will similar to this:

{
     sender: "Achain1xxxxxxxxx",
     source_channel: "channel-2",
     source_port: 'ibc-execute",
     tx_to_executed_on_dest: {
           sender: "Bchain1xxxxxxxxx",
           messages: [{ ... }],
           signature: "",
      }
}

steps:

1. construct a tx on chain A
2. sending to from chain A
3. relayer tx
4. received tx on Chain B, unwrap the sub tx, validating the sub tx, and execute the subtx.
5. return execution result to ack
6. acknowledged on chain A

Credit to : HelloBloc

@liangping

Description

In the following code content, the error handling of x.bankKeeper.SendCoins is missing, which will result in a malicious user being able to set the status without cost.

	//lock swap-in token to the swap module
	escrowAddr := types.GetEscrowAddress(pool.EncounterPartyPort, pool.EncounterPartyChannel)
	k.bankKeeper.SendCoinsFromAccountToModule(ctx, sdk.MustAccAddressFromBech32(msg.Sender), escrowAddr.String(), sdk.NewCoins(*msg.TokenIn))

	//constructs the IBC data packet
	rawMsgData, err := json.Marshal(msg)
	if err != nil {
		return nil, err
	}

Impact

This results in users being able to successfully swap without having a sufficient balance.

Likelihood

This attack can be done by any user who does not have sufficient balance.

Related links

Related-Code

REF

REF

Ethics

Sorry for using github to report this vul, as I didn't find your security channle and all the effective ways to report it at that time. However, I have observed that your main-net was not online at that time, so reported the issue via github. Hope you don't mind.

We have to input timeout parameters sometime.

raw_log: 'failed to execute message; message index: 0: receiving chain block height
  >= packet timeout height (2-825 >= 1-71613): packet timeout'

we need add --packet-timeout-height string and --packet-timeout-timestamp uint

Cancel Pool Create and Add Liquidity On GO

• Front-end Integration
  • Cancel the creation of a fund pool Front-end page UI
  • Cancel the creation of a fund pool Logic
  • Cancel multilateral pledge Front page UI
  • Cancel multilateral pledge Front Logic
• Backend
• Deploy Relayer

We need to implement a demo, following the spec
https://github.com/liangping/ibc/tree/interchain-swap/spec/app/ics-101-interchain-swap

Tasks:

• Create .proto file according the definitions in ics-101-interchain-swap.
• Generate go files from proto using buf
• Implement IBC Interchain Swap module and unit tests
• Using ibctest for module functional tests
• Integrate Interchain Swap module to Simapp
• make a docker image for ibctest e2e test and upload to github.
• done e2e test.

Here is main task to do that. we can create separate issue for each of these tasks.

Intro

In the following code content, the error handling of x.bankKeeper.SendCoins is missing, which will result in a malicious user being able to set the status without cost.

REF:
#8

Parent issue: #1

Create .proto file according to the definitions in ics-100-atomic-swap.

We need to implement a demo, following the spec
https://github.com/liangping/ibc/tree/atomic-swap/spec/app/ics-100-atomic-swap

Tasks:

• Create .proto file according the definitions in ics-100-atomic-swap.
• Generate go files from proto using buf
• Implement IBC Atomic Swap module and unit tests
• Using ibctest for module functional tests
• Integrate Atomic module to Simapp
• make a docker image for ibctest e2e test and upload to github.
• done e2e test.

Here is main task to do that. we can create separate issue for each of these tasks.

Things to be done:

• 1. Setup relayer.
• 2. add ICS restful api to Swagger UI.
• 3. Reset Blockscout.
• 4. Use CI/CD to deploy testnet

1. Write unit tests for each module. make sure that ibc_module_test and <module_name>_test tests pass.
2. integrate module to simapp in ./testing
3. Make sure simapp works with simulator: https://github.com/ibcswap/ibcswap/blob/edb10cdd710c0aed2384097ce89fb8cf1a4cf85b/testing/simapp/sim_test.go#L61
4. run e2e test