sifton / isocountry-rs Goto Github PK

This test:

    fn foo() {
        let raw = "USA";
        let cc = CountryCode::for_alpha3_caseless(raw).unwrap();
        assert_eq!(CountryCode::USA, cc);
    }

fails:

failures:

---- country_code::test::foo stdout ----
	thread 'country_code::test::foo' panicked at 'assertion failed: `(left == right)`
  left: `USA`,
 right: `AFG`', src/country_code.rs:48:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Running the same test with alpha2 and US works as expected:

    #[test]
    fn foo2() {
        let raw = "US";
        let cc = CountryCode::for_alpha2_caseless(raw).unwrap();
        assert_eq!(CountryCode::USA, cc);
    }

Hello!

Since the enum variants use alpha-3, I think it might make sense to use them in the ser/de implementation (by default), but failing that, at least have a feature to switch to alpha-3 for ser/de impls. What do you think?

I would be happy to submit a PR for it if you think it would be a good idea.

Currently the error message for an incorrect country says expected expecting an ISO 3166-1 ... because the expecting function's message begins with expecting instead of just the thing it was expecting.