GithubHelp home page GithubHelp logo

Comments (4)

jfschwarz avatar jfschwarz commented on July 2, 2024

I would actually vote for using a less opinionated eslint config that we do not have to extend and maintain on our own. For example, we could switch to the react-app one from create-react-app.

from eslint-config-signavio.

AnimiVulpis avatar AnimiVulpis commented on July 2, 2024

@jfschwarz have you tried out if the current ESLint config and the one from create-react-app differ in some big ways? (Or have you tried @monapasan ?)

from eslint-config-signavio.

jfschwarz avatar jfschwarz commented on July 2, 2024

The configs differ big time, which is the point for switching: create-react-app does not include too opinionated rules, which we might want to override.

The goal of the airbnb ruleset is a consistent code style, which is something that requires a lot of effort to maintain. Looking at the benefits we get from syntax consistency and comparing it with the burdens of migrating legacy code plus maintaining the ruleset, I'm not convinced it's worth it. This entire project (eslint-config-signavio) is treated as an orphan, which is why I would like to deprecate it.

There is no point in centralizing the eslint config across our different products in different repositories. The communication overhead is substantially greater. Autonomy of delivery teams should definitely include the ability to change linting rules without discussing with other teams.

from eslint-config-signavio.

AnimiVulpis avatar AnimiVulpis commented on July 2, 2024

What I meant was:
Are there rules that contradict rules of "create-react-app"

As for the rest of your comment 👍

There was never real effort made to adhere to the style we choose.

from eslint-config-signavio.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.