signavio / eslint-config-signavio

eslint-config-signavio

This package provides the agreed-upon set of JavaScript linting rules for all JavaScript projects at Signavio. The rule set is based upon the linting rules employed at airbnb.

Installation

First install this package as a devDependency in your project.

npm install --save-dev eslint-config-signavio

or

yarn add -D eslint-config-signavio

After that create a .eslintrc.js file and add the following:

{
  "extends": "signavio"
}

Contributing

We encourage everybody to start discussions and file PRs with changes to this rule set. However please always make a good point, why you want to introduce a change. Simply "not liking" something doesn't count.

Changelog

See CHANGELOG.md

eslint-config-signavio's Issues

Use MIT license in the correct way

In the currently existing LICENCE file the copyright holder(s) are missing.

See: http://choosealicense.com/licenses/mit/

Lack of BindExpression support in jsx-ast-utils breaking linter

that should be fixed in a newer version of eslint-plugin-jsx-a11y ( > 6 )

react/sort-comp not working well with flow

with the current setup state should be declared above componentWillMount but props must be after render

Move `eslint` and `babel-eslint` to `peerDependencies`

Those two should be provided by the main package and should not be brought in by the config itself.

Update eslint-config-airbnb

After upgrading eslint package we have following error:

(node:13878) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "node_modules/eslint-config-airbnb-base/index.js")

This is caused by outdated eslint-config-airbnb package.