Comments (5)
It seems to be allowed for deflate/zlib, but not for zip:
https://github.com/zlib-ng/zlib-ng/blob/a9f5d668f692f894e89256ec3696c55c131510ed/trees.c#L565
It's a bit of an edge case. In zlib, miniz, miniz_oxide and deflate-rs there being zero distance codes would result in a outputting a stored or static block, unless the compressor is explicitly set to only do huffman and no length matching, as one of those would take up less space. Zlib seems to have some code for this edge-case though.
from libflate.
@mvdnes @oyvindln Thank you for reporting this problem and giving me helpful information for solving it.
I created a PR (#24) for fixing this problem.
This branch seems to work well in my environment (Windows 10). But I would very appreciate it if you could test this branch. > @mvdnes
from libflate.
Thank you for this fix!
My tests indicate that the zips now work on Windows, so I would be very happy if this could be included.
from libflate.
@mvdnes Thank you very much! I merged the PR and published v0.1.21 to crates.io.
from libflate.
Thank you for the quick response!
from libflate.
Related Issues (20)
- Decoder::read_non_compressed_block() is unsound HOT 4
- Decoder may expose contents of uninitialized memory in the output HOT 5
- Use-after-free on panic in client code HOT 4
- Remove byteorder-dependency HOT 1
- Possible concurrency issue during deflate on libflate 0.1.25 HOT 8
- Convenience functions? HOT 1
- btype 0x11 of DEFLATE is reserved(error) value HOT 1
- LZ77 compressor as a separate crate? HOT 3
- libflate 1.0.0 is on crates.io, but not here HOT 1
- Encoder panic on specific input data... HOT 1
- Compression level HOT 5
- UnexpectedEof encountered when decompressing data HOT 4
- Streaming data extensions HOT 4
- LZ77 decoder? HOT 2
- libflate::gzip::Decoder::read does not handle zero-length buffer properly HOT 2
- UB in the public safe API - where to report? HOT 4
- Panic in `bug` when parsing malformed file HOT 4
- GzDecoder seem decode incorrect HOT 9
- Error while decoding just encoded data HOT 2
- zLib decoding fails with failed to fill whole buffer HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libflate.