GithubHelp home page GithubHelp logo

Comments (5)

oyvindln avatar oyvindln commented on June 19, 2024

It seems to be allowed for deflate/zlib, but not for zip:
https://github.com/zlib-ng/zlib-ng/blob/a9f5d668f692f894e89256ec3696c55c131510ed/trees.c#L565

It's a bit of an edge case. In zlib, miniz, miniz_oxide and deflate-rs there being zero distance codes would result in a outputting a stored or static block, unless the compressor is explicitly set to only do huffman and no length matching, as one of those would take up less space. Zlib seems to have some code for this edge-case though.

from libflate.

sile avatar sile commented on June 19, 2024

@mvdnes @oyvindln Thank you for reporting this problem and giving me helpful information for solving it.

I created a PR (#24) for fixing this problem.
This branch seems to work well in my environment (Windows 10). But I would very appreciate it if you could test this branch. > @mvdnes

from libflate.

mvdnes avatar mvdnes commented on June 19, 2024

Thank you for this fix!
My tests indicate that the zips now work on Windows, so I would be very happy if this could be included.

from libflate.

sile avatar sile commented on June 19, 2024

@mvdnes Thank you very much! I merged the PR and published v0.1.21 to crates.io.

from libflate.

mvdnes avatar mvdnes commented on June 19, 2024

Thank you for the quick response!

from libflate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.