simogeo / filemanager Goto Github PK

Issues with jQuery 1.4 is down to using jquery.splitter. This can simply be replaced with the newer jquery.layout

Change line 662 to:

// Provides support for adjustible columns.
$('#splitter').layout({
useStateCookie: true, // enable cookie-based state-management
west__size: 200
});


and add classes in the html to:

div id="filetree" class="ui-layout-west" and
div id="fileinfo" class="ui-layout-center"

Also
jQuery.form must be updated to latest version

I'm currently playing with Filemanager and I'm rather pleased until now. Here is a patch for TinyMCE integration.

I have the ckeditor with filemanager in subfolder while the cms is are in another subfolder.
If i select the img by file manager the path of img was "/example.png" while the path of the site are "http://example.xx/example".
i have modded the line 189 of filemanager.js with this window.opener.CKEDITOR.tools.callFunction($.urlParam('CKEditorFuncNum'), data['Path'].substr(1));
that remove the slash.
Domain http://example.xx/example
Img is http://example.xx/example/example.png
Img is after select http://example.xx/example.png
If the site are in a subfolder i have the problem.

It is probably related to the work I've done for moving jqueryFileTree data retrieving in filemanager.js, but now my button labels do not initialize.

I saw that you moved the label initialization out of the main initialization function in commit d41db0f. But I don't understand why. Moreover, the autoload variable is nowhere explained. Why would we want to set it to false?

can this be changed that only the foldercontent get updated and doesn't disappear?
iam using the PHP connector..

Hi.

The Filemanager interface has some problems when the text has, for example, spanish characters like 'ñ' or accented vowels (á,é,í,ó,ú).

I'm having these problems:

• The language strings in the es.js file are shown with encoding erors in interface. For example, the authentication failed text is shown: "No estás autorizado para usar el administrador de archivos.", but would be "No estás autorizado para usar el administrador de archivos.
• When I try to create a new folder with special chars, like "España", the folder is created in the server with the name "España", and the interface shows it with the same wrong format.
• If I have a folder in the server with a special chars name (España again), it is shown well formatted in the main frame, but with encoding errors in the FileTree (Espa�a)
• If I click on the folder in the main frame (the well formed one), I get the "Folder not found error"). I attach a screenshot of the error with the Firebug log

• If I click on the FileTree folder, I get the sale "Folder not found error" but in the case, as the filetree shows the folder with encoding problems, the request and response of the server is quite differente. A scrrenshot...

As you can see, the request to the jqueryFileTree.jsp file returns a 500 server error. Here is the server exception:

java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "uF" at java.net.URLDecoder.decode(Unknown Source) at org.apache.jsp.ckeditor.filemanager.scripts.jquery_filetree.connectors.jqueryFileTree_jsp._jspService(jqueryFileTree_jsp.java:104) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454) at java.lang.Thread.run(Unknown Source)

I'm trying to solve the problems but I'm having no success.

I realized that the Filemanager interface uses UTF-8 as charset, but the files are saved in ANSI format, that can generate problems (If you save a file (HTML for example) with special chars in ANSI, and later you open it in UTF-8, the special chars will be rendered with errors).

My system is a Windows XP OS with Apache Tomcat 6.0.20

I hope you can solve these problems. I'll continue with my test in order to find a solution.

Regards.

PD: I apologize if my explanations aren't so good, I haven't a high english level.

copy/paste from : http://forum.filemanager.corefive.com/topic/ie-bug-in-filemanager#18308000000182001

Hi,
I found a bug in the recent filemanager:
The problem appears in Internet Explorer (as usual)...
After uploading a new file to your userfiles the file isn't displayed in the context menu. Only the filetree shows the new file.
Would be nice if somebody can fix it!

to retrieve file with special characters (at least on windows) it is necessary to use encodeURIComponent() when passing the querystring parameters of paths in filemanager.js.

I modified mine and now work pretty well with asp.net connector.

The JSP connector of the FileTree doesn't work fine with file names or folder names that include exotic chars.

If I have a folder in the server with a special chars name (España), it is shown well formatted in the main frame, but with encoding errors in the FileTree (Espa�a)

This interrogation symbols means that the text is in ISO encoding but rendering in UTF-8 (you can try it creating a plain text file with the text "España", save it in ISO-ANSI and open it in the browser with UTF-8 character set).

Changing the encoding of the file to UTF-8, and doing the URLDecoder in ISO-8859-1, all works fine (I don't understand why it is necessary to use ISO in the decoder instead of UTF-8 :?)

dir = URLDecoder.decode(dir, "ISO-8859-1");

And should not refer to the SVN at codefive.com/

http://forum.filemanager.corefive.com/topic/using-the-filemanager-with-a-regular-textbox

Language string error on INVALID_FILE_UPLOAD

.....
"INVALID_FILE_UPLOAD": "Invalid file upload.",
.....

Hello.

Now, the preview option for images is case sensitive, if I upload a file named "hello.PNG", the filemanager doesn't show the preview of the image because of the "images" array in the configuration file has lowercase file extensions.

It can be solved with a "strtolower" in the PHP connector, and "equalsIgnoreCase" in the JSP connector.

Regards.

browseonly option should implement capabilities mechanism

http://dev.mennerich.name/showroom/html5_video/
https://github.com/maccman/flarevideo

can you add a showFullPath option to the config, so that the full path name is shown in the uploader h1 instead of the shortend version, where it removes the fileRoot path from the path?

just add an if before line 72 in the filemanager.js
$('#uploader h1').text(lg.current_folder + path); //disp(path)
and remove the disp() function..

Hi Simogeo,

there is a security issue in fileManager that I would like to discuss; currently we have a "filemanager.config.js" which sets up the variables. As a malicious user, I can change the fileRoot variable to something else; for example, on a .NET site, if I change it to /, it displays the root folder and all the contents.

As I see, those config should really come from the connector, as it shouldn't be a concern of the fileManager; Currently I have solved this issue on my by using something like this:

so I am basically passing the configuration from connector as a JS file which requires no other changes; As an idea, perhaps it should be read as a JSON object to fit with the rest.

Perhaps everyone has already adapted similar ideas; but someone new may benefit from this information.

Clarification: By the way, the connector is checking to see if the path is allowed or not. in above specific method, that value is served from one page, instead of two.

does the fileManager itself needs fileRoot or can it be passed on the responses??

Using the JSP connector, some messages with exotic chars are rendered with encoding problem, for example the AUTHORIZATION_REQUIRED spanish message:

Message text:

No estás autorizado para usar el administrador de archivos.

Shown text:

No estás autorizado para usar el administrador de archivos.

The á character means that a UTF-8 encoded text is rendered as ISO/ANSI.

As a workaround, I can solve the problem saving the es.js file in ISO/ANSI format.

I use the jsp connector.

I'm testing the authentication method in filemanager.jsp.

If the authentication fails, the connector have to send the browser and error, and the filemanger interfaz should display this error to inform the user.

The connector returns the error, but the interface doesn't show it to the user.

Here is the server response when the autenthication fails:
{"Code":"-1","Error":"No estás autorizado para usar el administrador de archivos.","Properties":{"Date Created":null,"Date Modified":null,"Height":null,"Width":null,"Size":null}}

Hello.

The JSP connector of the FileTree doesn't have authentication control, unlike the PHP connector which use the same authentication function in the file tree and the main connector.

I'm working on an ASP.Net connector and ran into an issue when attempting to reproduce the example/expected JSON string given in the ReadMe.txt file. The example response doesn't pass the JSON lint located at: http://www.jsonlint.com. I've taken a look at the JavaScript code and the key isn't being used specifically in the list (from what I could tell at this hour). They key being the absolute path to the file tends to be redundant to me as well. I have created code that omits that key but still returns a valid JSON array of objects which appears to be working at this time.

I would like to propose that new example code would be:

[
    {
        "Path": "/UserFiles/Image/logo.png",
        "Filename": "logo.png",
        "File Type": "png",
        "Preview": "/UserFiles/Image/logo.png",
        "Properties": {
            "Date Created": null,
            "Date Modified": "02/09/2007 14:01:06",
            "Height": 14,
            "Width": 14,
            "Size": 384 
        },
        "Error": "",
        "Code": 0 
    },
    {
        "Path": "/UserFiles/Image/icon.png",
        "Filename": "icon.png",
        "File Type": "png",
        "Preview": "/UserFiles/Image/icon.png",
        "Properties": {
            "Date Created": null,
            "Date Modified": "02/09/2007 14:01:06",
            "Height": 14,
            "Width": 14,
            "Size": 384 
        },
        "Error": "",
        "Code": 0 
    }
]

Does this work? I'm in early in my development of this connector at this point. I will "genericize" the code and pass it on to you guys for the community.

Regards,

-- Mikhey

that's all!

on contextmenu option (filetree) and main window (fileInfo)

I'm getting an error when try to upload a file into a folder that has exotic chars in its name (España for example).

The POST request to the server returns this text:

<textarea>{}</textarea>

and the interface shows a "undefined" message.

The addfolder method works fine, you can create a folder inside another with exotic chars.

up to now I can't found a solution or workaround, but I'm working on it

The JSON example for getfolder is not valid JSON. I will try to propose a patch.

when i doesnt use the doc path from the fielmanager.config.js, but instead set the poath in the filemanager.config.php, then he doesnt show the fullpath, even if showFullPath = true;

Not so critical, but unit names (var u = [' bytes','kb','mb','gb'];) should be translatable.

Maybe this isn't a huge issue, but it seems files can be renamed to any extension after uploading. If someone got a malicious php file uploaded as a .jpg for example, they could rename it in the file manager afterwards.

hi,

a hacker contacted me, because he found a few exploits in my cms "feindura".

one was because of the filemanager, so i thinks its interesting for you, hope you can restrict the path somehow..

he wrote:

The filemanager script does not apply base path restrictions on the path,
this allows for arbitrary file reads.
http://[host]/[path]/filemanager/connectors/php/filemanager.php?mode=download&path=[path/to/file]

i dont understand why the select button is shown when the filemanger is used as standalone fm?

i add:
// blend out if filemanager was not load in a CKEditor instance
if(window.opener)

in line 456 of the filmanager.js to prevent this

can you implement this by default, cause it makes no sense to show a button without function, or is it also for something else?

Hi there, thanks a lot for this great fileManager; I have a question though; is there any way to disable upload feature? perhaps by setting the configuration file?

Also, are you accepting any aspx connector?

I have updated filemanager on my cms (Flatz-Cms).
When i choose a folder on the right i have only the folder the file not.
I have read the code of many files and i have use firebug.
The problem is that i go with my browser of the url get by firebug i get this for example:
{"/uploads/galleria/2/min/":{"Path":"/uploads/galleria/2/min/","Filename":"min","File Type":"dir","Preview":"images/fileicons/_Open.png","Properties":{"Date Created":null,"Date Modified":null,"Height":null,"Width":null,"Size":null},"Error":"","Code":0},"/uploads/galleria/2/2010-02-19_154856.jpg":{"Path":"/uploads/galleria/2/2010-02-19_154856.jpg","Filename":"2010-02-19_154856.jpg","File Type":"jpg","Preview":"connectors/php/filemanager.php?mode=preview&path=/uploads/galleria/2/2010-02-19_154856.jpg","Properties":{"Date Created":null,"Date Modified":"27 Aug 2010 18:19","Height":351,"Width":530,"Size":202345},"Error":"","Code":0},"/uploads/galleria/2/idg/":{"Path":"/uploads/galleria/2/idg/","Filename":"idg","File Type":"dir","Preview":"images/fileicons/_Open.png","Properties":{"Date Created":null,"Date Modified":null,"Height":null,"Width":null,"Size":null},"Error":"","Code":0},"/uploads/galleria/2/2.jpeg":{"Path":"/uploads/galleria/2/2.jpeg","Filename":"2.jpeg","File Type":"jpeg","Preview":"connectors/php/filemanager.php?mode=preview&path=/uploads/galleria/2/2.jpeg","Properties":{"Date Created":null,"Date Modified":"27 Aug 2010 18:20","Height":1024,"Width":1280,"Size":986444},"Error":"","Code":0}}
while the html that i read on firebug are:
{"/uploads/galleria/2/min/":{"Path":"/uploads/galleria/2/min/","Filename":"min","File Type":"dir","Preview":"images/fileicons/_Open.png","Properties":{"Date Created":null,"Date Modified":null,"Height":null,"Width":null,"Size":null},"Error":"","Code":0},"/uploads/galleria/2/idg/":{"Path":"/uploads/galleria/2/idg/","Filename":"idg","File Type":"dir","Preview":"images/fileicons/_Open.png","Properties":{"Date Created":null,"Date Modified":null,"Height":null,"Width":null,"Size":null},"Error":"","Code":0}}
At same url!
i have no idea. i have updated only the file not the config that i use on the cms.

if the path is too long the buttons disapear.
there have to be some kind of automatic fitting of the height.

i therefor i separated the path and the buttons in two lines, and made everything left align, it looks better and gives a better overview.

do you want to implement it as default?
you can take a look at: http://demo.feindura.org

would be cool if you could include fancy upload to upload the files https://github.com/digitarald/digitarald-fancyupload

it is clear enough. I just create the ticket before claudep! :p

One question though - what type of security concerns should I be worried about? As far as I can tell, just like the file upload utility in FCKeditor, there's nothing really stopping anyone from using Filemanager, just by visiting it and using the interface bare. That allows anyone to upload, it seems anything. And unlike the built-in file uploader in FCKeditor, there doesn't seem to be a way to state what file types are OK to upload and what file types aren't. I couldn't find any documentation that deals with this type of stuff - is there documentation for this wonderful project - other than the Readme?

http://forum.filemanager.corefive.com/topic/security-concerns#18308000000230010

In the README, the addfolder method is mistakenly spelled addFolder.

Hi.

Using the jsp connector and IE 8, when you upload a file, it is renamed in the server with the fullpath of the local filesystem.

For example, if I upload a file located on my desktop folder, the uploaded file name will be "CDocumentsandSettingsmyUsernameDesktopFilename"

I've tested it with other browsers and connectors and works fine.
JSP connector:

• Firefox: OK
• Chrome: OK
• IE 8: Error

PHP connector:

• Firefox: OK
• Chrome: OK
• IE 8: OK

see http://phpimageeditor.se/

If you have two files with different names, and then rename one of the files so the two names became the same, one of the files will be overwritten.

No Swedish (sv) translation exists. I did a quick translation from 'en', and included it here:

{
"AUTHORIZATION_REQUIRED": "Du är inte behörig att använda filemanager.",
"INVALID_ACTION": "Felaktig åtgärd.",
"MODE_ERROR": "Mode error.",
"DIRECTORY_ALREADY_EXISTS": "Mappen '%s' finns redan.",
"FILE_ALREADY_EXISTS": "Filen '%s' finns redan.",
"UNABLE_TO_CREATE_DIRECTORY": "Kan ej skapa mapp %s.",
"INVALID_VAR": "Felaktig variabel %s.",
"DIRECTORY_NOT_EXIST": "Mappen %s finns inte.",
"UNABLE_TO_OPEN_DIRECTORY": "Kan ej öppna mappen %s.",
"ERROR_RENAMING_DIRECTORY": "Kan ej byta namn på mappen %s till %s.",
"ERROR_RENAMING_FILE": "Kan ej byta namn på filen %s till %s.",
"INVALID_DIRECTORY_OR_FILE": "Felaktig mapp eller fil.",
"INVALID_FILE_UPLOAD": "Fel vid uppladdning av fil.",
"UPLOAD_FILES_SMALLER_THAN": "Var vänlig ladda upp filer mindre än %s.",
"UPLOAD_IMAGES_ONLY": "Du kan endast ladda upp bilder, inga andra filtyper stöds.",
"UPLOAD_IMAGES_TYPE_JPEG_GIF_PNG": "Du kan endast ladda upp bilder av typen JPEG, GIF eller PNG.",
"FILE_DOES_NOT_EXIST": "Filen %s finns inte.",
"LANGUAGE_FILE_NOT_FOUND": "Språkfil saknas.",
"default_foldername": "Min mapp",
"prompt_foldername": "Ange namnet på den nya mappen",
"no_foldername": "Inget mappnamn angivet.",
"create_folder": "Skapa mapp",
"cancel": "Avbryt",
"select_from_left": "Välj från vänster.",
"fck_select_integration": "'Select-funktionen' används bara av integrationen med FCKEditor.",
"new_filename": "Ange nytt namn på filen",
"successful_rename": "Namnbyte utfört.",
"rename": "Byt namn",
"confirmation_delete": "Är du säker på att du vill radera filen?",
"successful_delete": "Radering utförd.",
"successful_added_file": "En ny fil har lagts till.",
"successful_added_folder": "En ny mapp skapades.",
"select": "Välj",
"download": "Ladda ner",
"del": "Radera",
"parentfolder": "Upp en nivå",
"dimensions": "Dimension",
"created": "Skapad",
"modified": "Senast ändrad",
"size": "Storlek",
"name": "Namn",
"gotoroot": "Gå till /",
"could_not_retrieve_folder": "Kan ej läsa mappens innehåll.",
"yes": "Ja",
"no": "Nej",
"upload": "Ladda upp",
"new_folder": "Ny mapp",
"grid_view": "Byt till tabellvy.",
"list_view": "Byt till listvy.",
"current_folder": "Aktuell mapp: ",
"bytes": " bytes",
"kb": "kb",
"mb": "mb",
"gb": "gb"
}

Hi, I'm having a problem, I can't upload images, any time I try, the same message appears:

{"Error":"Invalid file upload.","Code":"-1","Properties":{"Date Created":null,"Date Modified":null,"Height":null,"Width":null,"Size":null}}

Does anyone know a fix for this? Thanks

If the root folder is empty and you create new folder that folder is not shown in the folder tree.

If the root folder is not empty and you add new folder under the root, that new folder is shown in the folder tree but it can't be selected and its context menu can't be shown.

The example of a download request in the ReadMe file ii:
[path to connector]?mode=download&path=/UserFiles/&name=new%20logo.png

In fact, it should be:
[path to connector]?mode=download&path=/UserFiles/new%20logo.png

Or else it is a coding error...

Is limiting Filemanager to an image-only browser completely implemented? I see some references to a type=image query parameter, but it doesn't seem to be carried on on various AJAX calls. Can you tell us more about this?

Ckeditor when open the window of filemanager in get this write &CKEditorFuncNum=1&langCode=it.
Filemannager not use the value of langcode to use it automatically?

see http://forum.filemanager.corefive.com/topic/missing-language-file

If you have only one folder, e.g. /my-folder/ and when you delete that folder current path is still /my-folder/ but it should be /