simonberner / githubfollowme

An iOS16+ App to get and show followers from GitHub :octocat:

Hi there 👋

• 🏢 I'm a Software Development Engineer in Test (SDET)
• 📱 I'm an iOS Developer
• ᠋🧑‍🤝‍🧑 I coach people on Software Pairing and Teaming
• 1️⃣ I teach how you and your team can use the version control system Git
• 🍏 I like to build iOS Mobile Apps with Swift, SwiftUI
• 🌱 I work day by day on personal projects to improve my development skills
• 📚 Technologies that I study: Python, JavaScript/TypeScript, Swift, Design Patterns, Architecture, Algorithms...
• 🎤 From time to time I speak at (un)conferences and meetups
• 🥋 I love doing code katas

Thanks for stopping by and having a look at my work here! 😄

I am using !

githubfollowme's Issues

Adopt Swift 5.7 Concurrency

https://www.donnywals.com/enabling-concurrency-warnings-in-xcode-14/?utm_campaign=iOS%2BDev%2BWeekly&utm_medium=email&utm_source=iOS%2BDev%2BWeekly%2BIssue%2B576

FollowersView: add Alert for offline

Add AsyncImage Caching

https://www.avanderlee.com/swiftui/downloading-caching-images/

Followers/FavoritesView: explore solution for better image loading and caching

• Try Nuke for Image Loading instead of AsyncImage

Feature: add a Roadmap

https://github.com/AvdLee/Roadmap

FavoritesView: basics

• Add a PersistenceManager (UserDefaults)
• Simple List of favorites
• Alerting
• Delete a favorite with a swipe left

Where is xcodeproj ?

How to run this project ? I cannot find .xcodeproj

SearchView: 'jk0' is an invalid username

• Examples of users with a numeric value at the end of their username: jk0, Jue92 -> is this allowed with the newest GitHub profile creation validation?
• Check regex for usernameInput validation

Check iOS16 compatibility

iOS Development Target: 16.0

Invalid username alert is shown for: CalumJEadie, Jue92

Testing: add UI-Tests

[iOS17] ContentUnavailableView

https://www.avanderlee.com/swiftui/contentunavailableview-handling-empty-states/

#if iOS17 ContentUnavailableView()

GFMInfoView: open GitHub Profile in a embedded WebView (UIKit)

• WebView ✅
• .sheet for the WebView ✅

Custom Dark Mode

Inspiration: https://twitter.com/britcodes/status/1662892636502626304

FollowersView: 'Search for a username' should not be hidden right at its first appearance

FavoritesView: deletion of a favorite does not work

Issues

• Deletion via swipeLeft() & tap() on 'Delete' button does not work ❌ -> GFMEmtpyFollowerView appears instead
• Deletion via 'Edit' the whole favorites list does not work ❌ -> GFMEmtpyFollowerView appears instead

Works

• Deletion via full swipeLeft does work ✅

Resources

• Deleting items using onDelete()

FollowersView: username does not change in the nav bar when getting the followers of another user (GFMInfoView)

[POC] Network abstraction layer with Moya

https://github.com/Moya/Moya

FollowersView: show username in the navigation bar

SearchView: add a 'clear' button to the search field

WebViewPB: track loading of web content and show a progress bar while loading

• ProgressView while loading the web content of the page: https://www.hackingwithswift.com/example-code/wkwebview/how-to-monitor-wkwebview-page-load-progress-using-key-value-observing
• https://medium.com/macoclock/how-to-use-webkit-webview-in-swiftui-4b944d04190a

Logging with Pulse/OSLog

• Add Pulse for proper logging/debugging
• Logging with OSLog

SearchView - NavigationView: rename 'Back' to 'Search'

[FEATURE] Roadmap: implement this feature as a FeatureFlag

Enable/Disable the Roadmap feature as a FeatureFlag at runtime!

https://www.youtube.com/watch?v=eHo_XX7teHU&list=PLdXMqVQnoFlfaQ2xiefWwIPeIhFDxMi6u&index=11

FollowersView: searching for a username that does not exists ends with the GFMEmtpyFollowerView

2022-07-26 15:32:49.627333+0200 GitHubFollowMe[29810:383699] [Assert] Someone is removing an active search controller while its search bar is visible. The UI probably looks terrible. Search controller being removed: <SwiftUI.SwiftUISearchController: 0x7fa0fa832800> from navigation item: <UINavigationItem: 0x7fa0fc4439e0>

FavoritesView: followers not flushed when tap on a new favorite

Localize the App (fr, es)

https://developer.apple.com/localization/#localize

https://developer.apple.com/wwdc21/10220

NetworkManager: optimize network reachability

https://www.avanderlee.com/swift/optimizing-network-reachability/#responding-to-networking-errors\

Add hot reloading with Inject

https://github.com/krzysztofzablocki/Inject

FollowersView: reset the username search ends with the GFMEmtpyFollowerView

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Hosted search should take a different code path'
terminating with uncaught exception of type NSException

GFMInfoView: use a UIKit SFSafariViewController for the WebView

FollowersView: ClearButton for the username TextField

Add a TextFieldClearButton to the GFMTextField (because there is currently still no native solution in SwiftUI for clearing the text input of a TextField in SwiftUI).
https://www.hackingwithswift.com/forums/100-days-of-swift/adding-a-clear-button-to-a-textfield/12079

SearchView: clear username input on '< Back'

FollowersView: encapsulate .onChange stuff into the GFMService

FavoritesView: on tap of a list item (user), open its FollowersView

1. wrap the FavoritesView in a NavigationView ✅
2. wrap the FavoriteRow in a NavigationLink ✅
3. what happens when offline: currently the empty state view is shown

General: add comments (documenting the code)

GFMInfoView - WebView: .topTrailing DismissButton not visible enough

• In light mode it is only visible after swiping up
• In dark mode the hamburger menu is in the way

[BLOCKER] Roadmap: Voting count doesn't work

NSErrorFailingURLStringKey=https://api.countapi.xyz/hit/dev.simonberner.GitHubFollowMe/feature3, NSErrorFailingURLKey=https://api.countapi.xyz/hit/dev.simonberner.GitHubFollowMe/feature3, _kCFStreamErrorDomainKey=4}
Voting failed: La requête a expiré.

Testing: more Unit-Tests

Unit-Test SwiftUI Views with: https://github.com/nalexn/ViewInspector

FavoritesView: losing global actor 'MainActor' when calling onAppear()

Converting function value of type '@mainactor () -> ()' to '() -> Void' loses global actor 'MainActor'

General: review, reflect and refactor

• Encapsulate switch on gfmError ✅
• Rename to GFMAggregatedRoot to GFMService (inspired by https://azamsharp.com/2022/07/17/2022-swiftui-and-mvvm.html#global-state) ✅
• Maybe use TCA (The Composable Architecture) in the future?

UserDetailView: GFMEmptyFollowerView appears when getting the followers of a selected follower

GFMViewModel: change to Aggregate Root (MV State Pattern)

I have actually build this project using the MV State Patter as described here https://azamsharp.com/2022/08/09/intro-to-mv-state-pattern.html rather than the classical MVVM pattern.

FollowersView: clear/cancel a wrong username in the username search leads to GFMEmtpyFollowerView

Experiment with a CustomTabBar

https://github.com/pratikg29/CustomTabBar

Testing: add Snapshot Testing (UI-Tests)

https://medium.com/dev-jam/snapshot-testing-in-swift-9d52cbec075c

https://github.com/pointfreeco/swift-snapshot-testing

The SearchView and FavoritesView show the same FollowersView

[POC] SkeletonView

https://github.com/Juanpe/SkeletonView

Show an Alert when there is no GitHub user for the given username

GFMService: refactor api calls