GithubHelp home page GithubHelp logo

abstractnumbers.jl's People

Contributors

jeffreysarnoff avatar juliatagbot avatar pallharaldsson avatar rafaqz avatar simondanisch avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

rafaqz pallharaldsson standardgalactic ederag jeffreysarnoff

abstractnumbers.jl's Issues

example needs to define `number(x::MyNumber)` 

julia> using AbstractNumbers, SpecialFunctions

julia> struct MyNumber{T} <: AbstractNumbers.AbstractNumber{T}
           number::T
       end

julia> Base.convert(::Type{Number}, x::MyNumber) = x.number
julia> AbstractNumbers.basetype(::Type{<: MyNumber}) = MyNumber

julia> a=MyNumber(1.2)
MyNumber{Float64}(1.2)

julia> sin(a)
ERROR: AbstractNumbers.number not implemented for MyNumber{Float64}
Stacktrace:
 [1] error(::String) at .\error.jl:33
 [2] number at C:\Users\jas\.julia\packages\AbstractNumbers\qex5D\src\AbstractNumbers.jl:12 [inlined]
 [3] sin(::MyNumber{Float64}) at C:\Users\jas\.julia\packages\AbstractNumbers\qex5D\src\overloads.jl:17
 [4] top-level scope at REPL[8]:1

julia> AbstractNumbers.number(x::MyNumber) = x.number
julia> sin(a)
MyNumber{Float64}(0.9320390859672263)

TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Add `AbstractReal`

Yeah, this is awful. But this PR may never be merged: JuliaStats/Distributions.jl#1691 and other <: Real limitations exist in the ecosystem. Adding AbstractReal here would be basically identical code to AbstractNumber, but <: Real, and can share most of the code.

Ambiguity on nightly: 

1 ambiguities found
Ambiguity #1
polygamma(a::Number, b::AbstractNumbers.AbstractNumber) in AbstractNumbers at /home/pkgeval/.julia/packages/AbstractNumbers/ONC07/src/overloads.jl:1251
polygamma(m::Integer, z::Number) in SpecialFunctions at /home/pkgeval/.julia/packages/SpecialFunctions/LC8dm/src/gamma.jl:562

Seems like a real ambiguity, or?

suggestion: move the Implementation section of the README into generator_script.jl

Having it in the Readme makes us think it's relevant to the package user (even if the section is titled "Implementation"), and reading it made me uncertain about whether this is a dev-only dependency used to generate code, or if it uses @eval on the strings it's talking about, etc. Looking at the code, it becomes obvious that it's a casual remark about an implementation detail, but it would be better to avoid the potential for confusion in the first place.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.