simplesamlphp / simplesamlphp-module-adfs

This module adds support for WS-Federation

SimpleSAMLphp

This is the official repository of the SimpleSAMLphp software.

• SimpleSAMLphp homepage
• SimpleSAMLphp Downloads

Please, contribute!

simplesamlphp-module-adfs's Issues

Module Not Functioning in 2.1.0

This instantiation for StreamedResponse is invalid and throws an error:

simplesamlphp-module-adfs/src/IdP/ADFS.php

Line 55 in 8b2e3e9

return new StreamedResponse([$idp, 'handleAuthenticationRequest'], [&$state]);

Reverting commit 8b2e3e9 resolves the issue on my 2.1.0 instance.

ADFS Post response should exit

When we've been testing v1.0.2 module we get a weird behavior where the ADFS module post a response AND shows an about "Code should never be reached". I believe this is because the response code below

simplesamlphp-module-adfs/lib/IdP/ADFS.php

Lines 201 to 210 in 10fd1c9

	private static function postResponse(string $url, string $wresult, string $wctx): void
	{
	$config = Configuration::getInstance();
	$t = new Template($config, 'adfs:postResponse.twig');
	$t->data['baseurlpath'] = Module::getModuleURL('adfs');
	$t->data['url'] = $url;
	$t->data['wresult'] = $wresult;
	$t->data['wctx'] = $wctx;
	$t->send();
	}

is different from HTTP::submitPOSTData which calls exit(0) after running.

The ADFS response does not call exit() which results in code in prp.php to continue to run.

Adding exit() into ADFS class works fine in our test environment. I was looking to make a PR but I see master has moved to Symfony controller, which I'm not familiar with. I think this issue wouldn't exist in master since the controller is returning a streamed response.

Should we make a v1.0.3 that has a fix for this issue, and the cherry-picked mis-named file commit (a297351) and any other issues we uncover with our testing?

Missing return types causing issues on php 7.4 with ssp v1.19.1

Most of this commit needs to be applied to have a working install of the ADFS module included in the distributed v1.19.1 available on the website.

Installation: Ubuntu:latest docker container with php7.4
SSP Version: 1.19.1

wrong filename javascript asset

In the module adfs when using the new ui ('usenewui' => true) the adfs module uses postResponse.js but the file is called modules/adfs/www/assets/js/postReponse.js.
Missing 's' between Re and ponse.js

Tested on version 1.8.5

Module is broken

I installed the module using composer, but it's pretty broken. Trying to display metadata just gives a: "Error 500", and when trying to authenticate it'll give this exception: "Template: Could not find template file [adfs:postResponse.twig]". I checked, and the template is present.
I'm running simplesamlphp v1.19.4, php version 7.4.3 and ubuntu 20.04LTS

License is LGPL-2.1 or LGPL-3.0

LGPL-3.0 is listed in LICENSE file, but LGPL-2.1 is shown as main license by git. Which would be the main license?