simplesteph / grpc-java-course

Companion Repository for my gRPC Java course

Grpc Java Course

This is a companion repository for my GRPC Java course

Content

• Greeting Service
• Calculator Service
• Unary, Server Streaming, Client Streaming, BiDi Streaming
• Error Handling, Deadlines, SSL Encryption

grpc-java-course's Issues

Java 11

/home/jr/Documents/Projetos/grpc-java-course/build/generated/source/proto/main/grpc/com/proto/blog/BlogServiceGrpc.java:20: error: cannot find symbol
@javax.annotation.Generated(
^
symbol: class Generated
location: package javax.annotation

Do you know why I'm getting this error?

error on import com.proto.blog.*

after downloading the github project error on import com.proto.blog.*

Unnecessary try-catch instead of validation

Hello Stephane, I'm taking your course right now, and during it just found the approach you use, which in my opinion could be improved.
I understand that the course is not about "good practices" or "java coding", but since the students could refer to this code, it makes sense to use best practices.

In this case, ObjectId has a static method #isValid, and we can make this check (with returning INVALID_ARGUMENT status) instead of naive try-catch.

grpc-java-course/src/main/java/com/github/simplesteph/grpc/blog/server/BlogServiceImpl.java

Line 64 in f4352f6

result = collection.find(eq("_id", new ObjectId(blogId)))

Wait until get all Blogs

There is a method, which returns stream response of Blog:

 public java.util.Iterator<com.proto.blog.ListBlogResponse> listBlog(
        com.proto.blog.ListBlogRequest request) {
      return blockingServerStreamingCall(
          getChannel(), getListBlogMethod(), getCallOptions(), request);
    }

To print each blog one be one:

        blogClient.listBlog(ListBlogRequest.newBuilder().build()).forEachRemaining(
                listBlogResponse -> System.out.println(listBlogResponse.getBlog().toString())
        );

But if it's needed on client to wait until getting all blogs and having it as com.proto.blog.ListBlogResponse, what's the best option to do?

@simplesteph , could you please help