sionleroux / guesstheanimal Goto Github PK

For the MVP it's just slowing us down to always include all the translations.

Solution: Only use english translation and delete the other ones.

• Dagger2 for DI: https://google.github.io/dagger/
• Reactive programming : https://github.com/ReactiveX/RxJava // https://github.com/ReactiveX/RxKotlin
• View Annotations: http://jakewharton.github.io/butterknife/

On the Nexus 7 the keyboard pops up automatically, pushing away the question text so you can't read it. There's still a large blank white space though. I suppose there are several possible solutions:

• it would be best if the activity was flexible and the input box moved with the keyboard
• the input box could be no longer set as active to stop the keyboard popping up automatically
• in the worst case, the input box could be stuck to the bottom of the text instead of the bottom of the screen

Emulator: Nexus 5x

Use a well generated .gitignore file instead of the old one:
https://www.gitignore.io/api/android%2Candroidstudio

It comes with lots of nice features:

1. Answers - Real-time analytics and event tracking
2. Beta - App distribution for beta testing
3. Crashlytics - Best-in-class crash reporting
4. Digits - Phone number sign-in
5. Twitter Kit - Twitter login and content

https://docs.fabric.io/android/fabric/overview.html

Although I like the old traditional android design, don't you think that it would be awesome to play with Material design?

The Gradle build produces an APK, we could attach this automatically to a tagged release in GitHub.

Writing tests is the most basics skills for a programmer nowadays right? ;)

Animals learnt don't persist when you close the app and open it again. This is because animals are only stored in memory in a static class and passed around as intents, but never saved to file (Except for the first two, which are hard-coded, see #3).

For persistence the animal tree should be serialised and saved to database or file, either when the app is closed or each time a new animal is learnt. I'm not sure which one is more reasonable.

Either localise the starting animals or delete them and add new questions to learn introduce the game and learn the first animal instead.

It can be

• mvp
• mvc
• mvvm

... To have a clean code

Unfortunately #9 is closed but I want to re-open the part when we migrate to Kotlin, because it's fun and modern.

further information: https://help.github.com/articles/about-project-boards/

Would be nice to track issues.

Maybe it would be nice approach to remove all the Activities and use Fragments instead of them. They are re-usable, easier to optimize to tablets etc.

I know you tried to aim the lowest android devices, but I think it would be nice to update the project to:

• at least minSdkVersion: 16
• supportLibraryVersion = "25.3.1"
• com.android.tools.build:gradle:2.3.3
• kotlin lang

There are lots of positive and negative points on using static imports inside your codebase.
@sinisterstuf I'm curious about your opinion.

https://en.wikipedia.org/wiki/Static_import

IMHO there are places where It's useful to use, like when you want to set a UI element's visibility, because everyone knows that there are 3 posibilites

• View.Visible
• View.Invisible
• View.Gone

So It's okay to leave out the View part, but all the codes that are made of us and not part of the Android/Java SDK is readable if we keep the class annotation.

It can be done two ways:

• Having a main menu with options like New Game , How-to play , About
• Having a menu on the Actionbar (refers to #10 )

Hey!

You should set some options, because I can't even set a label to my Issues / PR's

As the following stuff:

• License to README
• PULL_REQUEST_TEMPLATE.MD
• CONTRIBUTING.MD
• CODE_OF_CONDUCT.md.
• Contributors list
• https://www.codetriage.com badge (or any fancy badge)

... and so on

Whenever the application can't guess the animal and asks the user what he or she thinks of the user can leave edittext empty and navigate to the next screen.

Affected screens:

• "I give up! What animal are you thinking of?"
• "Oh, I've never heard of placeholder before ..."

It's connecting to the #4 issue.

We should give a chance to Room: https://medium.com/@ajaysaini.official/building-database-with-room-persistence-library-ecf7d0b8f3e9

All cool apps these days have a dark mode. This one should have that too.

It's never too early to monitor memory leaks in the application:
https://github.com/square/leakcanary