sissilab / obsidian-image-toolkit Goto Github PK

Most everything, when you click on the faded background outside the image, closes the image view. For quality of life, I think clicking outside the image itself should close the plugin view.

All of the darkened area around the image that does not have a button should work as the X button.

Clicking images in the Community Plugins browser to go to the github or something like that will open the image, and that's probably not a behaviour most users desire.

Hi,
Currently, the image zooms only using mouse. But it would be intuitive to zoom the image using touchscreen as well.

Show a count of number of images embedded in the current markdown page.

1. Toggle Fullscreen mode on/off
2. Toggle Actual size on/off

The "store" already has a "click to enlarge" feature, so this plugin working in it is a bit annoying.

Image toolkit (I'm pretty sure) misaligns an image caption in Live Preview Mode

I'm using Obsidian v0.14.5 now with live-preview mode instead of editor-mode.
When I hover over an image, the plus-symbol appears.
And when I click on the image, the image dissappears instead of getting bigger.
Further, the toolbar does not open like it did in previous Obsidian versions.
It only works as usual in preview mode.

It is suggested to add a new function to rename pictures in the toolbar below after clicking to open the picture, which will be much more convenient.
Thank you for your hard work!

建议点击打开图片后的下方工具栏中，新增一个重命名图片的功能，这样会方便很多。
感谢你的辛勤努力!

Issue

I have some screenshots embedded on the markdown page. Using this plugin, I can get an overview quickly, but the major issue is that the image zooms to only 50--60%. In other words, it only zooms just above the Control menu. That way, I have to zoom each image to at least 80--90% to see the text on them.

Solution

It would be great it the image opened up at a default zoom level (to be set in Settings) which would make the image go even beyond the Control Menu. That way, there would be no need to go to Full Screen mode every time I open some text-rich image.

If #49 this is solved, then it would be alright to view the Images in Full screen mode. But since it is unsolved, I prefer to view images in normal mode. And so, it would be nice to have the images automatically zoom a bit more.

Alternative

Give option to always open the Image in actual size.

There are problems with scrolling through photos with a dark background, it is very hard to see it

I suggest doing the following:

1. It is necessary to make it possible to choose the color of the substrate or make it permanent
   Both light and dark backgrounds are combined very well on such a substrate.
   

2. You need to make a stroke of the selected photo with a thin line (so that you can see which photo is currently active)

3. Make it possible in the settings to add arrows for scrolling through the photo

4. Add the ability to scroll through the photo from the keyboard left arrow and right arrow

I would be glad if you take this into account, thank you!

Thanks for the great plugin.
The recent update makes it very easy to use.
It would be perfect if, when in fullscreen view, the vertical image would be centered instead of left-aligned!

Currently, the image popover takes over the entire screen. It would be nice to have an option to move the image popover aside, and thus, we can concurrently type as well as see the image.

After closing Obsidian and restarting it, the setting for displaying the scaling value on the image continues to be enabled, although it is disabled in the plugin. Correct please

!

When the picture is zoom in, the color always revert to true color, even when the link is inverted mode ([[pic|#invert]])
This only happen after the new update i think, it was fine before.

Could you please help check if it is possible to let the user specify the default color mode of the zoomed in pic?

Related: #1

@sissilab This is a great plugin! Really slick.

I was trying to borrow some of your techniques to implement a "Copy Image" function (see this fork/PR: NomarCub/obsidian-copy-url-in-preview#2) but I don't think it's directly possible. I wonder if you have any idea on how to implement a "copy image to clipboard" function?

I believe the key would be to create a hidden BrowserWindow or canvas object and then use the webContents → copyImageAt() API method?

Could you please implement the invert color for dark mode?
Its something like this: ozntel/oz-image-in-editor-obsidian#32

Would love to see all the images of the current markdown file in a separate tab in the sidebar Menu (besides, Backlinks, Outline, etc.)

Would be more great if on clicking the image, the page scrolls to that position.

Hey,

When clicking on Images with definitions like this
![[image.png|-grid]] ![[image.png|-left]]
they get distorted (flated).

You can try on ITS-theme where they have these advanced options for image display.

It would be great if images selected from a grid looked normal
https://user-images.githubusercontent.com/73532672/133224558-fd1200f1-e1e4-4032-a3a4-c21ccb6b3963.mp4

I use the theme "Blue Topaz". When I click an image in edit mode, the plug-in does not work and temporarily shows this "page":

Though it works in preview mode, similar "page" appears temporarily.

Sometimes I am just interested in the link of the picture I am seeing, or I click in the editor pane on a random place to start editing and the window with the image pops up.

I would be more than happy if you could add a (configurable) modifier key to trigger the plugin. For example holding down shift or alt will show me the zoom icon over a picture, clicking at that point will trigger the enlarged picture. An enable / disable icon on the sidebar is also an option, as long as I can turn it off to prevent misclicks, but activate it when I need it. Alternatively, maybe rightclick, and tap in the menu that pops up there?

Another small request, shortcut arrow left and right to quickly go to the next image in the document? This is just nice to have though.

Anyway, thank you for this lovely plugin, I am an artist and being able to zoom and copy/paste is a livesaver.

Just updated to v0.5.1, and it's not working. It wouldn't open when I click the image.

Rolling back to v0.4.2, and it works again.

😭😭

edit: doesn't work on Windows 10 & 11, but works on Kubuntu 21.10

Sometime the plugin randomly stops working properly, I haven't been able to find what exactly causes this. I will try to click on an image to view it bigger, but nothing will happen. The image is "open", and I can no longer type any text or use keyboard shortcuts (I can open the command palette, but not type in it, and I can't use Cmd + Q to close Obsidian). This issue persists until I "close" the "open image" by hitting esc. I then have to restart Obsidian to be able to properly open the image with Image Toolkit. Then at some point the issue will randomly show up again.

There seems to be no limit to the zoom in.
It seems there should be an upper limit.

Thank you for the very nice plugin.

When clicked on, the image can be displayed on top of the toolbar controls. This renders the controls unusable, and by no fault of the user.

Please either limit the image height or do something like adding a background to the toolbar.

It would be nice if you add a function to highlight the previewed image that is triggered after exiting the preview mode. This is especially useful when there are many images in a note! And it is very desirable that the stroke color be configured in the plugin (relevant for different themes)

@sissilab

问题

在0.5.1版本下点击图片是这样的：

打开安全模式之后（关闭所有插件），ob默认的点击图片触发动作如下：

升级到1.0.1之后点击图片会同时打开默认的图片窗口和toolkit自身的悬浮预览：

希望增加开关用以控制预览图片时是否不再打开ob默认的图片窗口

环境

操作系统：win10
ob版本：v0.13.23
ob-image-toolkit版本：v0.5.1 → v1.0.1

It would be great if would be possible to copy image to buffer (and in fullscreen mode too) (for example: by right mouse click), to past to another place or document, or letter for exemple.

Hi!

My emojis/icons (associated with task creation/done) are showing like this:

Is this intended?
Is it undesirable?

The plugin stops working recently after I upgraded it to version 0.5.1 . No response after clicking any image.
The console shows the following error message:

Uncaught DOMException: Failed to execute 'matches' on 'Element': 'img:not(a img)' is not a valid selector.
    at HTMLDivElement.<anonymous> (app://obsidian.md/app.js:1:133015)
    at HTMLDocument.s (app://obsidian.md/app.js:1:135596)

The corresponding lines of code:

        N(Element.prototype, "matchParent", (function(t, e) {
            if (this.matches(t))  // this line triggers the exception
                return this;
            if (this === e)
                return null;
            var n = this.parentElement;
            return n ? n.matchParent(t, e) : null
        }
        )),

My current obsidian version is v0.13.19 .

Hi, so this is not really an issue, more like a question of burning curiosity: What tool do you use to show inputs in the first .gif file inside readme.md.

How do you make a .Gif like that? I really wanna know.

Thank you (and sorry for opening an issue for this question)

Since upgrading to OBSIDIAN version 0.13.9, it is not possible to click on an image to open it in the editing state.

Your plugin is very useful, but I wanted to propose an improvement.

It is very common to have several images in a document,
Is a shortcut possible to change to the previous and next image without leaving the enlarged image?

Not sure if this fits this plugin's scope, but it would be pretty great to have an ability to control gif playback.

Play, Stop, Pause, Go to first frame, and maybe a frame timeline for quick navigation.

Hello,

I love this plugin - thanks so much!

I can imagine that this might be beyond the scope of your plugin, however as an idea, some basic image editing features would make it incredibly streamlined for note-reviewing and flashcard making purposes.

My current use / workflow whilst watching a lecture for example is;

• I take a screenshot of an interesting idea, and paste it into my notes
• often I need to open the image and highlight a specific part
  • I use the follow link under cursor hotkey (my set up is alt + Enter
  • open file in default app ctrl + shift + O which is Greenshot for png files.
  • Make highlights, save.
• Back in Obsidian, I might edit the image file name so that the image is searchable and can be linked to again from different places in the future

The app I use for making highlights/basic image edits is Greenshot app - because it has very simple highlighter tool that I mapped to a hotkey H - here is how I might highlight an image

• other editing tools I might use (e.g. arrow, text, rectangle tool) are not a priority for me, although I do occasionally use them.

I love this technique because concepts that I want to be familiar with (guidelines, policies, concepts etc) have been personalised them with my own colours and ideas - so when I come back to this source image, I am familiar with the coloured highlights and personal edits - a spatial memory trigger similar to as if they were my scribblings and ideas annotating an image in a physical personal notebook.

I hope that makes sense, and thanks again.

It would be great to have a snap to 100% zoom feature on this extension.
Basically going from 95% -> 104.5% zoom it goes 95% -> 100% and vice versa.

I have the code and its working but I didn't want to open a pull request yet as you might want to add an option to the options menu or something.
Onurtag@d22fb3f

Thanks for the great work on obsidian image toolkit.

<div class="modal" style="height: 80%; width: 40%;">
    <div class="modal-close-button"></div>
    <div class="modal-title">2014 - 22</div>
    <div class="modal-content sr-modal-content" id="sr-flashcard-view" style="position: relative; height: 92%;">
        <div class="sr-link">Edit Later</div>
        <div class="sr-link" style="float: right; display: none;">Reset card's progress</div>
        <div id="sr-context"></div>
        <div class="div" id="sr-flashcard-view">
            <p><span alt="....../附件/Pasted image 20210918090030.png"
                    src="....../附件/Pasted image 20210918090030.png"
                    class="internal-embed image-embed is-loaded">
                    <img src="app://local/......Pasted%20image%2020210918090030.png?1631926830367"
                        width="100%" alt="....../Pasted image 20210918090030.png"></span></p>
        </div>
        <div class="sr-response" style="display: none;"><button id="sr-hard-btn">Hard - 1 days</button><button
                id="sr-good-btn">Good - 2.5 days</button><button id="sr-easy-btn">Easy - 3.5 days</button></div>
        <div id="sr-show-answer" style="display: initial;">Show Answer</div>
    </div>
</div>

上面的代码是使用obsidian-spaced-repetition-1.6.2时产生的。

使用obsidian-spaced-repetition-1.6.2+obsidian-image-toolkit-0.35时，上面图片是能正常工作；使用obsidian-spaced-repetition-1.6.2+obsidian-image-toolkit-0.40，上面的图片不能正常工作

Is it possible to somehow transfer the numerical display of the scale on the image to a separate setting. For those who need it, they can enable this setting. For me this displaying the zoom number is overkil

l

At present, if you click the text behind, the picture will disappear automatically after clicking the image.
Can this toolkit displays a picture without blocking the contents behind it?

Hi,
With the new release, we are able to add a Hotkey to go to next or previous image. But this works only in normal mode. It would be great to have these Hotkeys work even on Full screen mode, because it would make it seem like a true Gallery app.

If it is possible to reduce the size of the Image, a lot of storage space would be saved.
Also it would be amazing if we could cut the image.

How would I save the image with inverted colors?

Or how would I save the resized image?

A button "replace original image" and "add as new image" would be really helpful.

Thank you very much for this plugin but i don't see much value if there is no way to save the edits.

Thank you for consideration.

How to reproduce:

Link to a section or block with with ![##Section Name] and then open the gallery by clicking on an image on the page.

Hi

this is awesome, but does it save the new image properties? ie is it only to currently view the transformation or does it also save the on file image property? here it dosent see, to do so?

thx so much!

Z

Hello, @sissilab and @ForThe77 !

Thanks for this plug-in :)

My FR is to have the possibility to navigate in a image that is zoomed.

Example: This is a image of a infographic that has a lot of information:

When you use the plug-in to zoom the image I can’t navigate from the other side of the image. I’m stuck at the top-left region of the image. (5. Text Mining/NPL -> Orange)

My suggestion is using the keyboard arrows (top,bottom, right, left) to navigate in the image after zoom :)

Thanks for this plug-in. Let me know if you need additional information.

Have a great day!

1. In the full-screen view mode, the cursor must be displayed. At the moment it is not there - this is very inconvenient - it is not clear what is happening - there is no control - all programs have a cursor!
2. In the full-screen view, the windows control panel does not close - and, in fact, the meaning of full-screen view is lost.

Here is an example of how it works in other programs and how it is currently implemented in this plugin.
Please make it a handy tool

Good day! Could you make a setting in which it would be possible to view the photo (image) in full screen mode. That is, when you click a photo, the photo (image) is enlarged to full screen mode.

Hello again @sissilab !!!

I have an idea on how to add Edit Mode support for Image Toolkit.

A new Command Palette command Image Toolkit: View Image

When the text cursor is located at an image link (an internal link which contains an image file extension such as![[image.png]] ![[image.jpg]]...) if the user hits the new command Image Toolkit: View Image the Image Toolkit window will open the same way that opens in preview mode.

Would be useful when you are on edit mode selecting images and need to check if you are selecting the right image,

• I'm terrible at naming image files and I always have to check if I am selecting the right image for the note :)

Thanks for reading!

Have a great day!

First congrats for the job: very useful plugin
Would be great to be able to configure specific behaviors on right click or double click.

For example something that would be very helpful for me would be to have:

• full screen display on double click,
• then going back to obsidian with a second double click

Cheers

只更新了代码, 但是没有发版