GithubHelp home page GithubHelp logo

siteorigin / vantage Goto Github PK

View Code? Open in Web Editor NEW
66.0 7.0 15.0 11.8 MB

Vantage is a flexible multipurpose theme. Its strength lies in its tight integration with some powerful plugins like Page Builder for responsive page layouts, Smart Slider 3 for big beautiful sliders and WooCommerce to help you sell online. Vantage is fully responsive and retina ready. Use it to start a business site, portfolio or online store.

Home Page: https://siteorigin.com/theme/vantage/

License: GNU General Public License v2.0

PHP 47.83% JavaScript 22.75% CSS 19.01% Less 10.41%
wordpress-theme woocommerce-theme jetpack theme wordpress page-builder widgets-bundle

vantage's People

Contributors

alexgstapleton avatar braamgenis avatar gregpriday avatar kevinbatdorf avatar misplon avatar ramonanextend avatar siteorigin-support avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

vantage's Issues

Add color settings for the responsive menu

Add settings to control the colors of the mobile menu, similar to what we have in North. Currently, the arrows for sub-menus are images so we'll need to move those after to FontAwesome or similar. I'm not sure the Navigation section is the best place for these settings. We could perhaps create a new section called Mobile Menu and take any mobile menu settings currently in Navigation and put them in this new section with the new color settings.

Vantage Social Media Widget: Tel field to accept URL

@adiraomj Sorry for missing this. Please, can we make the Tel field a bit smarter, just like the email field? Can we make it accept a URL if one is entered and only prepend tel if a phone number is detected?

Update vantage_display_logo

The function uses jetpack_the_site_logo which should be replaced with the_custom_logo. The custom logo feature has been moved from Jetpack to the core since WP 4.5.

We should also change the theme support to add_theme_support( 'custom-logo' );. This will allow us to use the feature even if jetpack is not installed.

Should I go ahead with this @gregpriday ?

Mobile sticky menu behaviour is different to desktop behaviour

Testing in iOS Chrome and Safari, the sticky menu in Vantage disappears on swipe and then reappears when stopped. User feedback suggests that users would prefer to see the same sticky menu behaviour that we have on desktop with the sticky menu being present always when activated.

Widget Styling

The default and WooCommerce widgets seem to have little to no styling. How about adding a little CSS? Nothing fancy, would mostly be adding padding/margin where necessary.

Add styling for WooCommerce widgets

@adiraomj I'd imagine the products widget is the most important. If possible, can you take a look at them all and see what needs to be done to get them in decent order?

Thanks

WooCommerce Cart
WooCommerce Layered Nav
WooCommerce Layered Nav Filter
WooCommerce Price Filter
WooCommerce Product Categories
WooCommerce Products
WooCommerce Product Search
WooCommerce Product Tags
WooCommerce Recently Viewed
WooCommerce Recent Reviews
WooCommerce Top Rated Products

Increase Font Size of certain elements when on mobile devices to increase readability (as per PageSpeed Insights recommendation)

Very minor thing but it'll appease certain people. ๐Ÿ˜• The font size of certain elements, typically the post meta, and comment related sections have very small "tap areas" (12px font-size). From what I can tell, typically if you increase it to 13px or 14px on mobile Google considers it large enough. Making this will increase set our defualt mobile experince to 100%.

Reference Links:
Blog Post (demo site - it's under User Experience)

Add Email icon to social widget

You should be able to set an email widget. It might be nice if this icon was "smart" in that it would check if it was an email and set it as a mailto if it was.

sample

Ability to customize scroll to top coloring

You should be able to adjust the scroll to top colouring to better suit your websites colouring.
Oddly, there doesn't seem to be a default hover so it would be a good idea to introduce that also for UX reasons.

Ideal settings:

  • background
  • background hover
  • color
  • color hover

Settings framework bugs

Found a couple of issues.

The measurement field type does not show units in customizer.php.

The text fields in settings.php is showing an empty select field below the text input.

I am using the latest version of the settings submodule.

Support Breadcrumb NavXT

We could add support for Breadcrumb NavXT plugin in addition to Yoast SEO. Similar to what we have done for North.

Posts page: Post titles aren't outputting

The blog page isn't displaying post titles. Post titles are however displaying in category archive pages. The blog page issue applies both "Front page displays: Your latest posts" and to a defined posts page.

FitVid: Add Support for WooCommerce only pages (such as Shop)

If you add a video to the shop page in WooCommerce, it won't be affected by FitVid. This is due to the WooCommerce shop page making use of a "custom" archive template. Specifically, it doesn't follow the exact structure outlined here.

If you add .woocommerce #main to the selector, it'll work as desired. Please note that you can't use our typical .site-content class as this wrapper is generated by WooCommerce.

Unable to full screen YouTube embed in IE11

Issue was reported in this thread.

IE11 won't allow users to fullscreen embed YouTube videos. Able to reproduce locally with the following embed:
<iframe class="video_view9_img" width="720" height="430" src="//www.youtube.com/embed/G6cLbHNaDW0" style="border: 0;" allowfullscreen=""></iframe>

A quick Google produced no solutions. I hope someone besides me runs Windows. ๐Ÿ˜Ÿ

Polylang Plugin: Add styling for the language switcher widget.

The Polylang language switcher widget is most commonly used in the header widget area, we just need to remove the list style and make sure it looks normal. Let's also check it in the sidebar, footer and Page Builder.

@gregpriday Should we add this as an extra stylesheet dependent on Polylang being active? Should all plugin CSS be in conditional stylesheets? Or only when it's over x amount of lines?

Leave a comment post meta link isn't translatable

Unable to translate the following:

$comments_link = '<span class="comments-link"><a href="' . get_comments_link() . '">' . get_comments_number_text( 'Leave a comment' ) . '</a></span>';

Thanks guys.

Responsive Menu Collapse: Change setting to measurement

It's really common for users to enter a value that's too low like say 10 and then not understand why the responsive menu doesn't work. This ideally needs to be a measurement setting with a minimum of 480. Ideally, users shouldn't be able to break the responsive menu by setting a value below 480.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.