sitewards / ansible-role-prometheus-proxy Goto Github PK

Thanks for publishing this role.

It was a convenient starter for me to use NGINX as reverse proxy for Prometheus exporters.
I've made a few changes in a fork and are happy to do a PR for some/all if suitable for you?

1. Remove dependency on geerlingguy.nginx role by adding a handler to reload nginx. Same could be done for apache2

   • On ubuntu, nginx is a simple ansible task apt state=present away. So I simplified my playbook to install nginx + remove default site, then run this role. Couldn't see the need for geerlingguy role.
   • The nginx official ansible role also seemed heavyweight for my use case.
   • May revisit later for additional configuration like compression, etc, or add to template.

2. Add simple IP whitelist to template.

   • With encryption and authn we are most of the way there. IP whitelist just adds another layer.
   • One might combine/negate need for this with firewall rules though depending on your viewpoint.

I couldn't see a license (MIT/Apache?) so hope this was okay (per Github TOS?). Thanks again.