sivakothuru / django-pollapp Goto Github PK

TEMPLATE_DIRS should be a tuple of strings, I am not able to even start the project.

DATABASES should not be kept in settings.py. Create another file called local_settings.py and move db settings to that file. Import local settings in your settings.py

Authentication functionality should be in a separate app.

Your login view only checks a valid form and shows all the polls. You are not actually loggin in the user. So, if the user wants to see all the polls again he has to login again, which is wrong. If he logs in once, he shouldn't be required to log in again.

also add a logout view.

Seems you haven't pushed your commits for some time. Please keep pushing as you commit anything.

Also add travis build status indicator and coveralls.io coverage indicator to the README.

It says " -- 0 votes", doesn't tell which choice got 0 votes.

eg:
Poll- What is your favourite ide?
Choices are Vim, Emacs and Komodo.

I first vote fo vim. then result shows that 1 vote has been cast for vim and 0 vote for other two.
Then I change my vote to "Emacs", still the result says that 1 vote has been cast for vim and 0 vote for Emacs.

Also, redirect the user to the login page once logout is done.

Your login view works, but it is mixing AuthenticationForm as well as authenticate() provided by django.

If you use AuthenticationForm(), you should not be required to use authenticate(), find out how you can get the user from AuthenticationForm instance.

Or, don't use AuthenticationForm if you want to use authenticate().

Even if I am logged in and I go to http://127.0.0.1:8000/, I see the login form again. This is confusing. You should redirect to index page if the user is already logged in.

Consider you are not logged in.

Then I try this url http://127.0.0.1:8000/polls/1/results/, since I am not logged in it will take me to http://127.0.0.1:8000/?next=/polls/1/results/.

After successful login I should be redirected to the 'next' parameter in the url which in this case is the results of Poll 1.