sk-ys / redmine_issue_note_list Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 186 KB

This is a plugin for Redmine.

License: GNU General Public License v2.0

Ruby 29.21% HTML 21.69% CSS 29.37% JavaScript 19.74%

redmine_issue_note_list's People

Contributors

Watchers

redmine_issue_note_list's Issues

Incorrect item height

If there are too many columns in the issue to display, the item height is incorrect.

Failed to add note

F, [2023-10-20T08:02:35.659199 #2620] FATAL -- : [ade7b25a-1aff-4bce-8140-0db740f2dc91]   
[ade7b25a-1aff-4bce-8140-0db740f2dc91] ActionView::Template::Error (undefined method `updated_on' for #<Journal:0x00000272b1626e40>
Did you mean?  update):
[ade7b25a-1aff-4bce-8140-0db740f2dc91]     1: <% Rails.logger.info @issue.current_journal %>
[ade7b25a-1aff-4bce-8140-0db740f2dc91]     2: <% if !@saved || @issue.current_journal.updated_on.blank? %>
[ade7b25a-1aff-4bce-8140-0db740f2dc91]     3:   alert("<%= l(:issue_note_list_failed_to_add_note) %>");
[ade7b25a-1aff-4bce-8140-0db740f2dc91]     4: <% else %>
[ade7b25a-1aff-4bce-8140-0db740f2dc91]     5:   // replace form to view
[ade7b25a-1aff-4bce-8140-0db740f2dc91]   
[ade7b25a-1aff-4bce-8140-0db740f2dc91] plugins/redmine_issue_note_list/app/views/issue_notes/add_note.js.erb:2
[ade7b25a-1aff-4bce-8140-0db740f2dc91] plugins/redmine_issue_note_list/app/controllers/issue_notes_controller.rb:65:in `add_note'

Rename controller IssueNotes to IssueNoteList

Add feature to double-click to edit

Add feature to submit all

Template missing when deleting notes

Error message:

Missing template, responding with 404: Missing partial issue_note_list/_update_issue_notes_row, application/_update_issue_notes_row with {:locale=>[:ja, :en], :formats=>[:js, :html, :text, :css, :ics, :csv, :vcf, :vtt, :png, :jpeg, :gif, :bmp, :tiff, :svg, :mpeg, :mp3, :ogg, :m4a, :webm, :mp4, :otf, :ttf, :woff, :woff2, :xml, :rss, :atom, :yaml, :multipart_form, :url_encoded_form, :json, :pdf, :zip, :gzip], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :coffee, :rsb]}. Searched in:
  * "C:/Redmine/redmine/plugins/view_customize/app/views"
...

This is a mistake in #78.

Add note edit button

Edit date and editor cannot be updated with original edit button. So, need to consider measures.

Related source

JournalsHelper

https://github.com/redmine/redmine/blob/master/app/helpers/journals_helper.rb#L52-L59

      if journal.editable_by?(User.current) 
         links << link_to(l(:button_edit), 
                          edit_journal_path(journal), 
                          :remote => true, 
                          :method => 'get', 
                          :title => l(:button_edit), 
                          :class => 'icon-only icon-edit' 
                         )

JournalsController#Edit

https://github.com/redmine/redmine/blob/master/app/controllers/journals_controller.rb#L84-L90

  def edit 
     (render_403; return false) unless @journal.editable_by?(User.current) 
     respond_to do |format| 
       # TODO: implement non-JS journal update 
       format.js 
     end 
   end

Views/Journals/edit

https://github.com/redmine/redmine/blob/master/app/views/journals/edit.js.erb#L7

  $("#journal-<%= @journal.id %>-notes").after('<%= escape_javascript(render :partial => 'notes_form') %>');

Views/Journals/update

https://github.com/redmine/redmine/blob/master/app/views/journals/update.js.erb

Views/Journals/_note_form

https://github.com/redmine/redmine/blob/master/app/views/journals/_notes_form.html.erb

Add number of notes field to query form

Adjust the height of the notes field

Support for delete action

Keep cell width

Display last_notes

Clean up css

Support contextmenu

メモ

右クリックイベントは画面内どこでも検知するが、target に .js-contextmenu があり、かつ上位要素の tr に .hascontextmenu が無いとコンテキストメニューは開かない

右クリックイベント処理箇所

https://github.com/redmine/redmine/blob/a519accb99ee8392ffaa6805cec37d7749b8b57d/public/javascripts/context_menu.js#L6

function contextMenuRightClick(event) {
  var target = $(event.target);
  if (target.is('a:not(.js-contextmenu)')) {return;}
  var tr = target.closest('.hascontextmenu').first();
  if (tr.length < 1) {return;}
  event.preventDefault();
  if (!contextMenuIsSelected(tr)) {
    contextMenuUnselectAll();
    contextMenuAddSelection(tr);
    contextMenuSetLastSelected(tr);
  }
  contextMenuShow(event);
}

コンテキストメニュー初期化箇所

https://github.com/redmine/redmine/blob/a519accb99ee8392ffaa6805cec37d7749b8b57d/public/javascripts/context_menu.js#L221

function contextMenuInit() {
  contextMenuCreate();
  contextMenuUnselectAll();
  
  if (!contextMenuObserving) {
    $(document).click(contextMenuClick);
    $(document).contextmenu(contextMenuRightClick);
    $(document).on('click', '.js-contextmenu', contextMenuRightClick);
    contextMenuObserving = true;
  }
}

Despite submitting the form, a pop-up window appears confirming that you are leaving the site.

Add scroll button

View only mode

Add query to set height of note field

Display multiple notes

First, consider whether the history section of the Issue can be applied.

related to

Add Collapse/Expand feature for each issue row

Update rows using AJAX

Support Lightbox2

Add collapse/expand feature for each note

Apply Resizable to cell height

Failed to add new issue

Keep disabled field status

Authentication error when adding a note

Filter chain halted as :find_optional_project rendered or redirected
Completed 403 Forbidden