skaringa / tzdataservice Goto Github PK

@skaringa
Hi and thanks for the code!

I wanted to ask though.

You have:
return (int) Math.floor((lon - 7.500000001) / 15) + 1;

In case (lon-7.5) is >0 we are ok, floor will work as supposed.
But, in case (lon-7.5) <0 , we must use ceil in order to go down.

Also, in tzname = String.format("Etc/GMT%+d", -tzOffset);
Why do you use minus? -tzOffset ?

If, for example we use longitude = -125, then tzOffset will be < 0, and you use -tzOffset in the format, so GMT is GMT + .
But, at this longitude (west), the GMT is minus (GMT-8 for example).

Am I missing something?

Thanks!