skatejs / kickflip Goto Github PK

If it is optional, kickflip() should return a function that accepts a name which will return a constructor.

This should still be supported:

const MyElement = kickflip('my-element', {
  render () {}
});

However we should support this:

const defineMyElement = kickflip({
  render () {}
});

const MyElement = defineMyElement('alternate-name');

This would allow consumers to use any templating language that compiles down to Incremental DOM while keeping the way we've configured it to run.

This means they can:

import { elementOpen, ... } from 'kickflip/src/vdom';

We currently check some attributes in the factory functions and apply them in different ways depending on what they are. Instead, we should create Incremental DOM attribute handlers for them and handle them at that level. This would enable JSX -> IDOM compilation to take on the same semantics as our VDOM functions.

See #1 and https://github.com/google/incremental-dom.

It'd be nice to not have to maintain our own implementation, so we should spike using Virtual DOM as the defacto diff / patch implementation for this.

However, there are some advantages to our implementation we should consider:

1. It's smaller.
2. It can diff real DOM and virtual DOM interchangeably.
3. On initial investigation it seems smarter about attribute / property setting.
4. Does Virtual DOM bind events?

Number 2 and 4 are a must and we can probably work around number 3. Number 1 isn't very important as it's not that much smaller (30k unmin or so).

The biggest priority is ensuring that we can still do element.appendChild(node) and not lose a reference to node during the rendering process. Maybe due to the nature of the patching process and doing as little transformations as possible, this is not possible. Need to investigate.