GithubHelp home page GithubHelp logo

Comments (7)

SkyeOfBreeze avatar SkyeOfBreeze commented on June 29, 2024

Starting to investigate

from letsrobot-android.

SkyeOfBreeze avatar SkyeOfBreeze commented on June 29, 2024

Memory leak is occurring in this function:
https://github.com/btelman96/runmyrobot_android/blob/8c74fda00181842f581e19b9fc0ada7220665aec/letsrobotandroid-api/src/main/java/tv/letsrobot/android/api/components/camera/CameraBaseComponent.kt#L134-L139

If the network is really bad, this will just keep on building up. Fix would be to add an external Queue mechanism

from letsrobot-android.

SkyeOfBreeze avatar SkyeOfBreeze commented on June 29, 2024

Moto Z Profiling data
image

from letsrobot-android.

SkyeOfBreeze avatar SkyeOfBreeze commented on June 29, 2024

This appears to be a mix of Bitmap leaking and handler freezing

from letsrobot-android.

SkyeOfBreeze avatar SkyeOfBreeze commented on June 29, 2024

332bcd5 only fixes leaking issues with camera2. The main leak still exists

Edit: This actually broke camera and was reverted

from letsrobot-android.

SkyeOfBreeze avatar SkyeOfBreeze commented on June 29, 2024

How this happened:

Frames are sent to an android handler. If the phone cannot process data fast enough or the network is too slow for given bitrate, objects will start to pool up. each time a frame is processed, the pool is eliminated, but if it goes too long without sending a frame, it builds up to the point where the app crashes.

This now will not queue data to the handler unless the handler has no data at all

from letsrobot-android.

SkyeOfBreeze avatar SkyeOfBreeze commented on June 29, 2024

Moto Z profiling. 1920x1080 at 10Mbps, which was really laggy. Saw no bad memory spikes

image

Spike at the beginning is the profiler initializing

from letsrobot-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.