skylenet / discv4-crawl Goto Github PK

DESCRIPTION:

Double quotes around $@ (and similarly, ${array[@]}) prevents globbing and word splitting of individual elements, while still expanding to multiple separate arguments.

Let's say you have four arguments: baz, foo bar, * and ////.

"$@" will expand into exactly that: baz, foo bar, * and ////.

$@ will expand into multiple other arguments: baz, foo, bar, file.txt, otherfile.jpg, and (eventually) a list of most files on the system.

Since the latter is rarely expected or desired, this issue warns you about it.

PROBLEMATIC CODE:

cp $@ ~/dir
CORRECT CODE:

cp "$@" ~/dir

Fix the problematic code here: discv4-crawl/blob/master/run.sh#L59-L59