Comments (9)
Yeah, a repro would help a lot, you know.
Judging by the error, it looks as if you were using a moved from storage but it's hard to confirm it.
Do you happen to move the registry in your codebase? You can try to redefine its move ctor/op and assert in there to start with.
Can you provide more details on how you create and use these storage instances? It could also happen because of a dangling pointer due to a concurrent access to the same storage but it would be gross and easy to spot probably.
Let me know if you have more details to share. 👍
from entt.
Thank you for your response! I don't think I move the registry anywhere but I will check later by using your assert method.
I create and clear the storage like this:
registry.clear<Renderable>();
std::vector<entt::entity> layer_entities;
for (auto entity: layer_entities)
{
if (not registry.all_of<Position, Drawable>(entity))
continue;
registry.emplace<Renderable>(entity, ...);
}
Then I use it via registry.view<...>().each(...)
at many places in my codebase, e.g.
registry.view<Renderable, Drawable>().each(
[](auto entity, auto &renderable, auto &drawable){
// do something ...
// but neither create or remove any components from the registry
});
from entt.
Side note:
I create and clear the storage like this:
I suggest creating a view<entt::get_t<Position, Drawable>>
and use it with your if
. It's much faster because it avoids the storage lookup otherwise performed by the registry. Similarly:
registry.emplace<Renderable>(entity, ...);
Get the storage once and use it again and again as in storage.emplace(entity)
. Same reason as above. In a tight loop, it can help. 👍
As for your problem, do you happen to use a registry from multiple threads? Consider that pool creation isn't thread safe and could quickly lead to UB if you don't create pools in a warm-up tick or function.
If it's not the case, well, I'm trying to think aloud and guess since I don't have a repro. I hope it helps. 👍
from entt.
I suggest creating a view<entt::get_t<Position, Drawable>> and use it with your if. It's much faster because it avoids the storage > lookup otherwise performed by the registry.
Oh, I didn't know that. So i could write this?
auto storage = registry.view<entt::get_t<Position, Drawable>>();
for (auto entity: entities) {
if (not storage.contains(entity))
continue;
// ...
}
from entt.
As for your problem, do you happen to use a registry from multiple threads? Consider that pool creation isn't thread safe and
could quickly lead to UB if you don't create pools in a warm-up tick or function.
If it's not the case, well, I'm trying to think aloud and guess since I don't have a repro. I hope it helps. 👍
Just to make sure, I understand you correctly. I am not allowed to (or rather I shouldn't) do things like this:
// Create a new component while iterating over the same component pool:
auto view = registry.view<Position>();
std::for_each(std::execution::par_unseq, view.begin(), view.end(),
[®istry](auto entity, auto &position){
// DON'T DO THIS
auto new_entity = registry.create();
registry.emplace<Renderable>(new_entity);
});
from entt.
Oh, I didn't know that. So i could write this?
auto storage = registry.view<entt::get_t<Position, Drawable>>(); for (auto entity: entities) { if (not storage.contains(entity)) continue; // ... }
Yeah, exactly. The view doesn't have to lookup the storage, so the check is faster overall and the lookup costs don't sum up.
Just to make sure, I understand you correctly. I am not allowed to (or rather I shouldn't) do things like this:
Yes and no.
Of course, creating instances of the same component type from different threads is risky. It's as if you were pushing at the end of a vector from different threads. Bad things will happen for sure sooner or later. 🙂
What I mean is this though:
thread 1: registry.emplace<T>();
thread 2: registry.emplace<U>();
This is ok in general but only if the pools already exist, so only after the first time.
If you're in doubt, I suggest running a single threaded warmup tick or forcing pool creation on the main thread before spawning other threads. All you have to do is registry.storage<T>()
on a non-const registry.
That said, I don't think this is your issue actually. You said that it runs fine a thousand times, then it breaks, right?
It's hard to tell you the root cause without a repro. Is your project public? Do you have a more detailed stack trace?
At first glance, it really seems as if the storage was invalidated and you were accessing a dangling reference but 🤷♂️ cannot confirm it without debugging it unfortunately, you know.
from entt.
Can I assume it was fixed? I don't have a repro nor other info since two weeks ago and I don't know how to help you further otherwise. So, I'm tempted to close the issue.
from entt.
Yes, thank you. It can be closed. I am sorry for not responding with proper info. I redesigned my code and probably eliminated my error, even though I don't know where it was exactly. Thank you very much for your suggestions.
from entt.
I'm glad you fixed it. Thanks for the quick turnaround. 👍
from entt.
Related Issues (20)
- Serialization of "dead" components
- C++20 ranges trait specializations
- Efficiently iterating over a set of groups? HOT 2
- Signals not triggering properly in storage mixin iterator based insert HOT 2
- Is it possible to use entt::nth_argument_t with lambdas that capture? HOT 6
- Question it is posible to use Entt with lightweight wrapper class as a entt::entity HOT 2
- Calling valid() on empty entt::valid leads to a segmentation fault.
- Add ability to compare entt::null and entt::handle
- Components with overriden new operator. HOT 6
- sparse_set_iterator::operator[] causes warnings when used with size_t HOT 6
- Working with multiple storages for the same type and preparing a view for each of the storages HOT 3
- entt build error: unused type alias 'common_type' HOT 9
- assert on destroy (inside of release function) non-orphan entity HOT 8
- Handling large tilemap HOT 7
- Acecss components of an entity, without giving full registry access HOT 14
- bazel version and compatibility number out of sync
- storage<entt::entity>("id"_hs) should be asserted against HOT 2
- Get a view of components with a certain trait HOT 1
- Groups not functioning without sigh_mixin HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from entt.