skyscanner / backpack-ios Goto Github PK

View Code? Open in Web Editor NEW

108.0 38.0 34.0 776.48 MB

Backpack Design System

Home Page: https://skyscanner.design

License: Apache License 2.0

Ruby 0.31% Objective-C 41.40% JavaScript 1.40% C 0.09% Swift 55.01% Nunjucks 1.66% Shell 0.14%

backpack ios component-library

backpack-ios's People

Contributors

Stargazers

Watchers

backpack-ios's Issues

An in-range update of bpk-svgs is breaking the build 🚨

The devDependency bpk-svgs was updated from `8.2.12` to `8.2.13`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

bpk-svgs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by commits ahead by 0, behind by 6.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of through2 is breaking the build 🚨

The devDependency through2 was updated from `2.0.4` to `2.0.5`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

through2 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-svgs is breaking the build 🚨

The devDependency bpk-svgs was updated from `5.19.2` to `5.19.3`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 43 commits.

6a48842 Publish
6fd9435 Merge pull request #1123 from Skyscanner/bpk-2019-add-new-icons
349db3c [NO-JIRA] Fix out of date package-lock versions
1a4734e [BPK-2019] Add new icons
559a1c7 [BPK-2004] Update build tools and gradle version (#1117)
41c60ee Merge pull request #1116 from Skyscanner/NO-JIRA-update-cross-dep-check-to-exclude-alpha-beta
66da113 [NO-JIRA] Update cross dependency checks to exclude alpha and beta versions
d415856 [No-JIRA] Add tracking docs for android (#1115)
e4dc736 Merge pull request #1113 from Skyscanner/no-jira-add-changelog-link
f2f99e3 Update link copy based on feedback
5ff06c0 [backpack-love] Add changelog link to Readme
022888f Merge pull request #1110 from Skyscanner/close-greenkeeper-issues
f9d0fd8 [NOJIRA] Close more greenkeeper issues
01fb2d6 Merge pull request #1109 from Skyscanner/update-patch-deps
60605c0 [nojira] Close a bunch of greenkeeper issues

There are 43 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-tokens is breaking the build 🚨

The devDependency bpk-tokens was updated from `27.1.1` to `27.2.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

bpk-tokens is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 43 commits.

87c84b9 Publish
b9f6d10 [NO-JIRA] Reoder token imports to enable publish
4f9bb89 [skip ci] Update changelog
e777473 Publish
5058556 Merge pull request #1140 from Skyscanner/bpk-2021-fix-android-button-ripple
73954ed [BPK-2021] Fix android button ripple
64a0e07 Merge pull request #1139 from Skyscanner/BPK-ABORT-let-sf-pro-display-do-its-own-thing
225aec2 [NO-JIRA] User SF pro display tracking
cabbd14 Merge pull request #1138 from Skyscanner/greenkeeper/flow-bin-0.85.0
d2a41d7 chore(package): update flow-bin to version 0.85.0
9c00005 Merge pull request #1131 from Skyscanner/NO-JIRA-add-scrollable-calendar-link-to-components-page
890c478 Merge pull request #1112 from Skyscanner/greenkeeper/eslint-plugin-flowtype-3.0.0
dadf529 [No JIRA] Update eslint-plugin-flowtype to 3.0.0
99ca8b8 chore(package): update eslint-plugin-flowtype to version 3.0.0
c0cbc1e Merge pull request #1129 from Skyscanner/greenkeeper/flow-bin-0.84.0

There are 43 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-svgs is breaking the build 🚨

The devDependency bpk-svgs was updated from `6.4.0` to `6.4.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 9 commits.

27eaa6d Publish
0db845a Merge pull request #1351 from Skyscanner/no-jira-allow-setting-themming-wrapper-component
0284162 [NO-JIRA] Add component prop to BpkThemingProvider
f01fe35 Update globby to the latest version 🚀 (#1347)
7d624a0 Update flow-bin to the latest version 🚀 (#1346)
f242e9e Update del to the latest version 🚀 (#1348)
e393f0a Merge pull request #1344 from Skyscanner/NO-JIRA-fix-license-headers
13ee322 [NO-JIRA] Fix license headers
99f45ed [skip ci] Update changelog after release

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of gulp-nunjucks is breaking the build 🚨

The devDependency gulp-nunjucks was updated from `5.0.0` to `5.0.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

gulp-nunjucks is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v5.0.1

Make Gulp an optional peer dependency 49d5919

v5.0.0...v5.0.1

Commits

The new version differs by 3 commits.

c042298 5.0.1
49d5919 Make Gulp an optional peer dependency
cb86149 Meta tweaks

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of merge2 is breaking the build 🚨

The devDependency merge2 was updated from `1.2.4` to `1.3.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

merge2 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 4 commits ahead by 4, behind by 1.

32e910f remove mjs
e192bc4 Merge pull request #26 from krmax44/patch-1
30c5363 fix: add extension to main script
b9df021 update devDependencies for security alerts.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of husky is breaking the build 🚨

The devDependency husky was updated from `1.2.1` to `1.3.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

husky is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 4 commits.

c13003e 1.3.0
439c271 Update CHANGELOG.md
d90e2d5 Update CHANGELOG.md
2b5ac5f Enable stdin if terminal (#415)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

An in-range update of del is breaking the build 🚨

The devDependency del was updated from `5.0.0` to `5.1.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

del is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v5.1.0

Enhancements:

Allow non-glob patterns with backslash on Windows (like v4) (#100) 01da91f
Make deletion more reliable on Windows by retrying when Windows is being difficult (#108) 1299747
Sort removed files, so the returned array is always stable (#102) ca05c65

Fixes:

Fix the cwd option (#96) ffbf4c4
Prevent race condition on macOS when deleting files (#95) 8efdbcd

v5.0.0...v5.1.0

Shoutout to @chrisblossom for doing most of the work on this release 🙌

Commits

The new version differs by 12 commits.

557c1fa 5.1.0
12c443d Meta tweaks
01da91f Allow non-glob patterns with backslash on Windows (#100)
9c72270 Add benchmarks (#101)
1299747 Use graceful-fs (#108)
f509a89 Update dependencies (#109)
ca05c65 Sort removed files (#102)
51662ac Reverse order back for the returned paths (#99)
902b594 Meta tweaks
ffbf4c4 Fix the cwd option (#96)
8efdbcd Prevent race condition on macOS when deleting files (#95)
9e7550b Add note about backward-slashes

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-svgs is breaking the build 🚨

The devDependency bpk-svgs was updated from `6.3.0` to `6.3.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 16 commits.

7eecc82 Publish
b75b2db Merge pull request #1320 from Skyscanner/BPK-2225-heading-spacing-adjustment
fddac64 [BPK-2225] Heading spacing adjustment
aafb839 Merge pull request #1322 from Skyscanner/fix-homepage-full-width-block
2b5a4d5 [NOJIRA] Fix homepage full width block
f29b76a Merge pull request #1319 from Skyscanner/downgrade-react-responsive
6476c5d [NOJIRA] Downgrade react-responsive
c3dde4e Merge pull request #1317 from Skyscanner/BPK-2225-fix-docs-horizontal-nav
a47b2ba [BPK-2225] Docs horizontal nav scrolling
1927502 Merge pull request #1308 from Skyscanner/BPK-2221-document-RN-calendar
4c41cab Merge pull request #1314 from Skyscanner/upgrade-patch-deps
5e2d5c8 [NOJIRA] Upgrade various patch dependencies
1aef435 [BPK-2221] Document RN calendar
c8aa415 Merge pull request #1313 from Skyscanner/test-eslint-import-order
c3d8e47 [NOJIRA] Testing out import/order in eslint

There are 16 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of husky is breaking the build 🚨

The devDependency husky was updated from `1.1.4` to `1.2.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 6 commits.

d6ecea2 1.2.0
98641f5 Update CHANGELOG.md
c5372b3 Add debug message (#399)
57cb3b9 Add generated by informations in hook script (#400)
d4f7531 Update README.md
fdca003 Update README.md

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

Replaced the old Node.js version in your .nvmrc with the new one
The engines config in 1 of your package.json files was updated to the new Node.js version

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

engines was only updated if it defined a single version, not a range.
.nvmrc was updated to Node.js 10
.travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Build error in Example

Hi there, I'd like to run your Example app, but unfortunately there is a build error (see attached screenshot).

/Users/user/Code/backpack-ios/Example/Backpack/Backpack Native-Bridging-Header.h:23:9: error: 'BPKThemeContainerController.h' file not found
#import "BPKThemeContainerController.h"
^
1 error generated.
:0: error: failed to emit precompiled header '/Users/user/Library/Developer/Xcode/DerivedData/Backpack-bhocfupkndphmcamwrekbprejfnl/Build/Intermediates.noindex/PrecompiledHeaders/Backpack Native-Bridging-Header-swift_2S3Q792V1CMPG-clang_2XBZU5UVWZVSQ.pch' for bridging header '/Users/user/Code/backpack-ios/Example/Backpack/Backpack Native-Bridging-Header.h'
2 errors generated.

I ran all steps outlined in the Setup section of the contributing guidelines and I'm using Xcode 13.4 on macOS 12.4 with the latest main of this repo.

Add support for Swift Package Manager

An in-range update of bpk-svgs is breaking the build 🚨

The devDependency bpk-svgs was updated from `6.4.6` to `6.5.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of lint-staged is breaking the build 🚨

The devDependency lint-staged was updated from `8.1.4` to `8.1.5`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lint-staged is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v8.1.5

8.1.5 (2019-03-01)

Bug Fixes

fix issue with scoped pkg listr-update-renderer (#587) (63b085f), closes #585

Commits

The new version differs by 2 commits.

63b085f fix: fix issue with scoped pkg listr-update-renderer (#587)
1303573 docs: Update screencast and installation instructions

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-tokens is breaking the build 🚨

The devDependency bpk-tokens was updated from `27.4.1` to `27.4.2`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 27 commits.

1a88d34 Publish
de67e51 Remove the list--strip element from the scrollable calendar (#1232)
024cde3 [No JIRA] Bye native (#1269)
2074447 Merge pull request #1235 from Skyscanner/greenkeeper/flow-bin-0.89.0
5faeb60 [No JIRA] Fixes for flow 0.89.0
b4847c9 Merge pull request #1236 from Skyscanner/no-jira-make-bag-check-public
e964582 [NO-JIRA] Load bag check from the public bucket
5844ac8 Merge pull request #1234 from Skyscanner/BPK-2062-hide-deprecated-tokens
8b9a9ad chore(package): update flow-bin to version 0.89.0
4804017 [BPK-2062] Hide deprecated tokens
46220c9 Merge pull request #1233 from Skyscanner/BPK-2062-move-deprecated-prop
4d2cb29 [BPK-2062] Move deprecated prop into the root object for tokens
2f257fe [skip ci] Update changelog after release
e01c8f5 Publish
9d778ae Merge pull request #1231 from Skyscanner/no-jira-alias

There are 27 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-tokens is breaking the build 🚨

The devDependency bpk-tokens was updated from `27.3.0` to `27.4.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 24 commits.

94fb4db Publish
5e71790 Allow passing custom properties to calendar components (#1177)
14b1983 [skip ci] update package locks 🙄
817d36a Merge pull request #1176 from Skyscanner/BPK-2087-typescale-just-wont-go-away-will-it
13aacf5 [BPK-2087] Adjust XXL and XXXL tokens
95eaefe [skip ci] Update changelog post release
a9e0f6f Publish
bae3254 Merge pull request #1175 from Skyscanner/no-jira-bye-felicia
fa753cb [No JIRA] Remove James :sob:
0071e29 Merge pull request #1174 from Skyscanner/BPK-2073-web-badge-iconss
91f649e [BPK-2073] Constrain icons used inside badges to 16x16
8069a86 Merge pull request #1170 from Skyscanner/NO-JIRA-move-deprecated-prop-to-react-utils
d779b0a [NO-JIRA] Move deprecated prop function to react-utils
0d8d4b5 Merge pull request #1172 from Skyscanner/no-jira-fix-submodule-commands
8e0732f [NO-JIRA] Fix submodule commands

There are 24 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of husky is breaking the build 🚨

The devDependency husky was updated from `3.0.2` to `3.0.3`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v3.0.3

Fix: prevent old hooks (husky < 1.0) to be run if new ones are defined (husky >= 1.0 ) #556

Commits

The new version differs by 12 commits.

d067ac4 3.0.3
6a2d457 fix runner should not run old hooks defined in pkg.scripts if another one is in the new config
12bdd4c update please-upgrade-node
d4062da Update README.md
80cb0bc Update README.md
8fad473 Update README.md
895667c Update README.md
b4013bc Update README.md
9b279f5 Update README.md
3c15e76 Update README.md
e674bf3 Update README.md
f89c8c3 Update README.md

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-svgs is breaking the build 🚨

The devDependency bpk-svgs was updated from `6.4.3` to `6.4.4`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 9 commits.

fd9765a Publish
3beae48 Bpk 2282 price alert icon (#1397)
8f2a7c9 Updated Changelog
a02247b Publish
1728974 [BPK-2378]: Updated select component for invalid input (#1396)
0a9e629 [BPK-2371] - Modified to add calendar to native sidebar (#1395)
11aceb9 [NO-JIRA] Add spinner to list of themeable ios components
b827cc0 [BPK-2353]
5e65a3e [skip ci] - Updated Changelog.md

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of lint-staged is breaking the build 🚨

The devDependency lint-staged was updated from `9.2.3` to `9.2.4`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v9.2.4

9.2.4 (2019-08-25)

Bug Fixes

include renames when getting list of staged files (2243a83)

Commits

The new version differs by 1 commits.

2243a83 fix: include renames when getting list of staged files

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of husky is breaking the build 🚨

The devDependency husky was updated from `1.1.0` to `1.1.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 8 commits.

09bbaa3 1.1.1
86379ab Update CHANGELOG.md
f588dac Update CHANGELOG.md
dd57ab7 Check Node version before running hook
821d88d Update CHANGELOG.md
c6b9925 Merge branch 'master' of https://github.com/typicode/husky
1406071 Check HUSKY_SKIP_INSTALL value before other checks
cb9a517 Update BACKERS.md

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-tokens is breaking the build 🚨

The devDependency bpk-tokens was updated from `27.6.5` to `27.6.6`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 22 commits.

4fe8319 Publish
185c54d [BPK-2789]: Change border colour on form elements (#1563)
0f862ae Update mini-css-extract-plugin to the latest version 🚀 (#1538)
c8a07ee Update file-loader to the latest version 🚀 (#1543)
3267f38 Update raw-loader to the latest version 🚀 (#1544)
5193393 Update copy-webpack-plugin to the latest version 🚀 (#1552)
c67049c [NO-JIRA] Prevent auto publish script from re-running lerna
8164dd8 Publish
4f74f6d [BPK-2731]: New configurable nudger component (#1553)
3658635 Publish
432d72a Fix a typo in the readme for bpk-component-map (#1551)
c671516 [BPK-2174] Add rtl metadata to two more icons (#1555)
f68ab57 Publish
68e72c6 [BPK-2174] Add rtl metadata (#1554)
e6b7390 [NO-JIRA] Fix npm pushing from new release script

There are 22 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of bpk-svgs is breaking the build 🚨

The devDependency bpk-svgs was updated from `6.0.6` to `6.0.7`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 27 commits.

1a88d34 Publish
de67e51 Remove the list--strip element from the scrollable calendar (#1232)
024cde3 [No JIRA] Bye native (#1269)
2074447 Merge pull request #1235 from Skyscanner/greenkeeper/flow-bin-0.89.0
5faeb60 [No JIRA] Fixes for flow 0.89.0
b4847c9 Merge pull request #1236 from Skyscanner/no-jira-make-bag-check-public
e964582 [NO-JIRA] Load bag check from the public bucket
5844ac8 Merge pull request #1234 from Skyscanner/BPK-2062-hide-deprecated-tokens
8b9a9ad chore(package): update flow-bin to version 0.89.0
4804017 [BPK-2062] Hide deprecated tokens
46220c9 Merge pull request #1233 from Skyscanner/BPK-2062-move-deprecated-prop
4d2cb29 [BPK-2062] Move deprecated prop into the root object for tokens
2f257fe [skip ci] Update changelog after release
e01c8f5 Publish
9d778ae Merge pull request #1231 from Skyscanner/no-jira-alias

There are 27 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint_d is breaking the build 🚨

The devDependency eslint_d was updated from `7.2.0` to `7.3.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint_d is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 7 commits.

c10ce90 7.3.0
a1501ec Link to core_d in the docs
786d439 Extract core_d
48a95f5 Reinstall dependencies
1bf34a7 Remove superfluous sinon.restore() calls
8f64205 Use mocha-referee-sinon to verify all tests have assertions
ec24293 Use @sinonjs/referee-sinon v5

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

`ScaledFontModifier` lineHeight bug modifier seems like it's not gonna work as intended

It seems that the ScaledFont modifier isn't functioning as intended because the line spacing is set to 0 (source).

private struct ScaledFont: ViewModifier {
    var style: BPKFontStyle
    
    func body(content: Content) -> some View {
        return content.font(style.font)
            .lineSpacing(style.lineHeight - style.lineHeight) // currently 0! Will not work
    }
}

As you can see, the height of the textarea is set to threeLineHeight, but there's extra margin left even when you write three lines.

The corrected code should look like this. Both lineSpacing(1) and padding(2) should be modified to achieve the same visual result as the lineHeight from UIKit. (+you'll need to transform the metrics (fontSize, padding) relative to the current context's sizeCategory if you want to fully support dynamic type size)

private struct ScaledFont: ViewModifier {
    var style: BPKFontStyle
    
    func body(content: Content) -> some View {
        return content.font(style.font)
            .lineSpacing(lineSpacing) ----- (1)
            .padding(.vertical, lineSpacing / 2) ----- (2)
    }
    
    var lineSpacing: CGFloat { style.lineHeight - style.font.lineHeight }  ------ (1) 
}

However, since SwiftUI's Font doesn't provide a lineHeight property like UIFont did, you might need to revert the type of BPKFontStyle.font from Font to UIFont as it was before (source). If you're okay with this change, I can contribute, so please let me know!

skyscanner / backpack-ios Goto Github PK

backpack-ios's People

Contributors

Stargazers

Watchers

Forkers

backpack-ios's Issues

The devDependency bpk-svgs was updated from 8.2.12 to 8.2.13.

The devDependency through2 was updated from 2.0.4 to 2.0.5.

The devDependency bpk-svgs was updated from 5.19.2 to 5.19.3.

The devDependency bpk-tokens was updated from 27.1.1 to 27.2.0.

The devDependency bpk-svgs was updated from 6.4.0 to 6.4.1.

The devDependency gulp-nunjucks was updated from 5.0.0 to 5.0.1.

The devDependency merge2 was updated from 1.2.4 to 1.3.0.

The devDependency husky was updated from 1.2.1 to 1.3.0.

The devDependency del was updated from 5.0.0 to 5.1.0.

The devDependency bpk-svgs was updated from 6.3.0 to 6.3.1.

The devDependency husky was updated from 1.1.4 to 1.2.0.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

The devDependency bpk-svgs was updated from 6.4.6 to 6.5.0.

The devDependency lint-staged was updated from 8.1.4 to 8.1.5.

8.1.5 (2019-03-01)

Bug Fixes

The devDependency bpk-tokens was updated from 27.4.1 to 27.4.2.

The devDependency bpk-tokens was updated from 27.3.0 to 27.4.0.

The devDependency husky was updated from 3.0.2 to 3.0.3.

The devDependency bpk-svgs was updated from 6.4.3 to 6.4.4.

The devDependency lint-staged was updated from 9.2.3 to 9.2.4.

9.2.4 (2019-08-25)

Bug Fixes

The devDependency husky was updated from 1.1.0 to 1.1.1.

The devDependency bpk-tokens was updated from 27.6.5 to 27.6.6.

The devDependency bpk-svgs was updated from 6.0.6 to 6.0.7.

The devDependency eslint_d was updated from 7.2.0 to 7.3.0.

Recommend Projects

Recommend Topics

Recommend Org

Jobs

The devDependency bpk-svgs was updated from `8.2.12` to `8.2.13`.

The devDependency through2 was updated from `2.0.4` to `2.0.5`.

The devDependency bpk-svgs was updated from `5.19.2` to `5.19.3`.

The devDependency bpk-tokens was updated from `27.1.1` to `27.2.0`.

The devDependency bpk-svgs was updated from `6.4.0` to `6.4.1`.

The devDependency gulp-nunjucks was updated from `5.0.0` to `5.0.1`.

The devDependency merge2 was updated from `1.2.4` to `1.3.0`.

The devDependency husky was updated from `1.2.1` to `1.3.0`.

The devDependency del was updated from `5.0.0` to `5.1.0`.

The devDependency bpk-svgs was updated from `6.3.0` to `6.3.1`.

The devDependency husky was updated from `1.1.4` to `1.2.0`.

The devDependency bpk-svgs was updated from `6.4.6` to `6.5.0`.

The devDependency lint-staged was updated from `8.1.4` to `8.1.5`.

The devDependency bpk-tokens was updated from `27.4.1` to `27.4.2`.

The devDependency bpk-tokens was updated from `27.3.0` to `27.4.0`.

The devDependency husky was updated from `3.0.2` to `3.0.3`.

The devDependency bpk-svgs was updated from `6.4.3` to `6.4.4`.

The devDependency lint-staged was updated from `9.2.3` to `9.2.4`.

The devDependency husky was updated from `1.1.0` to `1.1.1`.

The devDependency bpk-tokens was updated from `27.6.5` to `27.6.6`.

The devDependency bpk-svgs was updated from `6.0.6` to `6.0.7`.

The devDependency eslint_d was updated from `7.2.0` to `7.3.0`.