skythen / gobalplatform Goto Github PK

It does not seem to be possible to fully initialize fields LoadFileDataBlockFormatID & ImplicitSelectionParameter as part of SystemSpecificParameters literally as util.NullByte isn't exported. A solution may be to export NullByte or add a creation function for SystemSpecificParameters to map to the NullByte type. Please advise

For declarations at multiple locations the iota key word is repeated for constant declarations. While this is not necessary it also has some unexpected side-effect if the subsequent const declaration does not include the type explicitly.

Take the following example from key.go:

const (
	CMac            UsageType = iota
	RMac                      = iota

In this case CMac is of type UsageType while RMac is of type int, see: https://go.dev/play/p/3ENR8tilQDi

Suggested fix: Remove "iota" from subsequent const declarations. Alternatively, reiterate the type as part of all const declarations.