No response from Hubot about hubot-slack

[nkgwj]

(Sorry about my poor English.)

I have a same issue.

With node-inspector, I confirmed hubot receive the messages, but it never responds.

I found a suspicious code area in listener.coffee by step-by-step execution

I might be wrong,but It looks that all message doesn't match any listeners
.

[nkgwj]

Without slack adapter, hubot responds normally.

For your reference,I attach a screenshot for this case.

[nkgwj]

On Debugger, I executed the following code for bypassing the 'instanceOf' check.

message.__proto__ = TextMessage.prototype

It works. How strange?

[svmaris]

Setting the __proto__ did not work for me. After some debugging it appears that the structure of message has somehow changed. Modifying the "instanceof" to the code below fixed the problem for me:

      if message.message? and message.message.text?
        message.message.text.match @regex

[nkgwj]

Ｉapologize for not providing you with enough explanation.
Some hubot messages are not TextMessage truly, so the __proto__ don't work in such cases.

hubot has several message types:

TextMessage,EmoteMessage,EnterMessage,LeaveMessage,TopicMessage,CatchAllMessage

Because the condition expression in your code matches instances of TextMessage,it seems to work.
I don't know whether it is a robust solution,but I'll try it later anyway.

Thanks for sharing experience.

[epinault]

Does Slack support EmoteMessage,EnterMessage,LeaveMessage,TopicMessage?

Also , @svmaris are you saying that this more of a hubot problem than slack then? or Slack is passing the wrong Type of message?

[epinault]

Also I tried to change the listener.coffee .. and I see it going further but sill some errors now

[Fri Oct 03 2014 21:53:34 GMT+0000 (UTC)] ERROR TypeError: Cannot call method 'match' of undefined
at TextListener.callback (/mnt/zubot/scripts/google-images.coffee:24:8, :20:19)
at TextListener.Listener.call (/mnt/zubot/node_modules/hubot/src/listener.coffee:27:7, :23:14)
at Robot.receive (/mnt/zubot/node_modules/hubot/src/robot.coffee:197:9, :142:33)
at Robot.receive (/mnt/zubot/node_modules/hubot/src/robot.coffee:204:7, :153:21)
at Slack.Adapter.receive (/mnt/zubot/node_modules/hubot/src/adapter.coffee:66:5, :47:25)
at /mnt/zubot/node_modules/hubot-slack/src/slack.coffee:182:26, :185:16
at callbacks (/mnt/zubot/node_modules/hubot/node_modules/express/lib/router/index.js:161:37)
at param (/mnt/zubot/node_modules/hubot/node_modules/express/lib/router/index.js:135:11)
at pass (/mnt/zubot/node_modules/hubot/node_modules/express/lib/router/index.js:142:5)
at Router._dispatch (/mnt/zubot/node_modules/hubot/node_modules/express/lib/router/index.js:170:5)
at Object.router (/mnt/zubot/node_modules/hubot/node_modules/express/lib/router/index.js:33:10)
at next (/mnt/zubot/node_modules/hubot/node_modules/express/node_modules/connect/lib/proto.js:190:15)
at multipart (/mnt/zubot/node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/multipart.js:60:27)
at /mnt/zubot/node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/bodyParser.js:57:9
at IncomingMessage. (/mnt/zubot/node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/urlencoded.js:70:11)
at IncomingMessage.emit (events.js:92:17)
at _stream_readable.js:943:16
at process._tickCallback (node.js:419:13)

Sending message
Sending message
Sending message
Sending message
Sending message
Sending message
Failed to escape HTML: TypeError: Cannot call method 'replace' of undefined
Sending message
Sending message

[epinault]

Seems that either Slack is using the wrong Message type or something is really broken :(

[nkgwj]

I tried the @svmaris's hack and It works for me.

[kevinsimper]

I just setup hubot on Heroku with Slack and it worked fine :)

[lnyarl]

I have same problem and solve. Check to see if the same two 'message.coffee' files. I had two message.coffee files in the different hubot packages.

[camflan]

Hubot on heroku is receiving messages but never responds in any slack channel.

Anyone have any ideas?

[paulhammond]

The recent v3 release of hubot-slack completely rewrites all of the code around how hubot communicates with slack, and any bugs in the old code won't be present in the new code. I hate to do this, but I'm going to close out this issue because we're not working on the old version any more. Sorry we didn't reply sooner.

We think the new adapter is much better in many ways. Try it out, and if it still doesn't work for you please feel free to open a new issue or email [email protected] so we can look into it.

[epinault]

Sounds great. Will give it a to V3