sleepw4lker / tamemycerts.rest Goto Github PK

Hello, we would like to start using cert-manager to request certificates. Is there more information available somewhere on how we should configure cert-manager?

Hi,
I just tried to compile the sln to play arround with it. unfortunatley on compile visual studio complains that the file
....\AdcsToRest\Properties\PublishProfiles\FolderProfile.pubxml is missing.

I noticed in the gitignore that this filetype is removed.
https://github.com/Sleepw4lker/AdcsToRest/blob/c53b930ec52963746db3040b1485103a3823e876/.gitignore#L187

Can you remove this line from the gitignore?

Hi,

I tried to get information for a template without having enroll permission. In this case a 500 server error is returned. It seems that the Forbid method (https://learn.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.mvc.controllerbase.forbid?view=aspnetcore-8.0) expects an authentication scheme and does not accept an error message (without special handling).

Maybe it is possible to switch the response to Unauthorized. Then the RestAPI remains clean and simple.

Kind regards
Konstantin

This is a very clean API. Good job! Just a few thoughts from my side:

1. In general it could be an idea to pass information for encodings via header, not query parameter. This could be done via Content-Type- and Accept-Headers. Maybe a custom type should be added.

2. requestAttributes:
   

   TameMyCerts.REST/TameMyCerts.REST.xml

   Line 42 in 7c13c42

   <param name="requestAttributes">

   
   As a user I've no clue which optional attributes are allowed.

3. TimeSpan:
   

   TameMyCerts.REST/TameMyCerts.REST.xml

   Line 837 in 7c13c42

   <member name="P:TameMyCerts.NetCore.Common.Models.CertificateTemplate.ValidityPeriod">

   
   In Swagger-UI this is rendered as TimeSpan. This is implementation specific. At level of API this should be a date formatted as ISO 8601 or similar.

4. What's the difference between a certificate authority certificate and it's exchange certificate?