slion / fulguris Goto Github PK

Implement pull to refresh
https://medium.com/@houdayer.corentin/how-to-use-swipe-to-refresh-swiperefreshlayout-99abd674c907

Should sorting be made optional too?
I guess not.

Ctrl + I like Icons or Information maybe?

Maybe replacing the refresh icon?

Collapsible tool bar should be implemented using MotionLayout.
That should give us more option to fine tune its behaviour.
See:
https://blog.stylingandroid.com/motionlayout-collapsing-toolbar-part-1/

During page loading we set the toolbar color too many times. Try fixing that.

Also possibly related, it looks like we have too many tabChanged call.

The following buttons should be considered:

• Back
• Forward
• Home
• New tab

Drawers should be locked in open position to make scrolling through them easier.
Also having a scroll bar would be nice.

It breaks FxTec Pro1 keyboard usage.
Moreover Fn shortcuts should not be used at app level since they are typically reserved for system level features.
Should we keep the feature and use Ctrl instead?

Whenever navigation tool bar is hidden back button should first bring it up before going back in tab history.
The side effect would be that you need to hit back twice to go back whenever the tool bar is hidden. Still, I think that makes a lot of sense.
Just rellying on scroll up to show to hidden tool bar is annoying.
Having a translucent floating button was also considered.

So that it is easier to open HTML files with it from a file explorer.

It's a mess right now.

Restarting the app fixed the issue.
Consider disabling long back button press feature

Since tabs can now be closed using swipe. Maybe make this optional?

Have a settings option to open a new tab whenever a search is triggered from the tool bar. Have another similar one for when a URL is type in the tool bar.

Have a splash screen that leads to onboarding wizard if needed.
Use a user preference to store the version that was last running to check if a new version was just started.

Onboarding wizard should at least ask user for Google Analytics and crash report permission.
See: https://stackoverflow.com/questions/37686993/firebase-user-opt-out-of-analytics
https://stackoverflow.com/questions/52063465/disable-firebase-crashlytics-for-android/52064284

Tabs list is currently ordered by tab creation date.
We also need a recent tabs list that would be used to Ctrl + Tab.

See:
https://stackoverflow.com/questions/39953784/android-how-do-you-change-the-webview-scrollbar-color

Also pull-to-refresh is acting up with frames. What we should really do is disable it unless the page is scrollable vertically.
Try it in landscape on the GitHub project page for instance.

Ctrl + T maybe?

Those blue texts in the dark theme are terrible.

When on a webpage editing a text field in portrait mode and opening the tab list drawer the virtual keyboard remains on the screen. Also the text cursor is visible through the drawer.

Right now it is darker than the applied color. Most certainly because it has some translucent background. It should be fully transparent.
Also color of the icons should be adjusted according to background color.

In portrait, when tapping inside a text field with multiple lines of text to position the cursor, the webview sometimes scrolls to move the cursor below the virtual eyboard.

I could not reproduce that issue using DuckDuckGo so I'm assuming there is something wrong in our layout or handling of the webview so that it does not rightly understand where it is on the screen, at least in respect to virtual keyboard.

This was easily reproducible on Fxtec community forums.

Going back on a tab without history closes said tab and switches to the last tab in our tab list. Instead it should switch to the most recent tab.

Possibly a regression introduced by some od our theme changes.

Dark favicons are not very visible when using dark theme. Consider using color filter for those after checking that favicon palette primary color luminance.

Maybe change the current 'hide status bar' options into a 'status bar mode' selection with the following choices:

• Always on
• Always off
• Sync with tool bar

Also consider offering that mod where the status bar is transparent and hides automatically.

Both address bar and horizontal tab bar should then be moved to the bottom.
Upside down pop-up menu variant will be needed.
Tab drawer tool bar should also be moved to the bottom.

Right now it looks like when opening amazon it takes me to the amazon app without asking.

See maybe startActivityForUrl or isSpecializedHandlerAvailable

Implement a way to search through your tabs list titles and URLs à la Vivaldi.

This could be done by having a new search realm. We currently search, history, suggestions and bookmarks. We ought to add open tabs.

Have a deleted tab list thus allowing users to fetch back deleted tabs.
Such list should be accessible or even part of the main tab list.
Maybe have them at the bottom of the tab list with a different background color.

Instead of hardcoded ones.
Possibly with multiple profiles. Like Fxtec and BB profiles for instance.

Restarting app from Android Studio while it is in the foreground is causing us to loose all tabs.

Have settings option to open new tab next to current rather than at the end of the tab list.

Tabs states are not backed up when a restrat is trigger following a change of theme in settings.

Step to reproduce:

• Use in portrait
• Switch to other app
• Rotate to landscape
• Switch back to Fulguris

That's also happening when just starting in lanscape.
This is an issue for browser activity and tab list drawer.
What about bookmarks drawer?

Certainly a side effect of having locked our drawers closed. I wonder if it would work by simply locking them open upon opening them?

Dark theme should use color mode as color mode itself can be disabled in the settings.