sllvn / deglassified Goto Github PK

This is problematic, because the 'popupclose' event will call a state change, resulting in two back-to-back state changes. Furthermore, the state change from 'popupclose' uses an out of date $rootScope.currentLocation, because the controller from the freshly loaded state has not had a chance to set the new $rootScope.currentLocation.

To prevent this, we have to do two unideal things:

1. Use $rootScope instead of $scope.currentLocation, as we need to allow the Mapbox service access to the property.

2. AND, in loadLocation() in app.js, we have to set the $rootScope.currentLocation to the location we are about to change to, before making the new state change.

Long sidebar screws up scrolling (see http://www.deglassified.com/san-francisco)

• Dynamically size mini-map container height.
• Figure out how users will confirm correct business location.
  • Put confirmation button inside marker popup?
  • Put confirmation button below map?
  • Fix location button that will focus cursor back to address input?
• Decide what behavior for user upon successful business addition.
  • Alert box pop-up confirming addition?

Some businesses have softer restrictions on Glass, ie, must have camera covered, not allowed to film, etc., and do not ban Glass outright.

I'm thinking different colored markers + tags in the sidebar.

Add stateful routing so that:

• Changing the city should update the URL (/seattle)
• Clicking a popup should update the URL (/seattle/5-point-cafe)
• The API will generate slugs, store them in db, and return them through API (in /api/locations and /api/locations/1/businesses)

Create documentation for API in README

• Have code review to determine current approach is actually optimal

Nothing should be served via the asset pipeline, and we then we can add the rails-api gem (https://github.com/rails-api/rails-api) for a faster API

https://madmimi.github.io/angular-foundation/

Don't make assumptions about the order of address_components. Look at the types (city = "locality" and state = "administrative_area_level_1") and determine type of address_components from those.

Ie, San Francisco location should load Oakland markers, even though Oakland is a separate location

Try querying with 'dallas'. Response returns null.

• Update minimap popup if user accepts formatted address
• Prevent users from advancing to page 2 of add business wizard, if page 1's form is invalid
• Replace select2 ajax with $http call and initialize select2 in the callback
• Change select2 no matches text to mention ability to add new location
• Do a geocoding check for legit location after being created in select2

When POSTing to '/api/users/sign_in', if a login fails due to bad email/password, a 401 error code is returned, along with the typical response.auth object.

When POSTing to '/api/users/' for a user registration, if it fails due to mismatched passwords, too short password, etc., no error code is returned, so the post is seen as 'successful'.

This issue causes inconsistency and not easily understood code when handling the request errors.

Would be nice if failed POSTs to '/api/users/' also returned an error code, so that $http's .error() would trigger instead of .success().

Adding another /seattle/mcdonalds/ will result in /seattle/mcdonalds-97c08279-3e0b-46ea-8f16-710aeaecbf51. Should result in /seattle/mcdonalds-2/ or something else.

Because Geocod.io is unreliable and often has issues geocoding vague addresses

Should attempt to detect user's location and load the closest location, rather than default to Seattle

https://github.com/gonzalo-bulnes/simple_token_authentication