tokio-modbus 0.12 entering unreachable code in any response error about tokio-modbus

[uklotzde]

Due to this serious panic issue I have decided to yank v0.12.0. Not recommended for production use.

[uklotzde]

I'll prepare a proposal.

[uklotzde]

@creberust Any ideas how to handle those cases?

We probably need to add a new error variant that allows clients to take care of handling those errors.

[uklotzde]

#248 (comment)

Looks like some paths are marked as unreachable, although they could be reached if a server sends an invalid/unexpected response.

[creberust]

Hi,

We can remove the unreachable! parts, but we need to add an Error variant, or return an io::Error ?

I think we can return an std::io::Error with ErrorKind::InvalidData in case of Request/Response mismatch. I don't know how you handled it before ?

Would it be simple for you @gustavowd to handle the Error with this ?

[uklotzde]

Please review and test #254 thoroughly! ...because I would like to avoid another breaking change.

[gustavowd]

Hi,

We can remove the unreachable! parts, but we need to add an Error variant, or return an io::Error ?

I think we can return an std::io::Error with ErrorKind::InvalidData in case of Request/Response mismatch. I don't know how you handled it before ?

Would it be simple for you @gustavowd to handle the Error with this ?

I beleive that @uklotzde proposal solves the issue. Yes, it is simple to handle the error with a returning error.