Comments (7)
Due to this serious panic issue I have decided to yank v0.12.0. Not recommended for production use.
from tokio-modbus.
I'll prepare a proposal.
from tokio-modbus.
@creberust Any ideas how to handle those cases?
We probably need to add a new error variant that allows clients to take care of handling those errors.
from tokio-modbus.
Looks like some paths are marked as unreachable, although they could be reached if a server sends an invalid/unexpected response.
from tokio-modbus.
Hi,
We can remove the unreachable!
parts, but we need to add an Error
variant, or return an io::Error
?
I think we can return an std::io::Error
with ErrorKind::InvalidData
in case of Request
/Response
mismatch. I don't know how you handled it before ?
Would it be simple for you @gustavowd to handle the Error
with this ?
from tokio-modbus.
Please review and test #254 thoroughly! ...because I would like to avoid another breaking change.
from tokio-modbus.
Hi,
We can remove the
unreachable!
parts, but we need to add anError
variant, or return anio::Error
?I think we can return an
std::io::Error
withErrorKind::InvalidData
in case ofRequest
/Response
mismatch. I don't know how you handled it before ?Would it be simple for you @gustavowd to handle the
Error
with this ?
I beleive that @uklotzde proposal solves the issue. Yes, it is simple to handle the error with a returning error.
from tokio-modbus.
Related Issues (20)
- write_multiple_registers taking array as a param HOT 3
- Can not disconnect slave, need help HOT 3
- Although disconnect the context, the SerialStream reopen error HOT 1
- Patterns/best practice for reconnect-after-failure? HOT 1
- How to turn 'tokio_serial::SerialStream' into global static to save it for reuse
- is_connected()? HOT 1
- Modbus RTU - Serial Direction Pin HOT 6
- Dev Dependencies: Upgrade rustls-pemfile and tokio-rustls HOT 4
- Return Modbus exception codes for client and server.
- Use `async-trait` in `Service` trait ? HOT 10
- Dev Dependencies: Upgrade rustls
- How to get hexadecimal modbus rtu message data HOT 2
- Panic on unreachable code on disconnect HOT 3
- SECS/GEM SEMI? HOT 2
- Cant ignore Modbus RTU Request HOT 3
- Is it possible change trait Service to be a async trait? HOT 9
- rtu-server-address hangs HOT 1
- Cannot obtain custom Exception code
- Breaking change with addition of `FunctionCode::ReportServerId` in a SemVer-compatible version HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tokio-modbus.