Reponse to WriteSingleCoil is malformed about tokio-modbus

[thosaa]

I think I have sorted out now. I am not able to test it, however.
I have checked the master branch out, made the changes and it builds.
When I try to reference to it from my own project it states:

error[E0433]: failed to resolve: could not find `Server` in `tcp`
  --> src/main.rs:22:14
   |
22 |         tcp::Server::new(socket_addr).serve(|| Ok(modbus::MbServer));
   |              ^^^^^^ could not find `Server` in `tcp`

This is the dependency in Cargo.toml:

tokio-modbus = { version = "0.3.5", default-features = false, features = ["tcp"] }

This is the path override just below:

[patch.crates-io]
tokio-modbus = { path = "../tokio-modbus" }

I would like to test before making a pull request. Any help is appreciated, thanks.

/Thomas

[flosse]

@thosaa thanks for reporting this bug and fixing it.

[thosaa]

You're welcome. :-)

I cannot see what has changed since tag v0.3.5 to now, since I cannot run my code with the newest version:
I have now set my dep to:

tokio-modbus = { version = "0.3.5", default-features = false, features = ["tcp", "server"] }

and the same patch.crates-io as before.

I now get this error:

23 |         tcp::Server::new(socket_addr).serve(|| Ok(modbus::MbServer));
   |                                       ^^^^^ the trait `tokio_modbus::server::service::Service` is not implemented for `modbus::MbServer`

And this is the way I call it:

    let _server = thread::spawn(move || {
        tcp::Server::new(socket_addr).serve(|| Ok(modbus::MbServer));
    });

[flosse]

bug fixed with 8284940

[flosse]

@thosaa I'll have a look at your questions at the weekend.