patient read api does not return 404 error about client-js

[BS062721]

CC : @vlad-ignatov

[BS062721]

@vlad-ignatov do you have any information on this?

[vlad-ignatov]

As far as I can tell, the only reason is that this is trying to be a higher level abstraction of those requests. Instead of returning responses and response codes, it resolves with data object or rejects with error message. If your promise chain is rejected you get an error message and the "on success code" will not be executed anyway.

This seems to work well enough for everybody, unless you have some very specific way of consuming the response results. Can you specify what "returning proper error code" means in your case? Perhaps an example of what you are trying to do would help.

[BS062721]

@vlad-ignatov we are consuming different APIs (patient and encounter) using FHIR client, and based on different error scenarios we have different workflows, not able to get proper error response in this particular scenario kind of disrupt the workflow

[vlad-ignatov]

I understand that, but it would help if you can define "proper error response".

[SA030800]

To add on @BS062721 comment, since an error status is not returned along with the error message we wouldn't know it fails because of some server error(500) or because we are providing invalid data(400) or the resource is not found(404) etc. so we are unable to give a proper error message to the end user.

Example if the status is 500 we would give them an error message explaining it is a server error with an option to retry again. if it was a 404 error we will give them an error message explaining the resource is not found.

On another note: the search api's seems to return an error with error status it is just the read api which is not returning the error status

[vlad-ignatov]

I agree that this needs to be fixed. The hard part though, is to figure out how to do that without breaking existing apps too much.

Looking at the code, I can see that a request promise can be rejected with different arguments - string messages, error instances, jQuery XHR objects... It would be nice if we could unify this and always return an object with the same shape.

What are the exact properties that you expect to find in an object, representing a failed response?

[BS062721]

for all other scenarios we are getting error response status property which gives us the proper error code for given scenario.

for example something like error.status = 400 then we parse error response based on code

[vlad-ignatov]

This was an issue with the older version of the client and its integration with fhir.js. We have new versions now, and they should reject with HttpError in such cases.

I am closing this now, but feel free to open new one if you have issues with the newer versions.