Comments (3)
Yes, that will be possible! This is still a work in in progress, thus not documented yet but I pushed some changes so that you can give it a try. The idea is that polyfilling should be automatic and all you need to do is change the "browserlist" here and run npm run build
(and do not commit those changes off course). The code is still changing so we shouldn't talk in numbers before the release, but just for reference, when I tried that yesterday with "browserlist": [ "last 2 Chrome versions" ]
, the production build was 25.2K (or 8.7K with gzip)!
This project will be stuck with IE10 for a while (until the US healthcare upgrades every PC and then EHR vendors embed something newer in their EHRs). This could take another 5 years! The worst part is that this restriction also applies to the SMART App developers if they want to deploy their apps to those EHRs... That said, you are probably one of the few lucky developers out there! I hope you can understand why we do not intend to ship a "pure/modern" bundle at this point (but we will have the "browser list" feature documented).
from client-js.
👍 sounds good. I would add that when you make those changes to the project, it would be preferred to not have to clone + build from source in order to get a version without core-js in it. Browserslist and @babel/preset-env are usually not run on any projects within node_modules, since babel-loader discourages compilation of node_modules (rollup-plugin-babel, too). So I don't think it will be as easy as just npm installing the lib and then applying your browserslist to it -- the files you publish to npm will have to choose a browsers list of their own to support, that is different from the browserslist of your consumers.
So a separate file in the published npm directories would be amazing, along with a lowest-common-denominator browserslist that is used to build the published files.
from client-js.
OK, I think I see where the confusion is coming from. This is just a global library that should be included via script tag. It cannot be imported or required (except on the back-end).
However, you are not the only one to assume that it should be usable as a module. There is certain demand for that, so I'm trying to make it. As you might imagine, that changes a lot so I'm not sure if we can do it for v2.0.
from client-js.
Related Issues (20)
- Client request pre-pends accept header when provided in options HOT 6
- Support for CryptoKey objects as private keys HOT 6
- 502 Gateway Error on codesandbox HOT 2
- Failing in web client projects due to NodeJS usage without polyfills. HOT 13
- Support for browser using multiple SMART clients at once. HOT 3
- Unable to authorize using PKCE HOT 2
- Typo in README
- Unable to get patientId after successful login HOT 1
- (Error handling skipped on init) CompleteAuth not triggered for init HOT 1
- includeResponse not working for FHIR update operations
- "target: popup" (etc) demos don't work in current Chromium HOT 2
- Single SMART_KEY breaks authorization of several users on server-side
- Jest + RTL :: Testing with FHIRClient
- Uncaught (in promise) Error: Failed to fetch the conformance statement from "https://staging-fhir.ecwcloud.com/fhir/r4/FFBJCD/metadata". TypeError: Network request failed HOT 6
- Question: Smart-On-Fhir implementation inside Service Worker
- FHIR type Meta requiring lastUpdated property when spec allows it to be optional
- Node js After 10 min 401 unauthorized response HOT 4
- Window closes itself when it's not actually a popup
- Save token info in DB
- Support of PKCE even when the EHR .well-known configuration is not set? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client-js.