smelukov / estel-estree-builder Goto Github PK

I noticed that the generated interfaces you have don't properly set the type field. The DefinitelyTyped repo goes out of its way to do let the user make runtime checks on such things, but here every single node has its type listed as string. Is this intentional?

Have you had a chance to think about expressing 'base' types as discriminated unions rather than just the straight inheritance model? So for example:

type Expression = EmptyExpression | ArrowFunctionExpression | ...

This would make it amazing for using the types for working with ASTs.

The basic task of working out the relationships shouldn't be too tricky, using interface extensions. But working out which types to express as a union seems like a hard problem. For example, no one is creating a raw Node instance, so that would be fine to express as a union type, but 'middle tier' types might be a bit trickier.

The other piece to it is that any type that is part of a union, needs to define their type parameter as a the explicit type name string, not just of type 'string'. For example,

export interface ReturnStatement {
    type: "ReturnStatement",
    argument?: Expression,
    loc?: SourceLocation,
}

Hey there,

Just wondering if you would consider a PR to make the generated interfaces in the ts output to be exported.