smerkousdavid / netpile Goto Github PK

I looked over the current code, and I have some comments

1. your server needs to store every one who connects. when i do TCP servers, i create an client class, which contains a socket. then, in the server class, i have an array list, and a thread that constantly checks for incoming connections. when a connection is found, it adds a new client to the arraylist. now, you can send messages
2. why does the server need a username and password? passwords are unneccasary unless we want to have a large database which is constantly running, which means we need to have a remote server
3. if you do want to have passwords, dont fill it up until 16 with ! and *. fill it up with null terminator strings or spaces.
4. we need to add support for all distros of linux, not just ubuntu
5. NEVER put 'throws Exeception' or 'throws Throwable' only throw from methods and classes specific exceptions. that is incredibly bad practice. i can explain to you later why it is.
6. instead of trying to create your own serializer, use java.lang.Serializable. it does all the work for you. that might be why your streams aren't serializiing as intended.
7. where is the server intended to be run? is it going to be a remote database, or is the client going to have to use it? if its the latter, i think we should just do a direct client-client system for ease of access
8. please use static sometimes. some stuff can be declared static to save memory

it isn't the encryption. its the compiler. we need to specify every single class and dependency for the compiler, plus the directory its all located in. we simply can't get all that info from the user. so maybe, instead of compiling it in the program, the user can supply an already compiled jar file to send out to everyone. we can have command parameters (like netpile -send blah.java)

what i think we should do, is write it in java, and then write a c program for the command line which executes the java. that way, people can script it in bash or batch or whatever they want to do