smol-rs / async-net Goto Github PK

We should copy the API from the standard library (still an unstable feature at the time of writing this):

rust-lang/rust#42839

Types like Async<TcpListener> provide an into_inner() method to return the TcpListener, but async_net::TcpListener (AKA smol::net::TcpListener) does not expose that.

Mild testing on my own part indicated that the MSRV for this crate is 1.40.0 on Ubuntu 20.04 LTS. It would be nice if there were a badge on the README indicating this.

Right now we use blocking to run getaddrinfo, on a threadpool, but we can do better. I created async-dns as a way of doing DNS asynchronously. It needs improvements in robustness and optimization, but it usually works.

Another option would be trust-dns.

I'd like to have a TcpSocket implementation like in Tokio (I don't really want to depend on the Tokio runtime just for this feature). I know that there are workarounds, but an async-first, easy to use implementation would be really appreciated.

I just grep'd through the source code and it looks like the fastrand dependency isn't being used anywhere. Its usage was probably removed in this commit. Should we take it out of Cargo.toml?

I would like to understand if there a particular reason why the API for async_net::TcpStream does not mirror the API provided by std::TcpStream or Async by not implementing the AsyncRead and AsyncRead for shared references. I suppose I could still do this by using the Into<Arc<Async<TcpStream>>> implementation and using the implementations on that.