sniklaus / bookmark-tab Goto Github PK

This is how it displays https://i.imgur.com/VczlkRn.png but the blue buttons don't do anything.

It works fine on a separate Firefox ESR 45.3.0 install however.

Hello !

That addon is very nice. I would to know how increase the popup window when I click on the button as well as the number of columns.

Thank you :)

This is nitpicky on my part.

I use an addon called vimperator. One of its features is it highlights all the links on a page and assigns them numbers so I can click links by typing their numbers instead of using the mouse.

bookmark-tab appears to use divs with click events on its node containers for folders. vimperator is not identifying these as clickable so I don't get a number for them. Swapping out the div for an anchor tag makes things happy.

In the addon currently release, all that meant was changing

var jqNode = jQuery('<div></div>')

into

var jqNode = jQuery('<a></a>')

in coderectTree.js's createNode. I was planning on making a PR here, but it looks like the code has changed significantly so I'm just making an issue instead.

Sorry for writing this in that place, but I can't send feedback by "pull requests" for some reason. I have a suggestion. This is possible to add an option that allow show bookmarks in a visual view? Something like in this addon for Chrome - https://chrome.google.com/webstore/detail/dewey-bookmarks/aahpfefkmihhdabllidnlipghcjgpkdm or like in raindrop.io (but simpler).

Seems like the addon takes some time to load when firefox starts up and hence causes this error. Once I wait for a second and refresh the page it works.

Thank you very much for your great work.

However, firefox will only allow WebExtensions from version 57+. As your extension is not a web extension it will cease to work starting from version 57.

I know you have a busy life and may not have time, but if you (or someone else) do, please consider porting this to the WebExtension API. It is possible to override the new tab page and access the bookmarks within the WebExtension API, so I would say a port is technically possible.

Once again, thanks for the hard work!

This addon is simple and very cool!!!

I found difference from Firefox's bookmark.
If registered empty title, Firefox display the URL. But this is not the case.

For example:
https://github.com/CodeRect/bookmark-tab/blob/master/index.js#L198

-                               'strTitle': PlacesUtils.bookmarks.getItemTitle(intIdent),
+                               'strTitle': PlacesUtils.bookmarks.getItemTitle(intIdent) || PlacesUtils.bookmarks.getBookmarkURI(intIdent).spec,

(Sorry. I have not tried this. I could not build the addon on Linux.)