Recommend not to use PS Prefix, it is reserved about servicenow-powershell

[Sam-Martin]

Hi @JustinGrote,
Interesting! Fortunately it's just the module name and file names, rather than the variables and cmdlets, so it shouldn't be too big a change.
Unfortunately I haven't got access to a ServiceNow installation to test this against any more, and don't want to rely solely on the unit tests.
If you're using this module, are you up for submitting a tested PR to rename instances of PS* with POSH* by any chance?

Many thanks,

Sam

[JustinGrote]

I'm not using the module, I was just searching around looking for good
powershell REST API usage examples and how other people are doing it. :)

On Fri, May 6, 2016, 1:45 AM Sam Martin [email protected] wrote:

Hi @JustinGrote https://github.com/JustinGrote,
Interesting! Fortunately it's just the module name and file names, rather
than the variables and cmdlets, so it shouldn't be too big a change.

Unfortunately I haven't got access to a ServiceNow installation to test
this against any more, and don't want to rely solely on the unit tests.

If you're using this module, are you up for submitting a tested PR to
rename instances of PS* with POSH* by any chance?

Many thanks,

Sam

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1 (comment)

[Sam-Martin]

Ah cool, well don't look at this one! It's hardly a paragon of best practice :)
Thanks for letting me know though, I'll keep this issue open in case anyone comes through and feels inclined to fix it!

[Rick-2CA]

Module rename was completed with PR #21 as discussed in Issue #17.