soal / gnome-shell-fullscreen-hot-corner Goto Github PK

Totally Broken in Ubuntu 19.10 gnome 3.34 end brokes hot corner too, please update
Thanks for this fantastic addon

The hot corner stops working.It doesn't bring up overview nor it does that ripple animation. Clicking on it works though.

GNOME 42 is scheduled to be released this week, it would be great if this extension could also support it.
Thanks!

When installed and activated this extension prevents the panel to appear after the desktop is unlocked - leaving the user with an empty desktop - at least when using the "Dash to Panel" extension. This was experienced with Ubuntu 21.04 with gnome 3.38.5.

the following code fixes this problem:

function _toggleOverview() {
    // adopted from original Gnome Shell code but with fullscreen check removed
    // location: /js/ui/layout.js:1227
    if (!Main.overview.visible)
        return;
    
    if (Main.overview.shouldToggleByCornerOrButton()) {
        Main.overview.toggle();
        if (Main.overview.animationInProgress)
            this._ripples.playAnimation(this._x, this._y);
    }
}

[email protected]

Hi! Nice extension. I was wondering if it can enable other hot corners (like when the extension Customcorner is in use)? I've a wacom tablet and when I enable your extension and make a window fullscreen, only the top-left corner react on touch input, the bottom left (I've set it to show the desktop) works with both touch and pen input, but the top right (set to show overview) doesn't react nor to touch nor to pen input. A bit weird i know but perhaps you can help? Thanks!

Since Gnome is moving to ECMAScript modules one may safely assume that a version metadata update wont be enough.

Are there plans to port to ESM?

Porting guide:
https://gjs.guide/extensions/upgrading/gnome-shell-45.html#esm

After upgrading to GNOME 3.32, the extension fails with the following error:

TypeError: this._construct is not a function

I looked at the diff between js/ui/layout.js in gnome-shell 43 vs 44, and it looks like none of the changes should break this extension.

I haven't yet tried out updating the metadata and enabling this extension on GNOME 44 because restarting gnome-shell is a big pain in Wayland sessions, and I'm in the middle of a movie (which is how I realized that this extension stopped working).