Comments (5)
null
values will probably either not work, or throw NullPointerException
throughout sttp and other Scala libraries, as null
is very rarely used (if at all) when writing Scala code. Alternatively, you can use an Option
, which is very commonly used. So, your example would become basicRequest.header("name", map.get("field"))
from sttp.
@adamw thanks for the reply. it makes sense most scala libs use Option
instead of risking having NPE.
Occasionally we use java class in scala and some outdated conventions may introduce null
.
Our case was we get the http request header from log4j ThreadContext.get("correlction-id") , which returns null
if missing.
Do you think it's the library caller's responsibility to check the null or is should be done in the library?
from sttp.
I very rarely see any questions / bug reports concerning null
s, so I think if you're interfacing with Java it's mainly the responsiblity of the wrapper layer - in this case, that would be in your app. You can always do Option(ThreadContext.get(...))
which correctly handles null
results
from sttp.
sound good, thanks for the answers.
from sttp.
No problem, I'll close this then :)
from sttp.
Related Issues (20)
- Add support for play-json 3 HOT 1
- Update to Prometheus 1.x.x HOT 3
- [BUG] HEAD request times out using Http4s backend HOT 2
- Http proxy problem with async-http-client-backend-zio:3.9.1
- Uri interpolation incorrectly percent-encodes some characters HOT 2
- where is basicRequest? HOT 1
- AbstractFetchBackend does not support manual cancellation/interruption
- Expose AsyncHttpClient when creating AsyncHttpClientBackend HOT 2
- Preserve request-metadata in SttpBackendStub HOT 2
- Integrate oauth? HOT 16
- add support Tethys json HOT 2
- Add Scala 3 support for play-json HOT 4
- quickRequest: Unexpected behaviour dependent on method order HOT 4
- Refactor metrics names according to standards
- Metrics caching rework
- No json4s release for scala 3 HOT 4
- Add Ox integration: SSE & WebSockets? HOT 2
- Spray json support for scala 3 HOT 3
- enable logback logging for sttp 1.7.x HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sttp.