If you move a blade from a chassis to another chassis, we need to decomission the old one and update the new location

See #141

Working with the beta, the interfaces types changed.. So that is some that needs to be fixed. Not sure what else is broken.

Right if the device_type or device_role doesn't exists, it doesn't throw an obvious error, we should fix it..

At some point, Netbox versions will depreciate or change some behavior.
The project has been developed with Netbox 2.6

One way to change the behavior depending of the version will be to match the HTTP header API-Version:

➜  ~ curl -i https://netbox.company.com/api/
HTTP/1.1 200 OK
Server: nginx
Date: Thu, 29 Aug 2019 15:58:27 GMT
Content-Type: application/json
Content-Length: 325
Connection: keep-alive
Vary: Accept, Cookie, Origin
Allow: GET, HEAD, OPTIONS
API-Version: 2.6
X-Frame-Options: SAMEORIGIN
P3P: CP="ALL DSP COR PSAa PSDa OUR NOR ONL UNI COM NAV"

A server can see its attributes change over the time, it's a normal lifecycle

A few examples are:

• It can move from a rack to another rack or from a chassis to another one
• new hostname
• have a new NIC cards, remove old ones
• change IPs on current cards
• have more RAM, more disk (see #8)

Have a bailout now with the right lshw version.:

I attached the last lsow output as file

Traceback (most recent call last):
File "/usr/local/bin/netbox_agent", line 11, in
load_entry_point('netbox-agent==0.5.1.dev3+gbb7c8c8.d20200216', 'console_scripts', 'netbox_agent')()
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/cli.py", line 40, in main
return run(config)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/cli.py", line 35, in run
server.netbox_update(config)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/server.py", line 336, in netbox_update
self.inventory = Inventory(server=self)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/inventory.py", line 56, in init
self.lshw = LSHW()
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/lshw.py", line 48, in init
self.find_cpus(j)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/lshw.py", line 107, in find_cpus
c["product"] = obj["product"]
KeyError: 'product'

Hi

Running on virtualbox.

Traceback (most recent call last): File "/usr/local/bin/netbox_agent", line 11, in <module> sys.exit(main()) File "/usr/local/lib/python3.6/dist-packages/netbox_agent/cli.py", line 44, in main return run(config) File "/usr/local/lib/python3.6/dist-packages/netbox_agent/cli.py", line 39, in run server.netbox_create_or_update(config) File "/usr/local/lib/python3.6/dist-packages/netbox_agent/virtualmachine.py", line 76, in netbox_create_or_update self.network.create_or_update_netbox_network_cards() File "/usr/local/lib/python3.6/dist-packages/netbox_agent/network.py", line 399, in create_or_update_netbox_network_cards interface = self.create_netbox_nic(nic) File "/usr/local/lib/python3.6/dist-packages/netbox_agent/network.py", line 246, in create_netbox_nic type = self.get_netbox_type_for_nic(nic) File "/usr/local/lib/python3.6/dist-packages/netbox_agent/network.py", line 162, in get_netbox_type_for_nic return self.dcim_choices['interface:type']['Virtual'] KeyError: 'interface:type'

Hiya there,

Trying to run this, it causes an error due to the _choices being removed in Netbox v2.8.0, as listed here
netbox-community/netbox#3416

So currently when updating I see the error *api/dcim/_choices/ could not be found.

Can we update to use the new OPTIONS method?

I guess we want to watch everything in netbox_agent/ and tests/.

Traceback (most recent call last):
File "/usr/local/bin/netbox_agent", line 11, in
sys.exit(main())
File "/usr/local/lib/python3.5/dist-packages/netbox_agent/cli.py", line 44, in main
return run(config)
File "/usr/local/lib/python3.5/dist-packages/netbox_agent/cli.py", line 36, in run
server.print_debug()
File "/usr/local/lib/python3.5/dist-packages/netbox_agent/server.py", line 299, in print_debug
print('Netbox Rack:', self.get_netbox_rack())
File "/usr/local/lib/python3.5/dist-packages/netbox_agent/server.py", line 91, in get_netbox_rack
site_id=self.get_netbox_datacenter().id,

please advise whats wrong here.
he finds out datacetner correctly
and the rack as well.

The project uses the Python netifaces library
Right now we use netifaces like this:

netifaces.ifaddresses(interface).get(netifaces.AF_INET)

We also need to query netifaces.AF_INET6 to get IPv6 addresses
It should work out of the box for Netbox as it handles IPv4 and IPv6 the same way in the API

Netbox has the ability to flag an IP as Primary address for a Device

Since it's tied to the user workflow, I'd say we could enable this guess with a config argument and use the following workflow

• parse the route table
• find the source ip of the default route
• flag this IP as Primary adresss

For those that always want their Netbox 100% up-to-date, a cron-mode could be provided so that every agent fills in a last update date while another mechanism on the Netbox-side would be in charge of removing expired resources.

Got several different Supermicro's, here's some dmi information:

This is a Fat twin (4u, 8 nodes)

it's missing the slot information... not filled in; so we've been setting part of the hostname to chassis slot ie, the hostname is row-rack-chassis-node aka 'd8-r13-c1-n1' - row d8, rack 13, chassis 1, node 1

I also prefer to use the base board for the blade type, not the system information product name. allows me to keep the chassis separate from the blades.

System Information
	Manufacturer: Supermicro
	Product Name: SYS-F618R2-RTPT+
	Version: 0123456789
	Serial Number: S16604645724353
	UUID: 00000000-0000-0000-0000-0cc47a59ec4a
	Wake-up Type: Power Switch
	SKU Number: To be filled by O.E.M.
	Family: To be filled by O.E.M.

Handle 0x0002, DMI type 2, 15 bytes
Base Board Information
	Manufacturer: Supermicro
	Product Name: X10DRFR-NT
	Version: 1.10
	Serial Number: VM155S027997
	Asset Tag: To be filled by O.E.M.
	Features:
		Board is a hosting board
		Board is replaceable
	Location In Chassis: To be filled by O.E.M.
	Chassis Handle: 0x0003
	Type: Motherboard
	Contained Object Handles: 0

Handle 0x0003, DMI type 3, 25 bytes
Chassis Information
	Manufacturer: Supermicro
	Type: Other
	Lock: Not Present
	Version: 0123456789
	Serial Number: CF418AE16N30163
	Asset Tag: To Be Filled By O.E.M.
	Boot-up State: Safe
	Power Supply State: Safe
	Thermal State: Safe
	Security Status: None
	OEM Information: 0x00000000
	Height: Unspecified
	Number Of Power Cords: 1
	Contained Elements: 1
		<OUT OF SPEC> (0)
	SKU Number: To be filled by O.E.M.

Power DMI; there is actually 4 power supplies in this chassis, but
two are for 4 nodes, and the other 2 are for a different node.

System Power Supply
        Power Unit Group: 1
        Location: PSU1
        Name: PWS-1K62P-1R
        Manufacturer: SUPERMICRO
        Serial Number: P1K65CF11CT1837
        Asset Tag: N/A
        Model Part Number: PWS-1K62P-1R
        Revision: 1.3
        Max Power Capacity: 1620 W
        Status: Present, OK
        Type: Switching
        Input Voltage Range Switching: Auto-switch
        Plugged: Yes
        Hot Replaceable: No
        Input Voltage Probe Handle: 0x004A
        Cooling Device Handle: 0x004C
        Input Current Probe Handle: 0x004D

Handle 0x004F, DMI type 39, 22 bytes
System Power Supply
        Power Unit Group: 2
        Location: PSU2
        Name: PWS-1K62P-1R
        Manufacturer: SUPERMICRO
        Serial Number: P1K65CF11CT1838
        Asset Tag: N/A
        Model Part Number: PWS-1K62P-1R
        Revision: 1.3
        Max Power Capacity: 1620 W
        Status: Present, OK
        Type: Switching
        Input Voltage Range Switching: Auto-switch
        Plugged: Yes
        Hot Replaceable: No

A big twin (2u, 4 node chassis/server)

System Information
	Manufacturer: Supermicro
	Product Name: SYS-2028BT-HNC0R+
	Version: 0123456789
	Serial Number: S262328X8404031
	UUID: 00000000-0000-0000-0000-AC1F6B568514
	Wake-up Type: Power Switch
	SKU Number: Default string
	Family: Default string

Handle 0x0002, DMI type 2, 15 bytes
Base Board Information
	Manufacturer: Supermicro
	Product Name: X10DRT-B+
	Version: 1.01
	Serial Number: HM182S007228
	Asset Tag: Default string
	Features:
		Board is a hosting board
		Board is replaceable
	Location In Chassis: Default string
	Chassis Handle: 0x0003
	Type: Motherboard
	Contained Object Handles: 0

Handle 0x0003, DMI type 3, 22 bytes
Chassis Information
	Manufacturer: Supermicro
	Type: Other
	Lock: Not Present
	Version: 0123456789
	Serial Number: C217BAG43A10386
	Asset Tag: Default string
	Boot-up State: Safe
	Power Supply State: Safe
	Thermal State: Safe
	Security Status: None
	OEM Information: 0x00000000
	Height: Unspecified
	Number Of Power Cords: 1
	Contained Elements: 0
	SKU Number: Default string

and the power from them:

Handle 0x0016, DMI type 39, 22 bytes
System Power Supply
        Power Unit Group: 1
        Location: PSU1
        Name: PWS-2K22A-1R
        Manufacturer: SUPERMICRO
        Serial Number: P2K22CH52JT1112
        Asset Tag: N/A
        Model Part Number: PWS-2K22A-1R
        Revision: 1.3
        Max Power Capacity: 2200 W
        Status: Present, OK
        Type: Switching
        Input Voltage Range Switching: Auto-switch
        Plugged: Yes
        Hot Replaceable: Yes

Handle 0x0017, DMI type 39, 22 bytes
System Power Supply
        Power Unit Group: 2
        Location: PSU2
        Name: PWS-2K22A-1R
        Manufacturer: SUPERMICRO
        Serial Number: P2K22CH52JT1111
        Asset Tag: N/A
        Model Part Number: PWS-2K22A-1R
        Revision: 1.3
        Max Power Capacity: 2200 W
        Status: Present, OK
        Type: Switching
        Input Voltage Range Switching: Auto-switch
        Plugged: Yes
        Hot Replaceable: Yes

See Netbox's issue

A few snippets to work on some Windows support, a good way to make netbox-agent portable

https://www.activexperts.com/admin/scripts/wmi/python/0047/
http://timgolden.me.uk/python/wmi/wmi.html

If ipmitool is available, we should parse its output to:

• create the IPMI IP
• associate it to a "IPMI" Interface on the Device
• set it as management

It would be a nice feature to have the following component as Inventory Item:

• CPU
• Memory
• RAID cards
• Disks

One of the challenge will be to synchronize these infos

We need to see what the scripts does (create, update, delete), logging should be mandatory

sh# netbox_agent --debug -c /etc/netbox_agent.yaml

Traceback (most recent call last):
File "/usr/local/bin/netbox_agent", line 11, in
load_entry_point('netbox-agent==0.5.1.dev3+gbb7c8c8', 'console_scripts', 'netbox_agent')()
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8-py3.7.egg/netbox_agent/cli.py", line 39, in main
return run(config)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8-py3.7.egg/netbox_agent/cli.py", line 21, in run
manufacturer = dmidecode.get_by_type('Chassis')[0].get('Manufacturer')
TypeError: get_by_type() missing 1 required positional argument: 'type_id'

dmideode reports:
root@inet-xen-215-13:/netbox/netbox-agent/netbox_agent# dmidecode -t chassis

dmidecode 3.2

Getting SMBIOS data from sysfs.
SMBIOS 2.7 present.

Handle 0x0003, DMI type 3, 22 bytes
Chassis Information
Manufacturer: Supermicro
Type: Desktop
Lock: Not Present
Version: 0123456789
Serial Number: 0123456789
Asset Tag: To Be Filled By O.E.M.
Boot-up State: Safe
Power Supply State: Safe
Thermal State: Safe
Security Status: None
OEM Information: 0x00000000
Height: Unspecified
Number Of Power Cords: 1
Contained Elements: 0
SKU Number: To be filled by O.E.M.

An example of dmidecode output for multiple power supply

Handle 0x0066, DMI type 39, 22 bytes
System Power Supply
        Power Unit Group: 1
        Location: Not Specified
        Name: Power Supply 1
        Manufacturer: HPE
        Serial Number: 5FJCB0ALLAR795
        Asset Tag: Not Specified
        Model Part Number: 830272-B21
        Revision: Not Specified
        Max Power Capacity: 1600 W
        Status: Present, OK
        Type: Switching
        Input Voltage Range Switching: Auto-switch
        Plugged: Yes
        Hot Replaceable: Yes

Handle 0x0067, DMI type 39, 22 bytes
System Power Supply
        Power Unit Group: 1
        Location: Not Specified
        Name: Power Supply 2
        Manufacturer: HPE
        Serial Number: 5FJCB0ALLAR3CM
        Asset Tag: Not Specified
        Model Part Number: 830272-B21
        Revision: Not Specified
        Max Power Capacity: 1600 W
        Status: Present, OK
        Type: Switching
        Input Voltage Range Switching: Auto-switch
        Plugged: Yes
        Hot Replaceable: Yes

Handle 0x0068, DMI type 39, 22 bytes
System Power Supply
        Power Unit Group: 1
        Location: Not Specified
        Name: Power Supply 3
        Manufacturer: HPE
        Serial Number: 5FJCB0ALLAR2CL
        Asset Tag: Not Specified
        Model Part Number: 830272-B21
        Revision: Not Specified
        Max Power Capacity: 1600 W
        Status: Present, OK
        Type: Switching
        Input Voltage Range Switching: Auto-switch
        Plugged: Yes
        Hot Replaceable: Yes

I'm pretty embarrassed to ask this but I've spent hours trying to sort this out with no luck.

I get
ValueError: get() returned more than one result. Check that the kwarg(s) passed are valid for this endpoint or use filter() or all() instead.
when running python3 -m netbox_agent.cli -c ./agent.yaml --register

Here is the /etc/qualification file ( where I suspect the real issue is)

DATACENTER:

id: dmin-1 # I've also tried setting this to the id number in the data base (1)

agent.yaml

 # Netbox configuration

netbox:

url: 'http://netbox'

token: xxxx

# Network configuration

network:

 # Regex to ignore interfaces  

 ignore_interfaces: "(dummy.*|docker.*)"

 # Regex to ignore IP addresses

 ignore_ips: (127\.0\.0\..*)

 # enable auto-cabling by parsing LLDP answers

 lldp: true

## Enable virtual machine support  

# virtual:

#   # not mandatory, can be guessed

#   enabled: True

#   # see https://netbox.company.com/virtualization/clusters/

#   cluster_name: my_vm_cluster

# Enable datacenter location feature in Netbox

datacenter_location:

driver: "cmd:cat /etc/qualification | tr [a-z] [A-Z]"

regex: "DATACENTER: (?P<datacenter>[A-Za-z0-9]+)"

# driver: 'cmd:lldpctl'

# regex: 'SysName: .*\.([A-Za-z0-9]+)'

#

# driver: "file:/tmp/datacenter"

# regex: "(.*)"

# Enable rack location feature in Netbox

rack_location:

# driver: 'cmd:lldpctl'

# match SysName: sw-dist-a1.dc42

# regex: 'SysName:[ ]+[A-Za-z]+-[A-Za-z]+-([A-Za-z0-9]+)'

#

# driver: "file:/tmp/datacenter"

# regex: "(.*)"

# Enable local inventory reporting  

inventory: true

I've got several inputs saying that I should match the Slot name from dmidecode and not harcode the slot with Blade {{ slot_number }}

So we need to modify it the following way:

Dell

Handle 0x0202, DMI type 2, 14 bytes
Base Board Information
        Manufacturer: Dell Inc.
        Product Name: Not Specified
        Version: Not Specified
        Serial Number: .8CKL35J..05.
        Asset Tag: Not Specified
        Features:
                Board is removable
                Board is replaceable
        Location In Chassis: Slot 05
        Chassis Handle: 0x0300
        Type: Interconnect Board

And take Slot 05

Handle 0x0200, DMI type 2, 14 bytes
Base Board Information
        Manufacturer: Dell Inc.
        Product Name: 0MN3VC
        Version: A01
        Serial Number: .4866F5J.CN7016327F004Z.01a.
        Asset Tag:                               
        Features:
                Board is a hosting board
                Board is removable
                Board is replaceable
                Board is hot swappable
        Location In Chassis: Slot 01a    
        Chassis Handle: 0x0300
        Type: Server Blade

And take Slot 01a

HP

Handle 0x0030, DMI type 204, 20 bytes
HP ProLiant System/Rack Locator
        Rack Name: Bay-D22
        Enclosure Name: blade-D22-xx
        Enclosure Model: BladeSystem c7000 Enclosure G2
        Enclosure Serial: CZ3332KYYD
        Enclosure Bays: 16
        Server Bay: 2
        Bays Filled: 1

And take Bay 2

Some manufacturers doesn't not let us find if a server is a blade programatically

In order to let the user manage this his way, we need to let it handle this case with CLI/config parameters like:

--is-blade
--chassis <S/N of the chassis>
--blade-slot "Slot 01"

handles #149 case

Use the same code as datacenter awareness for rack

So, memory, disk, network, CPU all nice and neat.. NVME is also partially included - I have another node that has this..

It doesn't use dmi to do this, it uses the output of lshw to collect it.

I think I need to make the asset tags unique, so I was going to make it 'hostname:part'

thomas

We shouldn't hardcode the behavior of network interface discovery and instead use parameters in the configuration file to let the user choose what they want to ignore

That way we will manage corner cases of users having loopback IP (ipvs, bgp etc)
And also create vlan interfaces, which is not working right now

I propose something like:

network:
  ignore_interfaces: "(dummy.*|docker.*)"
  ignore_ips: "(127\.0\.0\..*)"

I think it's mandatory to create the Device (chassis / blade / server) within a datacenter and if possible within a rack.

The problem is that there's no generic way to get these infos because it's not a standard like dmidecode. Each company has its own nomenclature and from what I can see, the info can be in:

• a hostname (ie: web-42.nyc)
• a file (ie: /etc/server_infos)
• a saltstack grain (ie: salt-call grains.get datacenter)
• another webservice (ie: curl https://other-api.internal.company.com/server?service_tag=XXX | jq -r .datacenter)

Since netbox_agent needs to be as generic as possible, we cannot put this kind of code in the project.

We may need a configuration file for the agent (http proxy, netbox URL, api_key and so on), so we could do something like:

DATACENTER_LOCATION = '<driver>:<location>'

Some examples could be:

DATACENTER_LOCATION = 'file:/etc/server_infos'
DATACENTER_LOCATION = 'url:https://other-api.internal.company.com/server?service_tag={{ service_tag }}'
DATACENTER_LOCATION = 'cmd:hostname'
DATACENTER_LOCATION = 'cmd:lldpctl'

and a DATACENTER_LOCATION_REGEX that would extract the slug/name of the datacenter within the output.

People could add a new "driver" if needed.

Ideas?

Right now, the agent doesn't handle anycast IPs

If you two servers run the agent in update mode, the IP will move from one server to another in a loop.
So we'd require the user to manually create the IP in Netbox with the Anycast role so that the agent behave like this:

• If IP exists and is in Anycast, create a new Anycast one
• If IP exists and isn't assigned, take it
• If server is decomissioned, the free IP will be taken

running netbox_agent on a rapsberry PI makes the program crash:

# netbox_agent -c nbagent.yaml --register
Traceback (most recent call last):
  File "/usr/local/bin/netbox_agent", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.7/dist-packages/netbox_agent/cli.py", line 44, in main
    return run(config)
  File "/usr/local/lib/python3.7/dist-packages/netbox_agent/cli.py", line 22, in run
    dmi = dmidecode.parse()
  File "/usr/local/lib/python3.7/dist-packages/netbox_agent/dmidecode.py", line 74, in parse
    _data = _parse(buffer)
  File "/usr/local/lib/python3.7/dist-packages/netbox_agent/dmidecode.py", line 216, in _parse
    raise ParseError("Unable to parse 'dmidecode' output")
netbox_agent.dmidecode.ParseError: Unable to parse 'dmidecode' output

root@node05:/home/pi# dmidecode
# dmidecode 3.2
Scanning /dev/mem for entry point.
# No SMBIOS nor DMI entry point found, sorry.

where I guess we could use other info like:

$cat /proc/cpuinfo
...
$cat /proc/device-tree/model
Raspberry Pi 4 Model B Rev 1.1
$ inix -F
inxi -F
System:    Host: node05.home.lab Kernel: 4.19.97-v7l+ armv7l bits: 32 Console: tty 1
           Distro: Raspbian GNU/Linux 10 (buster)
Machine:   Type: ARM Device System: Raspberry Pi 4 Model B Rev 1.1 details: BCM2835 rev: c03111
           serial: 10000000256decd8
Argument "Raspberry Pi 4 Model B Rev 1.1" isn't numeric in sprintf at /usr/bin/inxi line 6969.
CPU:       Topology: Quad Core model: ARMv7 v7l variant: cortex-a72 bits: 32 type: MCP
           Speed: 1500 MHz min/max: 600/1500 MHz Core speeds (MHz): 1: 1500 2: 1500 3: 1500 4: 1500
Graphics:  Device-1: bcm2835-vc4 driver: vc4_drm v: N/A
           Device-2: bcm2835-hdmi driver: N/A
           Display: server: No display server data found. Headless machine? tty: 120x48
           Message: Advanced graphics data unavailable in console for root.
Audio:     Device-1: bcm2835-audio driver: bcm2835_audio
           Device-2: bcm2835-hdmi driver: N/A
           Sound Server: ALSA v: k4.19.97-v7l+
Network:   Message: No ARM data found for this feature.
           IF-ID-1: eth0 state: down mac: xxxx
          IF-ID-2: wlan0 state: up mac: xxx

or even all usefull commands in there: https://raw.githubusercontent.com/raspberrypi/utils/master/raspinfo/raspinfo

Any way it could be supported in some way?
Thanks

It would be great at some point if we could create packages for this project so it's easier for lazy sysadmins to install the agent

I assume that not everybody is a fan of installing packages and dependencies through pip

If Debian/RPM/etc packages were available it'd be a nice addition!

the agent is recognizing Supermicro SYS-1029U-E1CRTP-2-LL09G as a chassis. This should be a 1U service not a chassis. Is there a specific override that I can set in the config file? I don't have any chassis in my infra.

Also identifying any servers with motherboard X11SPW-TF as a blade.

We should parse lldp output and handle as many cases as possible in order to connection between server's interface and switch's interface

We should try to make sure configuration's file arguments can be passed as CLI arguments like Kubernetes binaries

We should also enable specific behaviors like:

• --create-missing: create missing blade chassis, network NICs, VLAN, IP, etc
• --update-all
• --update-{rack,datacenter,network,inventory}

I suggest that an example be added that shows how to invoke the netbox-agent from the cli and/or Python shell.
I believe this would make the user-base larger.

After getting the fixed code from #117 i still have issues but on other location. We definitely need more "catches" of errors.

This time the error is:
INFO:root:Creating RAID Card Supermicro SMC2108 (SN: FW-AD116BVAARBWA)
DEBUG:urllib3.connectionpool:http://XXXX:80 "GET /api/dcim/inventory-items/?device_id=2&tag=hw-disk HTTP/1.1" 200 52
DEBUG:urllib3.connectionpool:http://XXXX:80 "GET /api/dcim/manufacturers/?name=SMC2108 HTTP/1.1" 200 168
DEBUG:urllib3.connectionpool:http://XXXX:80 "POST /api/dcim/inventory-items/ HTTP/1.1" 201 453
INFO:root:Creating Disk SMC2108 003051452737b65c1a9072ab05b00506
DEBUG:urllib3.connectionpool:http://XXXX:80 "GET /api/dcim/manufacturers/?name= HTTP/1.1" 200 2269
Traceback (most recent call last):
File "/usr/local/bin/netbox_agent", line 11, in
load_entry_point('netbox-agent==0.5.1.dev5+gdc4f90d.d20200221', 'console_scripts', 'netbox_agent')()
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev5+gdc4f90d.d20200221-py3.7.egg/netbox_agent/cli.py", line 40, in main
return run(config)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev5+gdc4f90d.d20200221-py3.7.egg/netbox_agent/cli.py", line 35, in run
server.netbox_update(config)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev5+gdc4f90d.d20200221-py3.7.egg/netbox_agent/server.py", line 337, in netbox_update
self.inventory.update()
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev5+gdc4f90d.d20200221-py3.7.egg/netbox_agent/inventory.py", line 461, in update
self.do_netbox_disks()
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev5+gdc4f90d.d20200221-py3.7.egg/netbox_agent/inventory.py", line 402, in do_netbox_disks
self.create_netbox_disk(disk)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev5+gdc4f90d.d20200221-py3.7.egg/netbox_agent/inventory.py", line 351, in create_netbox_disk
manufacturer = self.find_or_create_manufacturer(disk["Vendor"])
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev5+gdc4f90d.d20200221-py3.7.egg/netbox_agent/inventory.py", line 75, in find_or_create_manufacturer
name=name,
File "/usr/local/lib/python3.7/dist-packages/pynetbox-4.2.4-py3.7.egg/pynetbox/core/endpoint.py", line 142, in get
"get() returned more than one result. "
ValueError: get() returned more than one result. Check that the kwarg(s) passed are valid for this endpoint or use filter() or all() instead.

Will check this script later on my X10 chassis. We also have X11 chassis, but havent tested there.

Traceback (most recent call last):
File "/usr/local/bin/netbox_agent", line 11, in
load_entry_point('netbox-agent==0.5.1.dev3+gbb7c8c8.d20200216', 'console_scripts', 'netbox_agent')()
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/cli.py", line 40, in main
return run(config)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/cli.py", line 35, in run
server.netbox_update(config)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/server.py", line 336, in netbox_update
self.inventory = Inventory(server=self)
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/inventory.py", line 56, in init
self.lshw = LSHW()
File "/usr/local/lib/python3.7/dist-packages/netbox_agent-0.5.1.dev3+gbb7c8c8.d20200216-py3.7.egg/netbox_agent/lshw.py", line 18, in init
self.hw_info = json.loads(data)
File "/usr/lib/python3.7/json/init.py", line 348, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3.7/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python3.7/json/decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 25 column 8 (char 679)

i am using the master branch with the manual applied fixes from the "fix" branch

We used to have a clear dmidecode output with previous generation:

Handle 0x0030, DMI type 204, 20 bytes
HP ProLiant System/Rack Locator
    Rack Name: Bay-D22
    Enclosure Name: blade-D22-DC3
    Enclosure Model: BladeSystem c7000 Enclosure G2
    Enclosure Serial: CZ3332KXX
    Enclosure Bays: 16
    Server Bay: 2
    Bays Filled: 1

But now we need to parse this shittier output..

Handle 0x0066, DMI type 204, 20 bytes
OEM-specific Type
    Header and Data:
        CC 14 66 00 01 02 03 04 10 01 05 06 00 00 00 00
        00 00 00 00
    Strings:
        Z04b
        blade-z04b
        BladeSystem c7000 Enclosure G3
        7
        CZ29040XXX
        10.0.0.1

Hello,

The script seem to detect cdrom as a disk but as there is no size for it, i get the following error :

Traceback (most recent call last):
File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/tmp/netbox-agent/netbox_agent/cli.py", line 48, in
main()
File "/tmp/netbox-agent/netbox_agent/cli.py", line 44, in main
return run(config)
File "/tmp/netbox-agent/netbox_agent/cli.py", line 39, in run
server.netbox_create_or_update(config)
File "/tmp/netbox-agent/netbox_agent/server.py", line 296, in netbox_create_or_update
self.inventory.create_or_update()
File "/tmp/netbox-agent/netbox_agent/inventory.py", line 447, in create_or_update
self.do_netbox_disks()
File "/tmp/netbox-agent/netbox_agent/inventory.py", line 385, in do_netbox_disks
disks = self.get_hw_disks()
File "/tmp/netbox-agent/netbox_agent/inventory.py", line 326, in get_hw_disks
d['Size'] = '{} GB'.format(int(size / 1024 / 1024 / 1024))
TypeError: unsupported operand type(s) for /: 'NoneType' and 'int'

And enable them in tox

In particular, the UCS series)

The server should report its NICs to netbox with MAC addresses, speed (if known) and type of connector

As identified in #149, the agent crashed with the following output

File "/tmp/netbox/netbox_agent/cli.py", line 39, in run
   server.netbox_create_or_update(config)
 File "/tmp/netbox/netbox_agent/server.py", line 306, in netbox_create_or_update
   if server.name != self.get_hostname():
AttributeError: 'NoneType' object has no attribute 'name'

With Netbox v2.8.6

Hi
could you update config.py, so it can work with self-signed certificates?
Proposal:

• add an option to netbox-agent: --ignore-ssl-verify

Modifications (in addition of adding the option):

• in config.py line line 1

import requests
import urllib3
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)

then line 80:

if (no_ssl_verify):
    session = requests.Session()
    session.verify = False

nb = pynetbox.api(
     url=get_config().netbox.url,
     token=get_config().netbox.token
)
if (no_ssl_verify):
    nb.http_session = session
return nb

Thanks!

Describe the bug
If a device already has interfaces with no MAC set (e.g. device type template interfaces) netbox-agent bails out. It seems it can't find the interface because it's searching by mac&name. I think it should be searching by device&name since this is enough to uniquely identify interfaces.

Expected behavior
MAC address should be updated for existing interfaces.

Configuration file
N/A

Environment:
N/A

Additional context
This is the patch I applied to get it to work for me. This probably breaks other stuff but at least shows what I mean.

# diff /usr/local/lib/python3.6/site-packages/netbox_agent/network.old.py /usr/local/lib/python3.6/site-packages/netbox_agent/network.py
145,155c145,149
<         if nic['mac'] is None:
<             interface = self.nb_net.interfaces.get(
<                 name=nic['name'],
<                 **self.custom_arg_id,
<             )
<         else:
<             interface = self.nb_net.interfaces.get(
<                 mac_address=nic['mac'],
<                 name=nic['name'],
<                 **self.custom_arg_id,
<             )
---
> 	# Should/can this query by device&name?
>         interface = self.nb_net.interfaces.get(
>             name=nic['name'],
>             **self.custom_arg_id,
>         )
409a404,409
>                 nic_update += 1
>
>             if nic['mac'] != getattr(interface, 'mac_address', ''):
>                 logging.info('Updating interface {interface} mac to: {mac}'.format(
>                     interface=interface, mac=nic['mac']))
>                 interface.mac_address = nic['mac']